[PATCH] uclibc: Add SRCBRANCH for use by SRC_URI

[PATCH] uclibc: Add SRCBRANCH for use by SRC_URI

[Yen-Chin Lee]

Add SRCBRANCH to control git branch.

Signed-off-by: Yen-Chin Lee <coldnew.tw@gmail.com>
---
 meta/recipes-core/uclibc/uclibc-git.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/uclibc/uclibc-git.inc b/meta/recipes-core/uclibc/uclibc-git.inc
index 14a577f..e179fc7 100644
--- a/meta/recipes-core/uclibc/uclibc-git.inc
+++ b/meta/recipes-core/uclibc/uclibc-git.inc
@@ -4,7 +4,9 @@ PV = "0.9.33+git${SRCPV}"
 
 FILESEXTRAPATHS =. "${FILE_DIRNAME}/uclibc-git:"
 
-SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
+SRCBRANCH ??= "master"
+
+SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \
         file://uClibc.machine \
         file://uClibc.distro \
         file://obstack.cfg \
-- 
2.3.6

Re: [PATCH] uclibc: Add SRCBRANCH for use by SRC_URI

[Khem Raj]

On Thu, Aug 20, 2015 at 12:32 AM, Yen-Chin Lee <coldnew.tw@gmail.com> wrote:
> -SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
> +SRCBRANCH ??= "master"
> +
> +SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \

this is ok. Just call is BRANCH instead of SRCBRANCH

Re: [PATCH] uclibc: Add SRCBRANCH for use by SRC_URI

[Otavio Salvador]

On Thu, Aug 20, 2015 at 11:19 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Aug 20, 2015 at 12:32 AM, Yen-Chin Lee <coldnew.tw@gmail.com> wrote:
>> -SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
>> +SRCBRANCH ??= "master"
>> +
>> +SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \
>
> this is ok. Just call is BRANCH instead of SRCBRANCH

Personally I prefer SRCBRANCH. This is personal option though.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] uclibc: Add SRCBRANCH for use by SRC_URI

[Khem Raj]

On Fri, Aug 21, 2015 at 3:31 AM, Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
> On Thu, Aug 20, 2015 at 11:19 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Thu, Aug 20, 2015 at 12:32 AM, Yen-Chin Lee <coldnew.tw@gmail.com> wrote:
>>> -SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
>>> +SRCBRANCH ??= "master"
>>> +
>>> +SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \
>>
>> this is ok. Just call is BRANCH instead of SRCBRANCH
>
> Personally I prefer SRCBRANCH. This is personal option though.

consistency is what I wanted here. There is BRANCH used for same
reason in some other recipes, it can be any name I don't have a
preference.
if you prefer SRCBRANCH, propose another patch to rename other
usecases in metadata to use it as well.

>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] uclibc: Add SRCBRANCH for use by SRC_URI

[Otavio Salvador]

On Fri, Aug 21, 2015 at 12:33 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Aug 21, 2015 at 3:31 AM, Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
>> On Thu, Aug 20, 2015 at 11:19 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>> On Thu, Aug 20, 2015 at 12:32 AM, Yen-Chin Lee <coldnew.tw@gmail.com> wrote:
>>>> -SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
>>>> +SRCBRANCH ??= "master"
>>>> +
>>>> +SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \
>>>
>>> this is ok. Just call is BRANCH instead of SRCBRANCH
>>
>> Personally I prefer SRCBRANCH. This is personal option though.
>
> consistency is what I wanted here. There is BRANCH used for same
> reason in some other recipes, it can be any name I don't have a
> preference.
> if you prefer SRCBRANCH, propose another patch to rename other
> usecases in metadata to use it as well.

Yes; I sent this for OE-Core but ended using SRC_BRANCH so it clearly
relates to SRC_URI.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750