Re: [PATCH nf V2] netfilter: nfnl_cthelper: fix a race when walk the nf_ct_helper_hash table

From: Liping Zhang <zlpnobody@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Liping Zhang <zlpnobody@163.com>,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf V2] netfilter: nfnl_cthelper: fix a race when walk the nf_ct_helper_hash table
Date: Fri, 24 Mar 2017 19:56:55 +0800	[thread overview]
Message-ID: <CAML_gOcjtCdjwUsxio7His1Bt_HN7QUv_iO9bANBdMQKRfQOPA@mail.gmail.com> (raw)
In-Reply-To: <20170324113749.GA2264@salvia>

Hi Pablo,

2017-03-24 19:37 GMT+08:00 Pablo Neira Ayuso <pablo@netfilter.org>:
[...]
>> +struct nfnl_cthelper {
>> +     struct list_head                list;
>> +     struct nf_conntrack_helper      *helper;
>> +};
>
> I overlook this. Any reason for not using this declaration instead?
>
> struct nfnl_cthelper {
>         struct list_head                list;
>         struct nf_conntrack_helper      helper;
> };
>
> We would simplify this a bit as the helper would be embedded into the
> new nfnl_cthelper structure.

Yes, this will be better. I will send V3 later.