[PATCH] staging: vc04_services: Avoid NULL comparison

[PATCH] staging: vc04_services: Avoid NULL comparison

[Nachammai Karuppiah]

Remove NULL comparison. Issue found using checkpatch.pl

Signed-off-by: Nachammai Karuppiah <nachukannan@gmail.com>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 17a4f2c..a2268d5 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -628,7 +628,7 @@ int32_t vchi_service_open(VCHI_INSTANCE_T instance_handle,
 		}
 	}
 
-	return (service != NULL) ? 0 : -1;
+	return (service) ? 0 : -1;
 }
 EXPORT_SYMBOL(vchi_service_open);
 
-- 
2.7.4

Re: [PATCH] staging: vc04_services: Avoid NULL comparison

[Stefan Wahren]

Hi Nachammai,

Am 03.10.19 um 19:01 schrieb Nachammai Karuppiah:
> Remove NULL comparison. Issue found using checkpatch.pl
>
> Signed-off-by: Nachammai Karuppiah <nachukannan@gmail.com>
> ---
could you please add devel@driverdev.osuosl.org to CC?
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> index 17a4f2c..a2268d5 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> @@ -628,7 +628,7 @@ int32_t vchi_service_open(VCHI_INSTANCE_T instance_handle,
>  		}
>  	}
>
> -	return (service != NULL) ? 0 : -1;
> +	return (service) ? 0 : -1;

Do you think the braces are still necessary in this case?

Btw a quick find -type f | xargs grep "!= NULL" within the
vc04_services/interface reveals more occurences. Would be nice to fix
them all and for once.

Thanks
Stefan

>  }
>  EXPORT_SYMBOL(vchi_service_open);
>

Re: [PATCH] staging: vc04_services: Avoid NULL comparison

[Nachammai Karuppiah]

On Thu, Oct 3, 2019 at 1:19 PM Stefan Wahren <wahrenst@gmx.net> wrote:
>
> Hi Nachammai,
>
> Am 03.10.19 um 19:01 schrieb Nachammai Karuppiah:
> > Remove NULL comparison. Issue found using checkpatch.pl
> >
> > Signed-off-by: Nachammai Karuppiah <nachukannan@gmail.com>
> > ---
> could you please add devel@driverdev.osuosl.org to CC?
> >  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > index 17a4f2c..a2268d5 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > @@ -628,7 +628,7 @@ int32_t vchi_service_open(VCHI_INSTANCE_T instance_handle,
> >               }
> >       }
> >
> > -     return (service != NULL) ? 0 : -1;
> > +     return (service) ? 0 : -1;
>
> Do you think the braces are still necessary in this case?
>
> Btw a quick find -type f | xargs grep "!= NULL" within the
> vc04_services/interface reveals more occurences. Would be nice to fix
> them all and for once.

Will get rid of the braces.
Sure, I will remove all NULL comparisons in vc04_services/interface
and update this patch.

Thanks,
Nachammai
>
> Thanks
> Stefan
>
> >  }
> >  EXPORT_SYMBOL(vchi_service_open);
> >

Re: [Outreachy kernel] [PATCH] staging: vc04_services: Avoid NULL comparison

[Julia Lawall]

On Thu, 3 Oct 2019, Nachammai Karuppiah wrote:

> Remove NULL comparison. Issue found using checkpatch.pl
>
> Signed-off-by: Nachammai Karuppiah <nachukannan@gmail.com>
> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> index 17a4f2c..a2268d5 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> @@ -628,7 +628,7 @@ int32_t vchi_service_open(VCHI_INSTANCE_T instance_handle,
>  		}
>  	}
>
> -	return (service != NULL) ? 0 : -1;
> +	return (service) ? 0 : -1;

You don't need the parentheses.

julia

>  }
>  EXPORT_SYMBOL(vchi_service_open);
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1570122078-23942-1-git-send-email-nachukannan%40gmail.com.
>

Re: [Outreachy kernel] [PATCH] staging: vc04_services: Avoid NULL comparison

[Nachammai Karuppiah]

On Thu, Oct 3, 2019 at 5:10 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>
> On Thu, 3 Oct 2019, Nachammai Karuppiah wrote:
>
> > Remove NULL comparison. Issue found using checkpatch.pl
> >
> > Signed-off-by: Nachammai Karuppiah <nachukannan@gmail.com>
> > ---
> >  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > index 17a4f2c..a2268d5 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > @@ -628,7 +628,7 @@ int32_t vchi_service_open(VCHI_INSTANCE_T instance_handle,
> >               }
> >       }
> >
> > -     return (service != NULL) ? 0 : -1;
> > +     return (service) ? 0 : -1;
>
> You don't need the parentheses.
>

Yes, will remove the parenthesis.

Nachammai

> julia
>
> >  }
> >  EXPORT_SYMBOL(vchi_service_open);
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1570122078-23942-1-git-send-email-nachukannan%40gmail.com.
> >