From: Felipe Contreras <felipe.contreras@gmail.com> To: Heikki Krogerus <krohei@gmail.com> Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>, Russell King <linux@arm.linux.org.uk>, Kalle Jokiniemi <kalle.jokiniemi@nokia.com>, Anton Vorontsov <cbouatmailru@gmail.com> Subject: Re: [PATCH] omap: rx51: initialize isp1704 properly Date: Thu, 8 Dec 2011 22:23:58 +0200 [thread overview] Message-ID: <CAMP44s2noD4TXBALOc0JkcbVroYFnp3BaSozrQYdUbsv50xuoQ@mail.gmail.com> (raw) In-Reply-To: <20111208144044.GA25415@xps8300> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote: > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: >> From: Heikki Krogerus <krohei@gmail.com> > > I would prefer that you change this so this is from you, like it > actually is. You can mention me in the commit message if you like. Well, you came with the fix, I just typed it down, but as you wish :) >> Without this USB networking doesn't work as the link is never detected. > > What this changes is, it leaves the transceiver powered by default > instead of setting it into power off mode. So not only USB networking > is affected by this. If isp1704_charger is not enabled with RX51, USB > does not work at all. Please change the comment. I've updated the patch. Cheers. -- Felipe Contreras
WARNING: multiple messages have this Message-ID (diff)
From: felipe.contreras@gmail.com (Felipe Contreras) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] omap: rx51: initialize isp1704 properly Date: Thu, 8 Dec 2011 22:23:58 +0200 [thread overview] Message-ID: <CAMP44s2noD4TXBALOc0JkcbVroYFnp3BaSozrQYdUbsv50xuoQ@mail.gmail.com> (raw) In-Reply-To: <20111208144044.GA25415@xps8300> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote: > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: >> From: Heikki Krogerus <krohei@gmail.com> > > I would prefer that you change this so this is from you, like it > actually is. You can mention me in the commit message if you like. Well, you came with the fix, I just typed it down, but as you wish :) >> Without this USB networking doesn't work as the link is never detected. > > What this changes is, it leaves the transceiver powered by default > instead of setting it into power off mode. So not only USB networking > is affected by this. If isp1704_charger is not enabled with RX51, USB > does not work at all. Please change the comment. I've updated the patch. Cheers. -- Felipe Contreras
next prev parent reply other threads:[~2011-12-08 20:24 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-12-05 17:23 [PATCH 0/2] omap: rx51: fix USB networking Felipe Contreras 2011-12-05 17:23 ` [PATCH 1/2] isp1704_charger: fix missing check Felipe Contreras 2011-12-08 14:42 ` Heikki Krogerus 2012-01-06 2:02 ` Anton Vorontsov 2011-12-05 17:23 ` [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off" Felipe Contreras 2011-12-05 17:31 ` Felipe Contreras 2011-12-07 11:46 ` Jarkko Nikula 2011-12-07 18:42 ` Felipe Contreras 2011-12-12 7:09 ` Jarkko Nikula 2011-12-13 21:19 ` Felipe Contreras 2011-12-13 22:53 ` Felipe Balbi 2011-12-13 23:02 ` Felipe Contreras 2011-12-14 7:30 ` Felipe Balbi 2011-12-14 19:31 ` Felipe Contreras 2011-12-07 7:14 ` kalle.jokiniemi 2011-12-07 10:57 ` Felipe Contreras 2011-12-07 13:05 ` Heikki Krogerus 2011-12-07 18:43 ` Felipe Contreras 2011-12-07 19:31 ` Tony Lindgren 2011-12-07 19:56 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras 2011-12-07 19:56 ` Felipe Contreras 2011-12-08 14:40 ` Heikki Krogerus 2011-12-08 14:40 ` Heikki Krogerus 2011-12-08 20:23 ` [PATCH v2] omap: rx51: fix USB Felipe Contreras 2011-12-08 20:23 ` Felipe Contreras 2011-12-10 8:37 ` Sebastian Reichel 2011-12-10 8:37 ` Sebastian Reichel 2011-12-08 20:23 ` Felipe Contreras [this message] 2011-12-08 20:23 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras 2011-12-12 19:44 ` Tony Lindgren 2011-12-12 19:44 ` Tony Lindgren 2011-12-13 20:00 ` Sebastian Reichel 2011-12-13 20:00 ` Sebastian Reichel 2011-12-13 20:05 ` Felipe Contreras 2011-12-13 20:05 ` Felipe Contreras 2011-12-13 21:55 ` Tony Lindgren 2011-12-13 21:55 ` Tony Lindgren 2011-12-08 14:13 ` [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off" Felipe Contreras
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMP44s2noD4TXBALOc0JkcbVroYFnp3BaSozrQYdUbsv50xuoQ@mail.gmail.com \ --to=felipe.contreras@gmail.com \ --cc=cbouatmailru@gmail.com \ --cc=kalle.jokiniemi@nokia.com \ --cc=krohei@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.