All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] git-merge-tree.txt: replace spurious HTML entity
@ 2023-03-04 17:00 Andreas Schwab
  2023-03-04 21:50 ` Elijah Newren
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2023-03-04 17:00 UTC (permalink / raw)
  To: git

Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
 Documentation/git-merge-tree.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-merge-tree.txt b/Documentation/git-merge-tree.txt
index 88ee942101..ffc4fbf7e8 100644
--- a/Documentation/git-merge-tree.txt
+++ b/Documentation/git-merge-tree.txt
@@ -108,7 +108,7 @@ This is an integer status followed by a NUL character.  The integer status is:
 
      0: merge had conflicts
      1: merge was clean
-     &lt;0: something prevented the merge from running (e.g. access to repository
+     <0: something prevented the merge from running (e.g. access to repository
 	 objects denied by filesystem)
 
 [[OIDTLT]]
-- 
2.39.1


-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] git-merge-tree.txt: replace spurious HTML entity
  2023-03-04 17:00 [PATCH] git-merge-tree.txt: replace spurious HTML entity Andreas Schwab
@ 2023-03-04 21:50 ` Elijah Newren
  2023-03-05  0:43   ` Felipe Contreras
  0 siblings, 1 reply; 3+ messages in thread
From: Elijah Newren @ 2023-03-04 21:50 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: git, brian m. carlson

On Sat, Mar 4, 2023 at 9:48 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
>  Documentation/git-merge-tree.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-merge-tree.txt b/Documentation/git-merge-tree.txt
> index 88ee942101..ffc4fbf7e8 100644
> --- a/Documentation/git-merge-tree.txt
> +++ b/Documentation/git-merge-tree.txt
> @@ -108,7 +108,7 @@ This is an integer status followed by a NUL character.  The integer status is:
>
>       0: merge had conflicts
>       1: merge was clean
> -     &lt;0: something prevented the merge from running (e.g. access to repository
> +     <0: something prevented the merge from running (e.g. access to repository
>          objects denied by filesystem)

I'm sure I'm the one who put it there, but I don't remember any
details.  I think it unlikely I would have jumped to '&lt;' without
trying '<' and hitting an error first, though maybe I really did.
Also, there could have been other edits since then; perhaps this was
only needed when other characters appeared later on the line?  Or
maybe the '&lt;' is only needed by asciidoc and not asciidoctor (or
vice versa; I have no clue which I was using)?  Should we add a
"lessthan" field in Documentation/asciidoc.conf under "[attributes]"
and use "{lessthan}"?

Or, if this one really is spurious, should the same html entity in
Documentation/git-rev-list.txt be expunged as well?

Cc'ing brian who knows way more about asciidoc than I...

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] git-merge-tree.txt: replace spurious HTML entity
  2023-03-04 21:50 ` Elijah Newren
@ 2023-03-05  0:43   ` Felipe Contreras
  0 siblings, 0 replies; 3+ messages in thread
From: Felipe Contreras @ 2023-03-05  0:43 UTC (permalink / raw)
  To: Elijah Newren; +Cc: Andreas Schwab, git, brian m. carlson

On Sat, Mar 4, 2023 at 4:27 PM Elijah Newren <newren@gmail.com> wrote:
>
> On Sat, Mar 4, 2023 at 9:48 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
> >
> > Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> > ---
> >  Documentation/git-merge-tree.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/git-merge-tree.txt b/Documentation/git-merge-tree.txt
> > index 88ee942101..ffc4fbf7e8 100644
> > --- a/Documentation/git-merge-tree.txt
> > +++ b/Documentation/git-merge-tree.txt
> > @@ -108,7 +108,7 @@ This is an integer status followed by a NUL character.  The integer status is:
> >
> >       0: merge had conflicts
> >       1: merge was clean
> > -     &lt;0: something prevented the merge from running (e.g. access to repository
> > +     <0: something prevented the merge from running (e.g. access to repository
> >          objects denied by filesystem)
>
> I'm sure I'm the one who put it there, but I don't remember any
> details.  I think it unlikely I would have jumped to '&lt;' without
> trying '<' and hitting an error first, though maybe I really did.
> Also, there could have been other edits since then; perhaps this was
> only needed when other characters appeared later on the line?  Or
> maybe the '&lt;' is only needed by asciidoc and not asciidoctor (or
> vice versa; I have no clue which I was using)?  Should we add a
> "lessthan" field in Documentation/asciidoc.conf under "[attributes]"
> and use "{lessthan}"?

For what it's worth I checked with both asciidoc and asciidoctor in
multiple output formats and < works fine. I even checked an ancient
version of asciidoc and it works fine.

It doesn't seem like &lt; was ever needed, and it doesn't work because
it's a literal section.

> Or, if this one really is spurious, should the same html entity in
> Documentation/git-rev-list.txt be expunged as well?

<= is automatically replaced with ⇐ as explained in the documentation
[1]. However, to prevent substitutions one doesn't need HTML coding,
just doing \<= is enough.

I don't know why people try to guess what asciidoc and asciidoctor
should do, they both follow the same specification, and I haven't seen
a problem in git documentation caused by either one of them not
following the spec, only by git not following the spec.

Just follow the spec.

Cheers.

[1] https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/

-- 
Felipe Contreras

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-05  0:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-04 17:00 [PATCH] git-merge-tree.txt: replace spurious HTML entity Andreas Schwab
2023-03-04 21:50 ` Elijah Newren
2023-03-05  0:43   ` Felipe Contreras

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.