* [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
@ 2012-07-06 8:49 ` Peter Ujfalusi
0 siblings, 0 replies; 14+ messages in thread
From: Peter Ujfalusi @ 2012-07-06 8:49 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, linux-arm-kernel
The sys_nirq2 is used for twl6040, make sure the pin is configured
correctly.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/board-4430sdp.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
index c4e17641..050cc8e 100644
--- a/arch/arm/mach-omap2/board-4430sdp.c
+++ b/arch/arm/mach-omap2/board-4430sdp.c
@@ -827,6 +827,9 @@ static void __init omap_4430sdp_display_init(void)
#ifdef CONFIG_OMAP_MUX
static struct omap_board_mux board_mux[] __initdata = {
OMAP4_MUX(USBB2_ULPITLL_CLK, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
+ /* NIRQ2 for twl6040 */
+ OMAP4_MUX(SYS_NIRQ2, OMAP_MUX_MODE1 |
+ OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE),
{ .reg_offset = OMAP_MUX_TERMINATOR },
};
--
1.7.8.6
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
@ 2012-07-06 8:49 ` Peter Ujfalusi
0 siblings, 0 replies; 14+ messages in thread
From: Peter Ujfalusi @ 2012-07-06 8:49 UTC (permalink / raw)
To: linux-arm-kernel
The sys_nirq2 is used for twl6040, make sure the pin is configured
correctly.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/board-4430sdp.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
index c4e17641..050cc8e 100644
--- a/arch/arm/mach-omap2/board-4430sdp.c
+++ b/arch/arm/mach-omap2/board-4430sdp.c
@@ -827,6 +827,9 @@ static void __init omap_4430sdp_display_init(void)
#ifdef CONFIG_OMAP_MUX
static struct omap_board_mux board_mux[] __initdata = {
OMAP4_MUX(USBB2_ULPITLL_CLK, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
+ /* NIRQ2 for twl6040 */
+ OMAP4_MUX(SYS_NIRQ2, OMAP_MUX_MODE1 |
+ OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE),
{ .reg_offset = OMAP_MUX_TERMINATOR },
};
--
1.7.8.6
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: OMAP: board-omap4panda: MUX configuration for sys_nirq2
2012-07-06 8:49 ` Peter Ujfalusi
@ 2012-07-06 8:49 ` Peter Ujfalusi
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Ujfalusi @ 2012-07-06 8:49 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, linux-arm-kernel
The sys_nirq2 is used for twl6040, make sure the pin is configured
correctly.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/board-omap4panda.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index 982fb26..6111b72 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -379,6 +379,9 @@ static struct omap_board_mux board_mux[] __initdata = {
OMAP4_MUX(DPM_EMU18, OMAP_PIN_OUTPUT | OMAP_MUX_MODE5),
/* dispc2_data0 */
OMAP4_MUX(DPM_EMU19, OMAP_PIN_OUTPUT | OMAP_MUX_MODE5),
+ /* NIRQ2 for twl6040 */
+ OMAP4_MUX(SYS_NIRQ2, OMAP_MUX_MODE1 |
+ OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE),
{ .reg_offset = OMAP_MUX_TERMINATOR },
};
--
1.7.8.6
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: OMAP: board-omap4panda: MUX configuration for sys_nirq2
@ 2012-07-06 8:49 ` Peter Ujfalusi
0 siblings, 0 replies; 14+ messages in thread
From: Peter Ujfalusi @ 2012-07-06 8:49 UTC (permalink / raw)
To: linux-arm-kernel
The sys_nirq2 is used for twl6040, make sure the pin is configured
correctly.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/board-omap4panda.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index 982fb26..6111b72 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -379,6 +379,9 @@ static struct omap_board_mux board_mux[] __initdata = {
OMAP4_MUX(DPM_EMU18, OMAP_PIN_OUTPUT | OMAP_MUX_MODE5),
/* dispc2_data0 */
OMAP4_MUX(DPM_EMU19, OMAP_PIN_OUTPUT | OMAP_MUX_MODE5),
+ /* NIRQ2 for twl6040 */
+ OMAP4_MUX(SYS_NIRQ2, OMAP_MUX_MODE1 |
+ OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE),
{ .reg_offset = OMAP_MUX_TERMINATOR },
};
--
1.7.8.6
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
2012-07-06 8:49 ` Peter Ujfalusi
@ 2012-07-06 9:02 ` Shilimkar, Santosh
-1 siblings, 0 replies; 14+ messages in thread
From: Shilimkar, Santosh @ 2012-07-06 9:02 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: Tony Lindgren, linux-omap, linux-arm-kernel
On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> The sys_nirq2 is used for twl6040, make sure the pin is configured
> correctly.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
Should remove the boot-loader pin-muxing dependency.
Was this the reason, Audio had some issues on OMAP4430
SDP as reported by Russell ?
FWIW:
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
@ 2012-07-06 9:02 ` Shilimkar, Santosh
0 siblings, 0 replies; 14+ messages in thread
From: Shilimkar, Santosh @ 2012-07-06 9:02 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> The sys_nirq2 is used for twl6040, make sure the pin is configured
> correctly.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
Should remove the boot-loader pin-muxing dependency.
Was this the reason, Audio had some issues on OMAP4430
SDP as reported by Russell ?
FWIW:
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] ARM: OMAP: board-omap4panda: MUX configuration for sys_nirq2
2012-07-06 8:49 ` Peter Ujfalusi
@ 2012-07-06 9:03 ` Shilimkar, Santosh
-1 siblings, 0 replies; 14+ messages in thread
From: Shilimkar, Santosh @ 2012-07-06 9:03 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: Tony Lindgren, linux-omap, linux-arm-kernel
On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> The sys_nirq2 is used for twl6040, make sure the pin is configured
> correctly.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: OMAP: board-omap4panda: MUX configuration for sys_nirq2
@ 2012-07-06 9:03 ` Shilimkar, Santosh
0 siblings, 0 replies; 14+ messages in thread
From: Shilimkar, Santosh @ 2012-07-06 9:03 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> The sys_nirq2 is used for twl6040, make sure the pin is configured
> correctly.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
2012-07-06 9:02 ` Shilimkar, Santosh
@ 2012-07-06 9:22 ` Peter Ujfalusi
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Ujfalusi @ 2012-07-06 9:22 UTC (permalink / raw)
To: Shilimkar, Santosh; +Cc: Tony Lindgren, linux-omap, linux-arm-kernel
On 07/06/2012 11:02 AM, Shilimkar, Santosh wrote:
> On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>> The sys_nirq2 is used for twl6040, make sure the pin is configured
>> correctly.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
> Should remove the boot-loader pin-muxing dependency.
> Was this the reason, Audio had some issues on OMAP4430
> SDP as reported by Russell ?
The boot loader never configured the sys_nirq2, I have sent a patch for u-boot
to do this, but it is said that the kernel should take care of this.
We did not had jack detection working with upstream u-boot, kernel (I have
patched u-boot so I have not seen this issue).
Now if the board is booted without HS connected, upon connecting the HS we
will recognize it and it should be all fine.
So yes this was the reason why Russell had issues with audio.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
@ 2012-07-06 9:22 ` Peter Ujfalusi
0 siblings, 0 replies; 14+ messages in thread
From: Peter Ujfalusi @ 2012-07-06 9:22 UTC (permalink / raw)
To: linux-arm-kernel
On 07/06/2012 11:02 AM, Shilimkar, Santosh wrote:
> On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>> The sys_nirq2 is used for twl6040, make sure the pin is configured
>> correctly.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
> Should remove the boot-loader pin-muxing dependency.
> Was this the reason, Audio had some issues on OMAP4430
> SDP as reported by Russell ?
The boot loader never configured the sys_nirq2, I have sent a patch for u-boot
to do this, but it is said that the kernel should take care of this.
We did not had jack detection working with upstream u-boot, kernel (I have
patched u-boot so I have not seen this issue).
Now if the board is booted without HS connected, upon connecting the HS we
will recognize it and it should be all fine.
So yes this was the reason why Russell had issues with audio.
--
P?ter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
2012-07-06 9:22 ` Peter Ujfalusi
@ 2012-07-06 9:24 ` Shilimkar, Santosh
-1 siblings, 0 replies; 14+ messages in thread
From: Shilimkar, Santosh @ 2012-07-06 9:24 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: Tony Lindgren, linux-omap, linux-arm-kernel, Russell King - ARM Linux
+ Russell
On Fri, Jul 6, 2012 at 2:52 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> On 07/06/2012 11:02 AM, Shilimkar, Santosh wrote:
>> On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>>> The sys_nirq2 is used for twl6040, make sure the pin is configured
>>> correctly.
>>>
>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>> ---
>> Should remove the boot-loader pin-muxing dependency.
>> Was this the reason, Audio had some issues on OMAP4430
>> SDP as reported by Russell ?
>
> The boot loader never configured the sys_nirq2, I have sent a patch for u-boot
> to do this, but it is said that the kernel should take care of this.
>
> We did not had jack detection working with upstream u-boot, kernel (I have
> patched u-boot so I have not seen this issue).
> Now if the board is booted without HS connected, upon connecting the HS we
> will recognize it and it should be all fine.
> So yes this was the reason why Russell had issues with audio.
>
Thanks Peter for tracking it down.
Regards
santosh
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
@ 2012-07-06 9:24 ` Shilimkar, Santosh
0 siblings, 0 replies; 14+ messages in thread
From: Shilimkar, Santosh @ 2012-07-06 9:24 UTC (permalink / raw)
To: linux-arm-kernel
+ Russell
On Fri, Jul 6, 2012 at 2:52 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> On 07/06/2012 11:02 AM, Shilimkar, Santosh wrote:
>> On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>>> The sys_nirq2 is used for twl6040, make sure the pin is configured
>>> correctly.
>>>
>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>> ---
>> Should remove the boot-loader pin-muxing dependency.
>> Was this the reason, Audio had some issues on OMAP4430
>> SDP as reported by Russell ?
>
> The boot loader never configured the sys_nirq2, I have sent a patch for u-boot
> to do this, but it is said that the kernel should take care of this.
>
> We did not had jack detection working with upstream u-boot, kernel (I have
> patched u-boot so I have not seen this issue).
> Now if the board is booted without HS connected, upon connecting the HS we
> will recognize it and it should be all fine.
> So yes this was the reason why Russell had issues with audio.
>
Thanks Peter for tracking it down.
Regards
santosh
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
2012-07-06 8:49 ` Peter Ujfalusi
@ 2012-07-06 12:59 ` Peter Ujfalusi
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Ujfalusi @ 2012-07-06 12:59 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, linux-arm-kernel
Hi,
On 07/06/2012 10:49 AM, Peter Ujfalusi wrote:
> The sys_nirq2 is used for twl6040, make sure the pin is configured
> correctly.
Please ignore this two patch, I'll resend them with the correct MUX config.
By mistake I have set MUX_MODE1, while it must be set MUX_MODE0.
It was working with MUX_MODE1, but it is not aligned with the TRM...
Sorry,
Péter
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/board-4430sdp.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index c4e17641..050cc8e 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -827,6 +827,9 @@ static void __init omap_4430sdp_display_init(void)
> #ifdef CONFIG_OMAP_MUX
> static struct omap_board_mux board_mux[] __initdata = {
> OMAP4_MUX(USBB2_ULPITLL_CLK, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
> + /* NIRQ2 for twl6040 */
> + OMAP4_MUX(SYS_NIRQ2, OMAP_MUX_MODE1 |
> + OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE),
> { .reg_offset = OMAP_MUX_TERMINATOR },
> };
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2
@ 2012-07-06 12:59 ` Peter Ujfalusi
0 siblings, 0 replies; 14+ messages in thread
From: Peter Ujfalusi @ 2012-07-06 12:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 07/06/2012 10:49 AM, Peter Ujfalusi wrote:
> The sys_nirq2 is used for twl6040, make sure the pin is configured
> correctly.
Please ignore this two patch, I'll resend them with the correct MUX config.
By mistake I have set MUX_MODE1, while it must be set MUX_MODE0.
It was working with MUX_MODE1, but it is not aligned with the TRM...
Sorry,
P?ter
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/board-4430sdp.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index c4e17641..050cc8e 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -827,6 +827,9 @@ static void __init omap_4430sdp_display_init(void)
> #ifdef CONFIG_OMAP_MUX
> static struct omap_board_mux board_mux[] __initdata = {
> OMAP4_MUX(USBB2_ULPITLL_CLK, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
> + /* NIRQ2 for twl6040 */
> + OMAP4_MUX(SYS_NIRQ2, OMAP_MUX_MODE1 |
> + OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE),
> { .reg_offset = OMAP_MUX_TERMINATOR },
> };
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-07-06 12:59 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-06 8:49 [PATCH 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2 Peter Ujfalusi
2012-07-06 8:49 ` Peter Ujfalusi
2012-07-06 8:49 ` [PATCH 2/2] ARM: OMAP: board-omap4panda: " Peter Ujfalusi
2012-07-06 8:49 ` Peter Ujfalusi
2012-07-06 9:03 ` Shilimkar, Santosh
2012-07-06 9:03 ` Shilimkar, Santosh
2012-07-06 9:02 ` [PATCH 1/2] ARM: OMAP: board-4430sdp: " Shilimkar, Santosh
2012-07-06 9:02 ` Shilimkar, Santosh
2012-07-06 9:22 ` Peter Ujfalusi
2012-07-06 9:22 ` Peter Ujfalusi
2012-07-06 9:24 ` Shilimkar, Santosh
2012-07-06 9:24 ` Shilimkar, Santosh
2012-07-06 12:59 ` Peter Ujfalusi
2012-07-06 12:59 ` Peter Ujfalusi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.