From: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nicolas Pitre <nico@fluxnic.net>
Subject: Re: Please help with the OMAP static mapping mess
Date: Tue, 4 Oct 2011 11:48:40 +0530 [thread overview]
Message-ID: <CAMQu2gxgRZzb6hh5pOVBgaPUZEizEqBr_e358MBuD_xHJOvX3Q@mail.gmail.com> (raw)
In-Reply-To: <20111003225908.GL6324@atomide.com>
On Tue, Oct 4, 2011 at 4:29 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Nicolas Pitre <nico@fluxnic.net> [111003 15:05]:
>> On Mon, 3 Oct 2011, Nicolas Pitre wrote:
>>
>> > On Mon, 3 Oct 2011, Tony Lindgren wrote:
>> >
>> > > * Nicolas Pitre <nico@fluxnic.net> [111003 11:26]:
>> > > >
>> > > > Furthermore... there is also a static mapping for physical address
>> > > > 0x4e000000 using virtual address 0xff100000 which is already reserved
>> > > > for other purposes i.e. the consistent DMA area. It is not immediately
>> > > > obvious where this comes from without being intimate with the OMAP code.
>> > > > Can this be fixed as well i.e. moved elsewhere please?
>> > >
>> > > This sounds like a bug somewhere. Which omap are you seeing this on?
>> >
>> > OMAP4430 on a Panda board.
>> >
>> > Here are the static mappings I'm seeing:
>> >
>> > phys = 0x44000000 virt = 0xf8000000 size = 0x100000
>> > phys = 0x4a000000 virt = 0xfc000000 size = 0x400000
>> > phys = 0x50000000 virt = 0xf9000000 size = 0x100000
>> > phys = 0x4c000000 virt = 0xfd100000 size = 0x100000
>> > phys = 0x4d000000 virt = 0xfe100000 size = 0x100000
>> > phys = 0x4e000000 virt = 0xff100000 size = 0x100000 <---
>> > phys = 0x48000000 virt = 0xfa000000 size = 0x400000
>> > phys = 0x54000000 virt = 0xfe800000 size = 0x800000
>>
>> It looks like this comes from OMAP44XX_DMM_VIRT.
>>
>> #define OMAP44XX_DMM_PHYS OMAP44XX_DMM_BASE
>> /* 0x4e000000 --> 0xfd300000 */
>> #define OMAP44XX_DMM_VIRT (OMAP44XX_DMM_PHYS + OMAP4_L3_PER_IO_OFFSET)
>> #define OMAP44XX_DMM_SIZE SZ_1M
>>
>> The comment suggesting a mapping correspondance is obviously wrong. We have:
>>
>> #define OMAP44XX_DMM_BASE 0x4e000000
>> #define OMAP4_L3_PER_IO_OFFSET 0xb1100000
>>
>> Hence 0x4e000000 + 0xb1100000 = 0xff100000.
>
> Seem like it might cause some random patterns in tiler :)
> Santosh, can youp please check it?
>
This is already fixed Tony. You have pulled that patch.
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg55258.html
Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Shilimkar, Santosh)
To: linux-arm-kernel@lists.infradead.org
Subject: Please help with the OMAP static mapping mess
Date: Tue, 4 Oct 2011 11:48:40 +0530 [thread overview]
Message-ID: <CAMQu2gxgRZzb6hh5pOVBgaPUZEizEqBr_e358MBuD_xHJOvX3Q@mail.gmail.com> (raw)
In-Reply-To: <20111003225908.GL6324@atomide.com>
On Tue, Oct 4, 2011 at 4:29 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Nicolas Pitre <nico@fluxnic.net> [111003 15:05]:
>> On Mon, 3 Oct 2011, Nicolas Pitre wrote:
>>
>> > On Mon, 3 Oct 2011, Tony Lindgren wrote:
>> >
>> > > * Nicolas Pitre <nico@fluxnic.net> [111003 11:26]:
>> > > >
>> > > > Furthermore... there is also a static mapping for physical address
>> > > > 0x4e000000 using virtual address 0xff100000 which is already reserved
>> > > > for other purposes i.e. the consistent DMA area. ?It is not immediately
>> > > > obvious where this comes from without being intimate with the OMAP code.
>> > > > Can this be fixed as well i.e. moved elsewhere please?
>> > >
>> > > This sounds like a bug somewhere. Which omap are you seeing this on?
>> >
>> > OMAP4430 on a Panda board.
>> >
>> > Here are the static mappings I'm seeing:
>> >
>> > phys = 0x44000000 virt = 0xf8000000 size = 0x100000
>> > phys = 0x4a000000 virt = 0xfc000000 size = 0x400000
>> > phys = 0x50000000 virt = 0xf9000000 size = 0x100000
>> > phys = 0x4c000000 virt = 0xfd100000 size = 0x100000
>> > phys = 0x4d000000 virt = 0xfe100000 size = 0x100000
>> > phys = 0x4e000000 virt = 0xff100000 size = 0x100000 <---
>> > phys = 0x48000000 virt = 0xfa000000 size = 0x400000
>> > phys = 0x54000000 virt = 0xfe800000 size = 0x800000
>>
>> It looks like this comes from OMAP44XX_DMM_VIRT.
>>
>> #define OMAP44XX_DMM_PHYS ? ? ? OMAP44XX_DMM_BASE
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? /* 0x4e000000 --> 0xfd300000 */
>> #define OMAP44XX_DMM_VIRT ? ? ? (OMAP44XX_DMM_PHYS + OMAP4_L3_PER_IO_OFFSET)
>> #define OMAP44XX_DMM_SIZE ? ? ? SZ_1M
>>
>> The comment suggesting a mapping correspondance is obviously wrong. We have:
>>
>> #define OMAP44XX_DMM_BASE ? ? ? 0x4e000000
>> #define OMAP4_L3_PER_IO_OFFSET ?0xb1100000
>>
>> Hence 0x4e000000 + 0xb1100000 = 0xff100000.
>
> Seem like it might cause some random patterns in tiler :)
> Santosh, can youp please check it?
>
This is already fixed Tony. You have pulled that patch.
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg55258.html
Regards
Santosh
next prev parent reply other threads:[~2011-10-04 6:19 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 18:59 Please help with the OMAP static mapping mess Nicolas Pitre
2011-10-03 18:59 ` Nicolas Pitre
2011-10-03 20:56 ` Tony Lindgren
2011-10-03 20:56 ` Tony Lindgren
2011-10-03 22:09 ` Nicolas Pitre
2011-10-03 22:09 ` Nicolas Pitre
2011-10-03 22:38 ` Tony Lindgren
2011-10-03 22:38 ` Tony Lindgren
2011-10-04 7:04 ` Santosh Shilimkar
2011-10-04 7:04 ` Santosh Shilimkar
2011-10-04 21:21 ` Nicolas Pitre
2011-10-04 21:21 ` Nicolas Pitre
2011-10-05 2:09 ` Rob Herring
2011-10-05 2:09 ` Rob Herring
2011-10-05 2:39 ` Nicolas Pitre
2011-10-05 2:39 ` Nicolas Pitre
2011-10-05 6:16 ` Santosh Shilimkar
2011-10-05 6:16 ` Santosh Shilimkar
2011-10-03 22:39 ` Nicolas Pitre
2011-10-03 22:39 ` Nicolas Pitre
2011-10-03 22:59 ` Tony Lindgren
2011-10-03 22:59 ` Tony Lindgren
2011-10-04 6:18 ` Shilimkar, Santosh [this message]
2011-10-04 6:18 ` Shilimkar, Santosh
2011-10-04 17:50 ` Tony Lindgren
2011-10-04 17:50 ` Tony Lindgren
2011-10-03 22:44 ` Russell King - ARM Linux
2011-10-03 22:44 ` Russell King - ARM Linux
2011-10-04 21:10 ` Nicolas Pitre
2011-10-04 21:10 ` Nicolas Pitre
2011-10-04 22:54 ` Russell King - ARM Linux
2011-10-04 22:54 ` Russell King - ARM Linux
2011-10-04 23:20 ` Nicolas Pitre
2011-10-04 23:20 ` Nicolas Pitre
2011-10-05 0:42 ` Tony Lindgren
2011-10-05 0:42 ` Tony Lindgren
2011-10-05 0:57 ` Nicolas Pitre
2011-10-05 0:57 ` Nicolas Pitre
2011-10-05 1:35 ` Tony Lindgren
2011-10-05 1:35 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMQu2gxgRZzb6hh5pOVBgaPUZEizEqBr_e358MBuD_xHJOvX3Q@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.