All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Sekhar Nori <nsekhar@ti.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] gpio: pcf857x: Make teardown callback return void
Date: Mon, 25 Apr 2022 20:56:17 +0200	[thread overview]
Message-ID: <CAMRc=McBT0R9C4Ke4DBTeUDjFgbkMWm=q_o7diJunjCGe7xHJQ@mail.gmail.com> (raw)
In-Reply-To: <20220425173255.56216-1-u.kleine-koenig@pengutronix.de>

On Mon, Apr 25, 2022 at 7:33 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> All teardown functions return 0. Also there is little sense in returning
> a negative error code from an i2c remove function as this only results in
> emitting an error message but the device is removed nevertheless.
>
> This patch is a preparation for making i2c remove callbacks return void.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Changes since (implicit) v1:
>
>  - make it actually compile, thanks to the kernel test robot for
>    pointing that out.
>

Thanks, applied.

Bart

WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Sekhar Nori <nsekhar@ti.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] gpio: pcf857x: Make teardown callback return void
Date: Mon, 25 Apr 2022 20:56:17 +0200	[thread overview]
Message-ID: <CAMRc=McBT0R9C4Ke4DBTeUDjFgbkMWm=q_o7diJunjCGe7xHJQ@mail.gmail.com> (raw)
In-Reply-To: <20220425173255.56216-1-u.kleine-koenig@pengutronix.de>

On Mon, Apr 25, 2022 at 7:33 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> All teardown functions return 0. Also there is little sense in returning
> a negative error code from an i2c remove function as this only results in
> emitting an error message but the device is removed nevertheless.
>
> This patch is a preparation for making i2c remove callbacks return void.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Changes since (implicit) v1:
>
>  - make it actually compile, thanks to the kernel test robot for
>    pointing that out.
>

Thanks, applied.

Bart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-25 18:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 17:32 [PATCH v2] gpio: pcf857x: Make teardown callback return void Uwe Kleine-König
2022-04-25 17:32 ` Uwe Kleine-König
2022-04-25 18:56 ` Bartosz Golaszewski [this message]
2022-04-25 18:56   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=McBT0R9C4Ke4DBTeUDjFgbkMWm=q_o7diJunjCGe7xHJQ@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.