From: Bartosz Golaszewski <brgl@bgdev.pl> To: Sekhar Nori <nsekhar@ti.com> Cc: Kevin Hilman <khilman@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, David Lechner <david@lechnology.com>, Adam Ford <aford173@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: Re: [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT Date: Fri, 12 Apr 2019 14:11:21 +0200 [thread overview] Message-ID: <CAMRc=McGwGh9RKhxxCDnz3aMG_EVjjXzN+pmMZVtE7aChdU3jw@mail.gmail.com> (raw) In-Reply-To: <5f72a26b-428a-c50e-cb6a-7c888ea22329@ti.com> pt., 12 kwi 2019 o 13:26 Sekhar Nori <nsekhar@ti.com> napisał(a): > > Hi Bartosz, > > On 08/04/19 1:29 PM, Bartosz Golaszewski wrote: > > From: David Lechner <david@lechnology.com> > > > > This adds a cpu node and operating points to the common da850.dtsi file. > > > > Additionally, a regulator is added to the LEGO EV3 board along with > > some board-specific CPU configuration. > > > > Regulators need to be hooked up on other boards to get them working. > > > > Signed-off-by: David Lechner <david@lechnology.com> > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I remember you mentioning about some problems using OCHI and cpufreq > together. Are those resolved now? CPU PLL on DA850 can affect other > peripheral clock frequencies too. So enabling it should really be a > per-board decision. > The problems are still there. I've never been able to find the culprit, but it also occurs on TI BSP in the same way (a couple cpufreq transitions will make the controller unresponsive). > No problems with adding OPPs to da850.dtsi, but which of those are > enabled on any board should be after some thorough testing and analysis. > > Because of that, I think its also better to split da850.dtsi from board > specific changes in this patch. > Sure, I'll split it. > > + opp_table: opp-table { > > + compatible = "operating-points-v2"; > > + > > + opp_100: opp100-100000000 { > > + opp-hz = /bits/ 64 <100000000>; > > + opp-microvolt = <1000000 950000 1050000>; > > + }; > > + > > + opp_200: opp110-200000000 { > > + opp-hz = /bits/ 64 <200000000>; > > + opp-microvolt = <1100000 1050000 1160000>; > > + }; > > + > > + opp_300: opp120-300000000 { > > + opp-hz = /bits/ 64 <300000000>; > > + opp-microvolt = <1200000 1140000 1320000>; > > + }; > > + > > + /* > > + * Original silicon was 300MHz max, so higher frequencies > > + * need to be enabled on a per-board basis if the chip is > > + * capable. > > + */ > > + > > + opp_375: opp120-375000000 { > > + status = "disabled"; > > + opp-hz = /bits/ 64 <375000000>; > > + opp-microvolt = <1200000 1140000 1320000>; > > + }; > > + > > + opp_415: opp130-415000000 { > > + status = "disabled"; > > + opp-hz = /bits/ 64 <415000000>; > > + opp-microvolt = <1300000 1250000 1350000>; > > + }; > > + > > + opp_456: opp130-456000000 { > > + status = "disabled"; > > + opp-hz = /bits/ 64 <456000000>; > > + opp-microvolt = <1300000 1250000 1350000>; > > + }; > > Here, lets stick to OPPs defined in OMAP-L138 data manual (irrespective > of what existing board code has). Page 93 of > http://www.ti.com/lit/ds/symlink/omap-l138.pdf > Will do in the next version. Bart > Thanks, > Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl> To: Sekhar Nori <nsekhar@ti.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, David Lechner <david@lechnology.com>, Kevin Hilman <khilman@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Rob Herring <robh+dt@kernel.org>, Adam Ford <aford173@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT Date: Fri, 12 Apr 2019 14:11:21 +0200 [thread overview] Message-ID: <CAMRc=McGwGh9RKhxxCDnz3aMG_EVjjXzN+pmMZVtE7aChdU3jw@mail.gmail.com> (raw) In-Reply-To: <5f72a26b-428a-c50e-cb6a-7c888ea22329@ti.com> pt., 12 kwi 2019 o 13:26 Sekhar Nori <nsekhar@ti.com> napisał(a): > > Hi Bartosz, > > On 08/04/19 1:29 PM, Bartosz Golaszewski wrote: > > From: David Lechner <david@lechnology.com> > > > > This adds a cpu node and operating points to the common da850.dtsi file. > > > > Additionally, a regulator is added to the LEGO EV3 board along with > > some board-specific CPU configuration. > > > > Regulators need to be hooked up on other boards to get them working. > > > > Signed-off-by: David Lechner <david@lechnology.com> > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I remember you mentioning about some problems using OCHI and cpufreq > together. Are those resolved now? CPU PLL on DA850 can affect other > peripheral clock frequencies too. So enabling it should really be a > per-board decision. > The problems are still there. I've never been able to find the culprit, but it also occurs on TI BSP in the same way (a couple cpufreq transitions will make the controller unresponsive). > No problems with adding OPPs to da850.dtsi, but which of those are > enabled on any board should be after some thorough testing and analysis. > > Because of that, I think its also better to split da850.dtsi from board > specific changes in this patch. > Sure, I'll split it. > > + opp_table: opp-table { > > + compatible = "operating-points-v2"; > > + > > + opp_100: opp100-100000000 { > > + opp-hz = /bits/ 64 <100000000>; > > + opp-microvolt = <1000000 950000 1050000>; > > + }; > > + > > + opp_200: opp110-200000000 { > > + opp-hz = /bits/ 64 <200000000>; > > + opp-microvolt = <1100000 1050000 1160000>; > > + }; > > + > > + opp_300: opp120-300000000 { > > + opp-hz = /bits/ 64 <300000000>; > > + opp-microvolt = <1200000 1140000 1320000>; > > + }; > > + > > + /* > > + * Original silicon was 300MHz max, so higher frequencies > > + * need to be enabled on a per-board basis if the chip is > > + * capable. > > + */ > > + > > + opp_375: opp120-375000000 { > > + status = "disabled"; > > + opp-hz = /bits/ 64 <375000000>; > > + opp-microvolt = <1200000 1140000 1320000>; > > + }; > > + > > + opp_415: opp130-415000000 { > > + status = "disabled"; > > + opp-hz = /bits/ 64 <415000000>; > > + opp-microvolt = <1300000 1250000 1350000>; > > + }; > > + > > + opp_456: opp130-456000000 { > > + status = "disabled"; > > + opp-hz = /bits/ 64 <456000000>; > > + opp-microvolt = <1300000 1250000 1350000>; > > + }; > > Here, lets stick to OPPs defined in OMAP-L138 data manual (irrespective > of what existing board code has). Page 93 of > http://www.ti.com/lit/ds/symlink/omap-l138.pdf > Will do in the next version. Bart > Thanks, > Sekhar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-12 12:11 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-08 7:59 [PATCH v3 0/3] ARM: da850: enable cpufreq in DT mode Bartosz Golaszewski 2019-04-08 7:59 ` Bartosz Golaszewski 2019-04-08 7:59 ` [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT Bartosz Golaszewski 2019-04-08 7:59 ` Bartosz Golaszewski 2019-04-08 13:47 ` David Lechner 2019-04-08 13:47 ` David Lechner 2019-04-08 13:51 ` Bartosz Golaszewski 2019-04-08 13:51 ` Bartosz Golaszewski 2019-04-08 13:55 ` David Lechner 2019-04-08 13:55 ` David Lechner 2019-04-12 11:26 ` Sekhar Nori 2019-04-12 11:26 ` Sekhar Nori 2019-04-12 11:26 ` Sekhar Nori 2019-04-12 12:11 ` Bartosz Golaszewski [this message] 2019-04-12 12:11 ` Bartosz Golaszewski 2019-04-12 13:53 ` Sekhar Nori 2019-04-12 13:53 ` Sekhar Nori 2019-04-12 15:31 ` Bartosz Golaszewski 2019-04-12 15:31 ` Bartosz Golaszewski 2019-04-15 10:21 ` Sekhar Nori 2019-04-15 10:21 ` Sekhar Nori 2019-04-15 11:54 ` Bartosz Golaszewski 2019-04-15 11:54 ` Bartosz Golaszewski 2019-04-15 13:02 ` Adam Ford 2019-04-15 13:02 ` Adam Ford 2019-04-16 8:37 ` Bartosz Golaszewski 2019-04-16 8:37 ` Bartosz Golaszewski 2019-04-16 11:48 ` Adam Ford 2019-04-16 11:48 ` Adam Ford 2019-04-17 8:15 ` Sekhar Nori 2019-04-17 8:15 ` Sekhar Nori 2019-04-16 14:38 ` David Lechner 2019-04-16 14:38 ` David Lechner 2019-04-17 8:24 ` Sekhar Nori 2019-04-17 8:24 ` Sekhar Nori 2019-04-08 7:59 ` [PATCH v3 2/3] ARM: dts: da850-evm: enable cpufreq Bartosz Golaszewski 2019-04-08 7:59 ` Bartosz Golaszewski 2019-04-12 13:06 ` Sekhar Nori 2019-04-12 13:06 ` Sekhar Nori 2019-04-12 13:06 ` Sekhar Nori 2019-04-12 13:09 ` Bartosz Golaszewski 2019-04-12 13:09 ` Bartosz Golaszewski 2019-04-12 13:59 ` Adam Ford 2019-04-12 13:59 ` Adam Ford 2019-04-12 14:23 ` Bartosz Golaszewski 2019-04-12 14:23 ` Bartosz Golaszewski 2019-04-08 7:59 ` [PATCH v3 3/3] ARM: davinci_all_defconfig: Enable CPUFREQ_DT Bartosz Golaszewski 2019-04-08 7:59 ` Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMRc=McGwGh9RKhxxCDnz3aMG_EVjjXzN+pmMZVtE7aChdU3jw@mail.gmail.com' \ --to=brgl@bgdev.pl \ --cc=aford173@gmail.com \ --cc=bgolaszewski@baylibre.com \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nsekhar@ti.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.