* [PATCH v2 0/2] gpio: renesas: Use proper irq_chip name
@ 2019-10-24 12:22 Geert Uytterhoeven
2019-10-24 12:22 ` [PATCH v2 1/2] gpio: em: " Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2019-10-24 12:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Marc Zyngier, linux-gpio, linux-renesas-soc, Geert Uytterhoeven
Hi Linus, Bartosz,
Recently, Marc pointed out some common misconceptions w.r.t. the .name
and .parent_device fields in struct irq_chip. This patch series fixes
the names in the Renesas GPIO controller drivers.
Changes compared to v1[*]:
- Drop irqchip patches applied to the irqchip tree.
Thanks for applying!
[*] https://lore.kernel.org/linux-renesas-soc/20190607095858.10028-1-geert+renesas@glider.be/
Geert Uytterhoeven (2):
gpio: em: Use proper irq_chip name
gpio: rcar: Use proper irq_chip name
drivers/gpio/gpio-em.c | 2 +-
drivers/gpio/gpio-rcar.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 1/2] gpio: em: Use proper irq_chip name
2019-10-24 12:22 [PATCH v2 0/2] gpio: renesas: Use proper irq_chip name Geert Uytterhoeven
@ 2019-10-24 12:22 ` Geert Uytterhoeven
2019-11-04 15:10 ` Linus Walleij
2019-10-24 12:22 ` [PATCH v2 2/2] gpio: rcar: " Geert Uytterhoeven
2019-10-26 12:08 ` [PATCH v2 0/2] gpio: renesas: " Bartosz Golaszewski
2 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2019-10-24 12:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Marc Zyngier, linux-gpio, linux-renesas-soc, Geert Uytterhoeven
The irq_chip .name field should contain the device's class name, not the
instance's name.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested due to lack of hardware.
.parent_device not filled in as this driver doesn't use Runtime PM.
v2:
- No changes.
---
drivers/gpio/gpio-em.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index 620f25b7efb402c1..cc4416310dc9a6fe 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -326,7 +326,7 @@ static int em_gio_probe(struct platform_device *pdev)
gpio_chip->ngpio = ngpios;
irq_chip = &p->irq_chip;
- irq_chip->name = name;
+ irq_chip->name = "gpio-em";
irq_chip->irq_mask = em_gio_irq_disable;
irq_chip->irq_unmask = em_gio_irq_enable;
irq_chip->irq_set_type = em_gio_irq_set_type;
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] gpio: em: Use proper irq_chip name
2019-10-24 12:22 ` [PATCH v2 1/2] gpio: em: " Geert Uytterhoeven
@ 2019-11-04 15:10 ` Linus Walleij
2019-11-04 15:21 ` Bartosz Golaszewski
0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2019-11-04 15:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bartosz Golaszewski, Marc Zyngier, open list:GPIO SUBSYSTEM,
Linux-Renesas
On Thu, Oct 24, 2019 at 2:22 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> The irq_chip .name field should contain the device's class name, not the
> instance's name.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Untested due to lack of hardware.
> .parent_device not filled in as this driver doesn't use Runtime PM.
>
> v2:
> - No changes.
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] gpio: em: Use proper irq_chip name
2019-11-04 15:10 ` Linus Walleij
@ 2019-11-04 15:21 ` Bartosz Golaszewski
2019-11-05 14:35 ` Linus Walleij
0 siblings, 1 reply; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-11-04 15:21 UTC (permalink / raw)
To: Linus Walleij
Cc: Geert Uytterhoeven, Marc Zyngier, open list:GPIO SUBSYSTEM,
Linux-Renesas
pon., 4 lis 2019 o 16:10 Linus Walleij <linus.walleij@linaro.org> napisał(a):
>
> On Thu, Oct 24, 2019 at 2:22 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>
> > The irq_chip .name field should contain the device's class name, not the
> > instance's name.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Untested due to lack of hardware.
> > .parent_device not filled in as this driver doesn't use Runtime PM.
> >
> > v2:
> > - No changes.
>
> Patch applied.
>
Oops I already have those in my tree. I'll back them out before the next PR.
Bart
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] gpio: em: Use proper irq_chip name
2019-11-04 15:21 ` Bartosz Golaszewski
@ 2019-11-05 14:35 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2019-11-05 14:35 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Geert Uytterhoeven, Marc Zyngier, open list:GPIO SUBSYSTEM,
Linux-Renesas
On Mon, Nov 4, 2019 at 4:21 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> pon., 4 lis 2019 o 16:10 Linus Walleij <linus.walleij@linaro.org> napisał(a):
> >
> > On Thu, Oct 24, 2019 at 2:22 PM Geert Uytterhoeven
> > <geert+renesas@glider.be> wrote:
> >
> > > The irq_chip .name field should contain the device's class name, not the
> > > instance's name.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > Untested due to lack of hardware.
> > > .parent_device not filled in as this driver doesn't use Runtime PM.
> > >
> > > v2:
> > > - No changes.
> >
> > Patch applied.
> >
>
> Oops I already have those in my tree. I'll back them out before the next PR.
I noticed they were in your tree later, so I backed them out of mine,
just keep your commit history.
Linus
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] gpio: rcar: Use proper irq_chip name
2019-10-24 12:22 [PATCH v2 0/2] gpio: renesas: Use proper irq_chip name Geert Uytterhoeven
2019-10-24 12:22 ` [PATCH v2 1/2] gpio: em: " Geert Uytterhoeven
@ 2019-10-24 12:22 ` Geert Uytterhoeven
2019-11-04 15:11 ` Linus Walleij
2019-10-26 12:08 ` [PATCH v2 0/2] gpio: renesas: " Bartosz Golaszewski
2 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2019-10-24 12:22 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Marc Zyngier, linux-gpio, linux-renesas-soc, Geert Uytterhoeven
The irq_chip .name field should contain the device's class name, not the
instance's name.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- No changes.
---
drivers/gpio/gpio-rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 187984d26f47a940..cea6124317857bf4 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -483,7 +483,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
gpio_chip->ngpio = npins;
irq_chip = &p->irq_chip;
- irq_chip->name = name;
+ irq_chip->name = "gpio-rcar";
irq_chip->parent_device = dev;
irq_chip->irq_mask = gpio_rcar_irq_disable;
irq_chip->irq_unmask = gpio_rcar_irq_enable;
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] gpio: rcar: Use proper irq_chip name
2019-10-24 12:22 ` [PATCH v2 2/2] gpio: rcar: " Geert Uytterhoeven
@ 2019-11-04 15:11 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2019-11-04 15:11 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bartosz Golaszewski, Marc Zyngier, open list:GPIO SUBSYSTEM,
Linux-Renesas
On Thu, Oct 24, 2019 at 2:22 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> The irq_chip .name field should contain the device's class name, not the
> instance's name.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] gpio: renesas: Use proper irq_chip name
2019-10-24 12:22 [PATCH v2 0/2] gpio: renesas: Use proper irq_chip name Geert Uytterhoeven
2019-10-24 12:22 ` [PATCH v2 1/2] gpio: em: " Geert Uytterhoeven
2019-10-24 12:22 ` [PATCH v2 2/2] gpio: rcar: " Geert Uytterhoeven
@ 2019-10-26 12:08 ` Bartosz Golaszewski
2019-11-04 15:36 ` Linus Walleij
2 siblings, 1 reply; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-10-26 12:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Bartosz Golaszewski, Marc Zyngier,
open list:GPIO SUBSYSTEM, Linux-Renesas
czw., 24 paź 2019 o 14:22 Geert Uytterhoeven <geert+renesas@glider.be>
napisał(a):
>
> Hi Linus, Bartosz,
>
> Recently, Marc pointed out some common misconceptions w.r.t. the .name
> and .parent_device fields in struct irq_chip. This patch series fixes
> the names in the Renesas GPIO controller drivers.
>
> Changes compared to v1[*]:
> - Drop irqchip patches applied to the irqchip tree.
>
> Thanks for applying!
>
> [*] https://lore.kernel.org/linux-renesas-soc/20190607095858.10028-1-geert+renesas@glider.be/
>
> Geert Uytterhoeven (2):
> gpio: em: Use proper irq_chip name
> gpio: rcar: Use proper irq_chip name
>
> drivers/gpio/gpio-em.c | 2 +-
> drivers/gpio/gpio-rcar.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.17.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Both applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 0/2] gpio: renesas: Use proper irq_chip name
2019-10-26 12:08 ` [PATCH v2 0/2] gpio: renesas: " Bartosz Golaszewski
@ 2019-11-04 15:36 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2019-11-04 15:36 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Geert Uytterhoeven, Bartosz Golaszewski, Marc Zyngier,
open list:GPIO SUBSYSTEM, Linux-Renesas
On Sat, Oct 26, 2019 at 2:08 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> Both applied, thanks!
Ooops missed this, I pull them out of my tree.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-11-05 14:35 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 12:22 [PATCH v2 0/2] gpio: renesas: Use proper irq_chip name Geert Uytterhoeven
2019-10-24 12:22 ` [PATCH v2 1/2] gpio: em: " Geert Uytterhoeven
2019-11-04 15:10 ` Linus Walleij
2019-11-04 15:21 ` Bartosz Golaszewski
2019-11-05 14:35 ` Linus Walleij
2019-10-24 12:22 ` [PATCH v2 2/2] gpio: rcar: " Geert Uytterhoeven
2019-11-04 15:11 ` Linus Walleij
2019-10-26 12:08 ` [PATCH v2 0/2] gpio: renesas: " Bartosz Golaszewski
2019-11-04 15:36 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.