All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH libgpiod 0/2] configure: Minor cleanups
@ 2021-08-13  1:44 Andrew Jeffery
  2021-08-13  1:44 ` [PATCH libgpiod 1/2] configure: Fix 'flase' typo in bats dependency test Andrew Jeffery
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Andrew Jeffery @ 2021-08-13  1:44 UTC (permalink / raw)
  To: bartekgola, linux-gpio

Hello,

Here are a couple of minor fixes for the bats test in configure.ac.

Cheers,

Andrew

Andrew Jeffery (2):
  configure: Fix 'flase' typo in bats dependency test
  configure: Drop unnecessary double-quote character

 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH libgpiod 1/2] configure: Fix 'flase' typo in bats dependency test
  2021-08-13  1:44 [PATCH libgpiod 0/2] configure: Minor cleanups Andrew Jeffery
@ 2021-08-13  1:44 ` Andrew Jeffery
  2021-08-13  1:44 ` [PATCH libgpiod 2/2] configure: Drop unnecessary double-quote character Andrew Jeffery
  2021-08-13  8:01 ` [PATCH libgpiod 0/2] configure: Minor cleanups Bartosz Golaszewski
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Jeffery @ 2021-08-13  1:44 UTC (permalink / raw)
  To: bartekgola, linux-gpio

Hopefully this helps identify the failure early in confiure rather than
late when the tests should be executed.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index e0a917f54cf2..351d5479a319 100644
--- a/configure.ac
+++ b/configure.ac
@@ -137,7 +137,7 @@ then
 	if test "x$with_tools" = xtrue
 	then
 		AC_CHECK_PROG([has_bats], [bats], [true], [false])
-		if test "x$has_bats" = "xflase"
+		if test "x$has_bats" = "xfalse"
 		then
 			AC_MSG_NOTICE(["bats not found - gpio-tools tests cannot be run])
 		fi
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH libgpiod 2/2] configure: Drop unnecessary double-quote character
  2021-08-13  1:44 [PATCH libgpiod 0/2] configure: Minor cleanups Andrew Jeffery
  2021-08-13  1:44 ` [PATCH libgpiod 1/2] configure: Fix 'flase' typo in bats dependency test Andrew Jeffery
@ 2021-08-13  1:44 ` Andrew Jeffery
  2021-08-13  8:01 ` [PATCH libgpiod 0/2] configure: Minor cleanups Bartosz Golaszewski
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Jeffery @ 2021-08-13  1:44 UTC (permalink / raw)
  To: bartekgola, linux-gpio

The double-quote was also missing its matching pair.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 351d5479a319..ce6de99c1edd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -139,7 +139,7 @@ then
 		AC_CHECK_PROG([has_bats], [bats], [true], [false])
 		if test "x$has_bats" = "xfalse"
 		then
-			AC_MSG_NOTICE(["bats not found - gpio-tools tests cannot be run])
+			AC_MSG_NOTICE([bats not found - gpio-tools tests cannot be run])
 		fi
 	fi
 fi
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH libgpiod 0/2] configure: Minor cleanups
  2021-08-13  1:44 [PATCH libgpiod 0/2] configure: Minor cleanups Andrew Jeffery
  2021-08-13  1:44 ` [PATCH libgpiod 1/2] configure: Fix 'flase' typo in bats dependency test Andrew Jeffery
  2021-08-13  1:44 ` [PATCH libgpiod 2/2] configure: Drop unnecessary double-quote character Andrew Jeffery
@ 2021-08-13  8:01 ` Bartosz Golaszewski
  2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2021-08-13  8:01 UTC (permalink / raw)
  To: Andrew Jeffery; +Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM

On Fri, Aug 13, 2021 at 3:44 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> Hello,
>
> Here are a couple of minor fixes for the bats test in configure.ac.
>
> Cheers,
>
> Andrew
>
> Andrew Jeffery (2):
>   configure: Fix 'flase' typo in bats dependency test
>   configure: Drop unnecessary double-quote character
>
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.30.2
>

Both applied, thanks!

Bart

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-13  8:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13  1:44 [PATCH libgpiod 0/2] configure: Minor cleanups Andrew Jeffery
2021-08-13  1:44 ` [PATCH libgpiod 1/2] configure: Fix 'flase' typo in bats dependency test Andrew Jeffery
2021-08-13  1:44 ` [PATCH libgpiod 2/2] configure: Drop unnecessary double-quote character Andrew Jeffery
2021-08-13  8:01 ` [PATCH libgpiod 0/2] configure: Minor cleanups Bartosz Golaszewski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.