* [PATCH v6 0/3] gpio: pca9570: add slg7xl45106 support
@ 2022-10-26 15:15 Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 1/3] dt-bindings: gpio: pca9570: Add compatible for slg7xl45106 Shubhrajyoti Datta
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Shubhrajyoti Datta @ 2022-10-26 15:15 UTC (permalink / raw)
To: linux-gpio
Cc: git, devicetree, linus.walleij, brgl, robh+dt,
krzysztof.kozlowski+dt, geert
Add Dialog semiconductors SLG7XL45106 GPO expander
Changes in v6:
Fix the bisectablity reported by Geert Uytterhoeven
v4 and v5:
Resend as the patches were mangled.
Changes in v3:
Add ack
split the new patch
Suggested by Andy Shevchenko
Changes in v2:
add alphabetically
Shubhrajyoti Datta (3):
dt-bindings: gpio: pca9570: Add compatible for slg7xl45106
gpio: pca9570: add a platform data structure
gpio: pca9570: add slg7xl45106 support
.../bindings/gpio/gpio-pca9570.yaml | 1 +
drivers/gpio/gpio-pca9570.c | 49 ++++++++++++++++---
2 files changed, 44 insertions(+), 6 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v6 1/3] dt-bindings: gpio: pca9570: Add compatible for slg7xl45106
2022-10-26 15:15 [PATCH v6 0/3] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
@ 2022-10-26 15:15 ` Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 2/3] gpio: pca9570: add a platform data structure Shubhrajyoti Datta
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Shubhrajyoti Datta @ 2022-10-26 15:15 UTC (permalink / raw)
To: linux-gpio
Cc: git, devicetree, linus.walleij, brgl, robh+dt,
krzysztof.kozlowski+dt, geert
This patch adds compatible string for the SLG7XL45106,
I2C GPO expander.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---
(no changes since v3)
Changes in v3:
Add ack
Changes in v2:
add alphabetically
Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
index 1acaa0a3d35a..48bf414aa50e 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
@@ -12,6 +12,7 @@ maintainers:
properties:
compatible:
enum:
+ - dlg,slg7xl45106
- nxp,pca9570
- nxp,pca9571
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v6 2/3] gpio: pca9570: add a platform data structure
2022-10-26 15:15 [PATCH v6 0/3] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 1/3] dt-bindings: gpio: pca9570: Add compatible for slg7xl45106 Shubhrajyoti Datta
@ 2022-10-26 15:15 ` Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 3/3] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
2022-10-27 7:48 ` [PATCH v6 0/3] " Bartosz Golaszewski
3 siblings, 0 replies; 5+ messages in thread
From: Shubhrajyoti Datta @ 2022-10-26 15:15 UTC (permalink / raw)
To: linux-gpio
Cc: git, devicetree, linus.walleij, brgl, robh+dt,
krzysztof.kozlowski+dt, geert
Add struct pca9570_platform_data for adding the platform data
structure. Also modify the existing structs for pca9570 and pca9571
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---
Changes in v6:
Fix the bisectablity reported by Geert Uytterhoeven
Changes in v3:
split the new patch
Suggested by Andy Shevchenko
drivers/gpio/gpio-pca9570.c | 31 ++++++++++++++++++++++++++-----
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-pca9570.c b/drivers/gpio/gpio-pca9570.c
index ab2a652964ec..e8c2ddb1bcd8 100644
--- a/drivers/gpio/gpio-pca9570.c
+++ b/drivers/gpio/gpio-pca9570.c
@@ -15,14 +15,26 @@
#include <linux/mutex.h>
#include <linux/property.h>
+/**
+ * struct pca9570_platform_data - GPIO platformdata
+ * @ngpio: no of gpios
+ * @command: Command to be sent
+ */
+struct pca9570_platform_data {
+ u16 ngpio;
+ u32 command;
+};
+
/**
* struct pca9570 - GPIO driver data
* @chip: GPIO controller chip
+ * @p_data: GPIO controller platform data
* @lock: Protects write sequences
* @out: Buffer for device register
*/
struct pca9570 {
struct gpio_chip chip;
+ const struct pca9570_platform_data *p_data;
struct mutex lock;
u8 out;
};
@@ -106,7 +118,8 @@ static int pca9570_probe(struct i2c_client *client)
gpio->chip.get = pca9570_get;
gpio->chip.set = pca9570_set;
gpio->chip.base = -1;
- gpio->chip.ngpio = (uintptr_t)device_get_match_data(&client->dev);
+ gpio->p_data = device_get_match_data(&client->dev);
+ gpio->chip.ngpio = gpio->p_data->ngpio;
gpio->chip.can_sleep = true;
mutex_init(&gpio->lock);
@@ -119,16 +132,24 @@ static int pca9570_probe(struct i2c_client *client)
return devm_gpiochip_add_data(&client->dev, &gpio->chip, gpio);
}
+static const struct pca9570_platform_data pca9570_gpio = {
+ .ngpio = 4,
+};
+
+static const struct pca9570_platform_data pca9571_gpio = {
+ .ngpio = 8,
+};
+
static const struct i2c_device_id pca9570_id_table[] = {
- { "pca9570", 4 },
- { "pca9571", 8 },
+ { "pca9570", (kernel_ulong_t)&pca9570_gpio},
+ { "pca9571", (kernel_ulong_t)&pca9571_gpio },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(i2c, pca9570_id_table);
static const struct of_device_id pca9570_of_match_table[] = {
- { .compatible = "nxp,pca9570", .data = (void *)4 },
- { .compatible = "nxp,pca9571", .data = (void *)8 },
+ { .compatible = "nxp,pca9570", .data = &pca9570_gpio },
+ { .compatible = "nxp,pca9571", .data = &pca9571_gpio },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, pca9570_of_match_table);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v6 3/3] gpio: pca9570: add slg7xl45106 support
2022-10-26 15:15 [PATCH v6 0/3] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 1/3] dt-bindings: gpio: pca9570: Add compatible for slg7xl45106 Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 2/3] gpio: pca9570: add a platform data structure Shubhrajyoti Datta
@ 2022-10-26 15:15 ` Shubhrajyoti Datta
2022-10-27 7:48 ` [PATCH v6 0/3] " Bartosz Golaszewski
3 siblings, 0 replies; 5+ messages in thread
From: Shubhrajyoti Datta @ 2022-10-26 15:15 UTC (permalink / raw)
To: linux-gpio
Cc: git, devicetree, linus.walleij, brgl, robh+dt,
krzysztof.kozlowski+dt, geert
Dialog semiconductors SLG7XL45106 is an 8-bit I2C GPO expander.
The output port is controlled by a data byte with register
address. Add a compatible string for the same. Also update
the driver to write and read from it.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---
Changes in v6:
Fix the bisectability remove the device_get_match_data change
Changes in v3:
split the new patch
Suggested by Andy Shevchenko
drivers/gpio/gpio-pca9570.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-pca9570.c b/drivers/gpio/gpio-pca9570.c
index e8c2ddb1bcd8..6c07a8811a7a 100644
--- a/drivers/gpio/gpio-pca9570.c
+++ b/drivers/gpio/gpio-pca9570.c
@@ -15,6 +15,8 @@
#include <linux/mutex.h>
#include <linux/property.h>
+#define SLG7XL45106_GPO_REG 0xDB
+
/**
* struct pca9570_platform_data - GPIO platformdata
* @ngpio: no of gpios
@@ -44,7 +46,11 @@ static int pca9570_read(struct pca9570 *gpio, u8 *value)
struct i2c_client *client = to_i2c_client(gpio->chip.parent);
int ret;
- ret = i2c_smbus_read_byte(client);
+ if (gpio->p_data->command != 0)
+ ret = i2c_smbus_read_byte_data(client, gpio->p_data->command);
+ else
+ ret = i2c_smbus_read_byte(client);
+
if (ret < 0)
return ret;
@@ -56,6 +62,9 @@ static int pca9570_write(struct pca9570 *gpio, u8 value)
{
struct i2c_client *client = to_i2c_client(gpio->chip.parent);
+ if (gpio->p_data->command != 0)
+ return i2c_smbus_write_byte_data(client, gpio->p_data->command, value);
+
return i2c_smbus_write_byte(client, value);
}
@@ -140,14 +149,21 @@ static const struct pca9570_platform_data pca9571_gpio = {
.ngpio = 8,
};
+static const struct pca9570_platform_data slg7xl45106_gpio = {
+ .ngpio = 8,
+ .command = SLG7XL45106_GPO_REG,
+};
+
static const struct i2c_device_id pca9570_id_table[] = {
{ "pca9570", (kernel_ulong_t)&pca9570_gpio},
{ "pca9571", (kernel_ulong_t)&pca9571_gpio },
+ { "slg7xl45106", (kernel_ulong_t)&slg7xl45106_gpio },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(i2c, pca9570_id_table);
static const struct of_device_id pca9570_of_match_table[] = {
+ { .compatible = "dlg,slg7xl45106", .data = &slg7xl45106_gpio},
{ .compatible = "nxp,pca9570", .data = &pca9570_gpio },
{ .compatible = "nxp,pca9571", .data = &pca9571_gpio },
{ /* sentinel */ }
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v6 0/3] gpio: pca9570: add slg7xl45106 support
2022-10-26 15:15 [PATCH v6 0/3] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
` (2 preceding siblings ...)
2022-10-26 15:15 ` [PATCH v6 3/3] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
@ 2022-10-27 7:48 ` Bartosz Golaszewski
3 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2022-10-27 7:48 UTC (permalink / raw)
To: Shubhrajyoti Datta
Cc: linux-gpio, git, devicetree, linus.walleij, robh+dt,
krzysztof.kozlowski+dt, geert
On Wed, Oct 26, 2022 at 5:16 PM Shubhrajyoti Datta
<shubhrajyoti.datta@amd.com> wrote:
>
>
> Add Dialog semiconductors SLG7XL45106 GPO expander
>
>
> Changes in v6:
> Fix the bisectablity reported by Geert Uytterhoeven
>
> v4 and v5:
> Resend as the patches were mangled.
>
> Changes in v3:
> Add ack
> split the new patch
> Suggested by Andy Shevchenko
>
> Changes in v2:
> add alphabetically
>
> Shubhrajyoti Datta (3):
> dt-bindings: gpio: pca9570: Add compatible for slg7xl45106
> gpio: pca9570: add a platform data structure
> gpio: pca9570: add slg7xl45106 support
>
> .../bindings/gpio/gpio-pca9570.yaml | 1 +
> drivers/gpio/gpio-pca9570.c | 49 ++++++++++++++++---
> 2 files changed, 44 insertions(+), 6 deletions(-)
>
> --
> 2.17.1
>
Reapplied, thanks!
Bart
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-27 7:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 15:15 [PATCH v6 0/3] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 1/3] dt-bindings: gpio: pca9570: Add compatible for slg7xl45106 Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 2/3] gpio: pca9570: add a platform data structure Shubhrajyoti Datta
2022-10-26 15:15 ` [PATCH v6 3/3] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
2022-10-27 7:48 ` [PATCH v6 0/3] " Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.