All of lore.kernel.org
 help / color / mirror / Atom feed
* cpuidle changes and drivers/acpi/processor_idle.c
@ 2012-01-31 18:55 Rob Lee
  0 siblings, 0 replies; only message in thread
From: Rob Lee @ 2012-01-31 18:55 UTC (permalink / raw)
  To: linux-acpi, Len Brown

In the various versions of acpi_idle_enter, I see the following code.

...
	cx->usage++;

	lapic_timer_state_broadcast(pr, cx, 0);
	cx->time += idle_time;
...

But this usage and idle_time and accounted for by the core cpuidle
driver, so is this a small bug and the usage and idle_time accounting
code should be removed?

Also, I see the following:

	/* Tell the scheduler how much we idled: */
	sched_clock_idle_wakeup_event(idle_time_ns);

The sched_clock_idle_wakeup_event does nothing with the idle_time_ns
parameter it is passed.  Perhaps it did at one time.  Is this call
still necessary?

Thanks,
Rob

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-01-31 18:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-31 18:55 cpuidle changes and drivers/acpi/processor_idle.c Rob Lee

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.