From: Cong Wang <xiyou.wangcong@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: David Miller <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Eric Dumazet <edumazet@google.com>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: net: suspicious RCU usage in nf_hook
Date: Fri, 27 Jan 2017 15:30:50 -0800 [thread overview]
Message-ID: <CAM_iQpU9Tc6vwZ46wKcmH8FMRyYesY9qXM0kDY-OhgWbO-TtpQ@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpXNwZbkF+zoR5qdREcK6ZFt3ODbrpRB38WidLkcUWt5dw@mail.gmail.com>
On Fri, Jan 27, 2017 at 3:22 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Fri, Jan 27, 2017 at 1:15 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
>> stack backtrace:
>> CPU: 2 PID: 23111 Comm: syz-executor14 Not tainted 4.10.0-rc5+ #192
>> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
>> Call Trace:
>> __dump_stack lib/dump_stack.c:15 [inline]
>> dump_stack+0x2ee/0x3ef lib/dump_stack.c:51
>> lockdep_rcu_suspicious+0x139/0x180 kernel/locking/lockdep.c:4452
>> rcu_preempt_sleep_check include/linux/rcupdate.h:560 [inline]
>> ___might_sleep+0x560/0x650 kernel/sched/core.c:7748
>> __might_sleep+0x95/0x1a0 kernel/sched/core.c:7739
>> mutex_lock_nested+0x24f/0x1730 kernel/locking/mutex.c:752
>> atomic_dec_and_mutex_lock+0x119/0x160 kernel/locking/mutex.c:1060
>> __static_key_slow_dec+0x7a/0x1e0 kernel/jump_label.c:149
>> static_key_slow_dec+0x51/0x90 kernel/jump_label.c:174
>> net_disable_timestamp+0x3b/0x50 net/core/dev.c:1728
>> sock_disable_timestamp+0x98/0xc0 net/core/sock.c:403
>> __sk_destruct+0x27d/0x6b0 net/core/sock.c:1441
>> sk_destruct+0x47/0x80 net/core/sock.c:1460
>
> jump label uses a mutex and we call jump label API in softIRQ context...
> Maybe we have to move it to a work struct as what we did for netlink.
Correct myself: process context but with RCU read lock held...
next prev parent reply other threads:[~2017-01-27 23:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 21:15 net: suspicious RCU usage in nf_hook Dmitry Vyukov
2017-01-27 23:22 ` Cong Wang
2017-01-27 23:30 ` Cong Wang [this message]
2017-01-27 23:35 ` Eric Dumazet
2017-01-28 1:00 ` Cong Wang
2017-01-28 1:31 ` Eric Dumazet
2017-01-31 6:19 ` Cong Wang
2017-01-31 15:44 ` Eric Dumazet
2017-02-01 20:51 ` Cong Wang
2017-02-01 21:16 ` Eric Dumazet
2017-02-01 21:22 ` Eric Dumazet
2017-02-01 23:29 ` Cong Wang
2017-02-01 23:48 ` Eric Dumazet
2017-02-01 23:59 ` Eric Dumazet
2017-02-02 18:01 ` Cong Wang
2017-02-02 18:31 ` [PATCH net] net: use a work queue to defer net_disable_timestamp() work Eric Dumazet
2017-02-03 21:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpU9Tc6vwZ46wKcmH8FMRyYesY9qXM0kDY-OhgWbO-TtpQ@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=syzkaller@googlegroups.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.