* [PATCH -next] tracing: remove set but not used variable 'buffer'
@ 2019-12-07 3:44 YueHaibing
2019-12-07 19:02 ` Cong Wang
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-12-07 3:44 UTC (permalink / raw)
To: rostedt, mingo, xiyou.wangcong; +Cc: linux-kernel, YueHaibing
kernel/trace/trace_events_inject.c: In function trace_inject_entry:
kernel/trace/trace_events_inject.c:20:22: warning: variable buffer set but not used [-Wunused-but-set-variable]
It is never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
kernel/trace/trace_events_inject.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/trace/trace_events_inject.c b/kernel/trace/trace_events_inject.c
index d437107..d45079e 100644
--- a/kernel/trace/trace_events_inject.c
+++ b/kernel/trace/trace_events_inject.c
@@ -17,12 +17,10 @@ static int
trace_inject_entry(struct trace_event_file *file, void *rec, int len)
{
struct trace_event_buffer fbuffer;
- struct ring_buffer *buffer;
int written = 0;
void *entry;
rcu_read_lock_sched();
- buffer = file->tr->trace_buffer.buffer;
entry = trace_event_buffer_reserve(&fbuffer, file, len);
if (entry) {
memcpy(entry, rec, len);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] tracing: remove set but not used variable 'buffer'
2019-12-07 3:44 [PATCH -next] tracing: remove set but not used variable 'buffer' YueHaibing
@ 2019-12-07 19:02 ` Cong Wang
0 siblings, 0 replies; 2+ messages in thread
From: Cong Wang @ 2019-12-07 19:02 UTC (permalink / raw)
To: YueHaibing; +Cc: Steven Rostedt, Ingo Molnar, LKML
On Fri, Dec 6, 2019 at 7:46 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> kernel/trace/trace_events_inject.c: In function trace_inject_entry:
> kernel/trace/trace_events_inject.c:20:22: warning: variable buffer set but not used [-Wunused-but-set-variable]
>
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Right, this should be a leftover after I removed ring_buffer_nest_start().
And my compiler failed to catch this.
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-07 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-07 3:44 [PATCH -next] tracing: remove set but not used variable 'buffer' YueHaibing
2019-12-07 19:02 ` Cong Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.