All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	Simon Horman <simon.horman@netronome.com>,
	john.hurley@netronome.com, David Ahern <dsahern@gmail.com>,
	mlxsw@mellanox.com
Subject: Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw
Date: Tue, 26 Jun 2018 17:04:31 -0700	[thread overview]
Message-ID: <CAM_iQpVzuX4P_C=APtWcTMGtuFZiS_ncAaJvtF6Chz19pG_oJg@mail.gmail.com> (raw)
In-Reply-To: <20180626080000.12964-1-jiri@resnulli.us>

On Tue, Jun 26, 2018 at 1:01 AM Jiri Pirko <jiri@resnulli.us> wrote:
> Create dummy device with clsact first:
> # ip link add type dummy
> # tc qdisc add dev dummy0 clsact
>
> There is no template assigned by default:
> # tc filter template show dev dummy0 ingress
>
> Add a template of type flower allowing to insert rules matching on last
> 2 bytes of destination mac address:
> # tc filter template add dev dummy0 ingress proto ip flower dst_mac 00:00:00:00:00:00/00:00:00:00:FF:FF

Now you are extending 'tc filter' command with a new
subcommand 'template', which looks weird.

Why not make it a new property of filter like you did for chain?
Like:

tc filter add dev dummy0 ingress proto ip template flower

which is much better IMHO.

  parent reply	other threads:[~2018-06-27  0:04 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26  7:59 [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw Jiri Pirko
2018-06-26  7:59 ` [patch net-next v2 1/9] net: sched: push ops lookup bits into tcf_proto_lookup_ops() Jiri Pirko
2018-06-26  7:59 ` [patch net-next v2 2/9] net: sched: introduce chain templates Jiri Pirko
2018-06-26  7:59 ` [patch net-next v2 3/9] net: sched: cls_flower: move key/mask dumping into a separate function Jiri Pirko
2018-06-26  7:59 ` [patch net-next v2 4/9] net: sched: cls_flower: change fl_init_dissector to accept mask and dissector Jiri Pirko
2018-06-26  7:59 ` [patch net-next v2 5/9] net: sched: cls_flower: implement chain templates Jiri Pirko
2018-06-26  7:59 ` [patch net-next v2 6/9] net: sched: cls_flower: propagate chain teplate creation and destruction to drivers Jiri Pirko
2018-06-26  7:59 ` [patch net-next v2 7/9] mlxsw: spectrum: Implement chain template hinting Jiri Pirko
2018-06-26 10:20   ` Ido Schimmel
2018-06-26  7:59 ` [patch net-next v2 8/9] selftests: forwarding: move shblock tc support check to a separate helper Jiri Pirko
2018-06-26  8:00 ` [patch net-next v2 9/9] selftests: forwarding: add tests for TC chain templates Jiri Pirko
2018-06-27  0:04 ` Cong Wang [this message]
2018-06-27  6:05   ` [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw Jiri Pirko
2018-06-27  6:34     ` Samudrala, Sridhar
2018-06-27  7:03       ` Jiri Pirko
2018-06-28  4:48 ` David Miller
2018-06-28  6:25   ` Jiri Pirko
2018-06-28 17:38   ` Cong Wang
2018-06-28 13:13 ` Jamal Hadi Salim
2018-06-28 13:22   ` Jiri Pirko
2018-06-28 13:54     ` Jamal Hadi Salim
2018-06-28 14:17       ` Jiri Pirko
2018-06-28 13:08 Jiri Pirko
2018-06-28 13:24 ` Jiri Pirko
2018-06-28 14:18 ` David Ahern
2018-06-28 14:29   ` Jiri Pirko
2018-06-28 15:10     ` David Ahern
2018-06-28 15:37       ` Jiri Pirko
2018-06-28 15:50         ` David Ahern
2018-06-28 16:08           ` Jiri Pirko
2018-06-28 22:25 ` Cong Wang
2018-06-29  8:39   ` Jiri Pirko
2018-06-29 12:12     ` Jamal Hadi Salim
2018-06-29 12:48       ` Jiri Pirko
2018-06-29 12:54         ` David Ahern
2018-06-29 13:05           ` Jiri Pirko
2018-06-29 17:06             ` Samudrala, Sridhar
2018-06-29 22:18               ` Cong Wang
2018-06-30 10:12                 ` Jiri Pirko
2018-07-02 19:33                   ` Cong Wang
2018-06-29 13:32           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpVzuX4P_C=APtWcTMGtuFZiS_ncAaJvtF6Chz19pG_oJg@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.hurley@netronome.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=simon.horman@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.