[PATCH] kernel: fix mishandling of out of memory in poweroff

[PATCH] kernel: fix mishandling of out of memory in poweroff

[Alan Cox]

From: Alan Cox <alan@linux.intel.com>

Coverity 703573

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 kernel/sys.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index b04ae03..9271b7c 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -2212,13 +2212,13 @@ int orderly_poweroff(bool force)
 
 	ret = call_usermodehelper_fns(argv[0], argv, envp, UMH_NO_WAIT,
 				      NULL, argv_cleanup, NULL);
-out:
 	if (likely(!ret))
 		return 0;
 
 	if (ret == -ENOMEM)
 		argv_free(argv);
 
+out:
 	if (force) {
 		printk(KERN_WARNING "Failed to start orderly shutdown: "
 		       "forcing the issue\n");

Re: [PATCH] kernel: fix mishandling of out of memory in poweroff

[Andrew Morton]

On Wed, 04 Jul 2012 16:34:51 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> From: Alan Cox <alan@linux.intel.com>
> 
> Coverity 703573
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>

It would be nice to have a Reported-by here, but we were only given
"Scan Subscription <scan-subscription@coverity.com>".

Is there some human behind these reports?  If so, can that person's
details please be included?

RE: [PATCH] kernel: fix mishandling of out of memory in poweroff

[Scan Subscription]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 2557 bytes --]

Hi Andew,

The two reports that were sent on 6/28 and 7/6, were sent manually by us, Coverit Scan Admin, project dedicated for Open Source Community.
But going forward (next week), it will be completely automated. 
Based on the suggestions we got from some of the lead Linux Developer, weekly report includes only "Newly" discovered defects from the code change in that week, and will be sent to maintainer and to the community.
There are on an avg. 5-10 new defects in a week, sometime none.

Any one who wants to contact the person for the reports being sent, they can use the details provided at the end of the email that is scan-admin@coverity.com 
However, we are open to suggestions.

Reasons for using generic email
1. It is desgined to be automated, but so far it was manuall.
2. There are group of people behind this email and not just one. So, anyone who is available will respond.
3. Other Open Source community has shown the same interest to generate report on newly discoverd defect every time build is commited to Scan, and we use the same generic email address to subscribe and to send the reoprt to their mailing list, instead of creating separate email for each Open Source project.

Hence, using either scan-admin@coverity.com or scan-subscription@coverity.com would be fine, but better would be to use the one in the email signaure, that is, scan-admin@coverity.com 
We will add "Reported By" in the next report.

However, as I said, we are open to suggestions.

Thanks
Coverity Scan-Admin scan-admin@coverity.com 
Dakshesh Vyas | Technical Manager - SCAN
Coverity | 185 Berry Street | Suite 6500, Lobby 3 | San Francisco, CA  94107 
Office: 415.935.2957 | dvyas@coverity.com
http://scan.coverity.com 

________________________________________
From: Andrew Morton [akpm@linux-foundation.org]
Sent: Tuesday, July 10, 2012 1:15 PM
To: Alan Cox
Cc: linux-kernel@vger.kernel.org; Scan Subscription
Subject: Re: [PATCH] kernel: fix mishandling of out of memory in poweroff

On Wed, 04 Jul 2012 16:34:51 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> From: Alan Cox <alan@linux.intel.com>
>
> Coverity 703573
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>

It would be nice to have a Reported-by here, but we were only given
"Scan Subscription <scan-subscription@coverity.com>".

Is there some human behind these reports?  If so, can that person's
details please be included?ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] kernel: fix mishandling of out of memory in poweroff

[Ozan Çağlayan]

> It would be nice to have a Reported-by here, but we were only given
> "Scan Subscription <scan-subscription@coverity.com>".
>
> Is there some human behind these reports?  If so, can that person's
> details please be included?

Also note that gmail marks these as "Spam" probably because of the
word "subscription".

Regards,

-- 
Ozan Çağlayan

Re: [PATCH] kernel: fix mishandling of out of memory in poweroff

[richard -rw- weinberger]

On Wed, Jul 11, 2012 at 11:30 AM, Ozan Çağlayan <ozancag@gmail.com> wrote:
>> It would be nice to have a Reported-by here, but we were only given
>> "Scan Subscription <scan-subscription@coverity.com>".
>>
>> Is there some human behind these reports?  If so, can that person's
>> details please be included?
>
> Also note that gmail marks these as "Spam" probably because of the
> word "subscription".

Not here.

-- 
Thanks,
//richard

Re: [PATCH] kernel: fix mishandling of out of memory in poweroff

[Cong Wang]

(I can't find Alan's initial email, so reply to this one.)

Hi, Alan,

I sent a same patch few minutes ahead of yours:

http://marc.info/?l=linux-kernel&m=134137296531838

and got some ACK's already.