* [PATCH net] devinet: fix memleak in inetdev_init()
@ 2020-05-30 3:34 Yang Yingliang
2020-05-30 4:39 ` Cong Wang
2020-05-31 0:50 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2020-05-30 3:34 UTC (permalink / raw)
To: xiyou.wangcong, davem, netdev; +Cc: yangyingliang
When devinet_sysctl_register() failed, the memory allocated
in neigh_parms_alloc() should be freed.
Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or default")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
net/ipv4/devinet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index c0dd561..5267b6b 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -276,6 +276,7 @@ static struct in_device *inetdev_init(struct net_device *dev)
err = devinet_sysctl_register(in_dev);
if (err) {
in_dev->dead = 1;
+ neigh_parms_release(&arp_tbl, in_dev->arp_parms);
in_dev_put(in_dev);
in_dev = NULL;
goto out;
--
1.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] devinet: fix memleak in inetdev_init()
2020-05-30 3:34 [PATCH net] devinet: fix memleak in inetdev_init() Yang Yingliang
@ 2020-05-30 4:39 ` Cong Wang
2020-05-31 0:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2020-05-30 4:39 UTC (permalink / raw)
To: Yang Yingliang; +Cc: David Miller, Linux Kernel Network Developers
On Fri, May 29, 2020 at 8:11 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> When devinet_sysctl_register() failed, the memory allocated
> in neigh_parms_alloc() should be freed.
>
> Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or default")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] devinet: fix memleak in inetdev_init()
2020-05-30 3:34 [PATCH net] devinet: fix memleak in inetdev_init() Yang Yingliang
2020-05-30 4:39 ` Cong Wang
@ 2020-05-31 0:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-31 0:50 UTC (permalink / raw)
To: yangyingliang; +Cc: xiyou.wangcong, netdev
From: Yang Yingliang <yangyingliang@huawei.com>
Date: Sat, 30 May 2020 11:34:33 +0800
> When devinet_sysctl_register() failed, the memory allocated
> in neigh_parms_alloc() should be freed.
>
> Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or default")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-31 0:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30 3:34 [PATCH net] devinet: fix memleak in inetdev_init() Yang Yingliang
2020-05-30 4:39 ` Cong Wang
2020-05-31 0:50 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.