All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Mason <mason@myri.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Avi Kivity <avi@redhat.com>, Sven Schnelle <svens@stackframe.org>,
	Simon Kirby <sim@hostway.ca>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Niels Ole Salscheider <niels_ole@salscheider-online.de>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [REGRESSION] e1000e failure triggered by "PCI: Remove MRRS modification from MPS setting code"
Date: Thu, 29 Sep 2011 08:53:26 -0500	[thread overview]
Message-ID: <CAMaF-rPPUcSLJfYVv7YNnQbvPPNug9hmO5XQjNKm9+-Prd67MQ@mail.gmail.com> (raw)
In-Reply-To: <1317270796.29415.160.camel@pasglop>

On Wed, Sep 28, 2011 at 11:33 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
>
>> Booting with "pci=pcie_bus_perf" should provide you with the same
>> behavior as before (e.g., with the patch reverted).  This should
>> enable you work around this issue until I can get it resolved.  On the
>> positive side, your system should be 10% faster than it was in 3.0
>> (due to the PCI bus payloads being 2x larger).
>
> Ugh, that's assuming your fixes for the "perf" mode are in, which I
> thought wasn't the case yet ... without them, "perf" does very wrong
> things..

Yes, but this was "working" before.  The patch he wants reverted was
the one that makes MPS "Safe" the default.  So, changing it to "perf"
would give it the same behavior as before.

>> If you can provide the same output with the patch not reverted, it
>> would be very beneficial.  Based on your description, the lockup only
>> occurs with traffic.  You can gather this before any traffic goes out
>> (perhaps booting without networking enabled).
>
> Right, the output he provided has the MRRS clearly changing in addition
> to the MPS.
>
> Ideally, we'd need the output with current upstream vs. with before your
> very first patch went in and compare that.
>
> Also, Avi, can you send these outputs like patches ? IE without wrapping
> them ? That would be handy :-)
>
> Cheers,
> Ben.
>
>
>

  reply	other threads:[~2011-09-29 13:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 17:01 [REGRESSION] e1000e failure triggered by "PCI: Remove MRRS modification from MPS setting code" Avi Kivity
2011-09-27 17:59 ` Jon Mason
2011-09-27 18:28   ` Avi Kivity
2011-09-27 20:11     ` Jon Mason
2011-09-29  4:33       ` Benjamin Herrenschmidt
2011-09-29 13:53         ` Jon Mason [this message]
2011-09-30  0:16     ` Workaround for Intel MPS errata Jon Mason
2011-09-30  2:21       ` Jesse Brandeburg
2011-09-30  2:51         ` Jon Mason
2011-09-30  5:01       ` Bjorn Helgaas
2011-09-30 15:35         ` Jon Mason
2011-09-30 17:17           ` Bjorn Helgaas
2011-09-30 17:38             ` Jon Mason
2011-09-30 17:57               ` Bjorn Helgaas
2011-09-30  7:03       ` Rolf Eike Beer
2011-09-30 15:39         ` Jon Mason
2011-10-02  9:26       ` Avi Kivity
2011-10-03  4:58         ` Jon Mason
2011-10-03 10:11           ` Avi Kivity
2011-10-03 15:12             ` Jon Mason
2011-10-04  9:46               ` Avi Kivity
2011-10-04 13:06                 ` Avi Kivity
2011-10-04 13:11                   ` Jon Mason
2011-10-04 20:12                   ` Jon Mason
2011-10-05  3:46                   ` Jon Mason
2011-10-05 12:09                     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMaF-rPPUcSLJfYVv7YNnQbvPPNug9hmO5XQjNKm9+-Prd67MQ@mail.gmail.com \
    --to=mason@myri.com \
    --cc=avi@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=eric.dumazet@gmail.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=niels_ole@salscheider-online.de \
    --cc=sim@hostway.ca \
    --cc=svens@stackframe.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.