rk3328 USB3 controller

rk3328 USB3 controller

[Peter Geis]

Good Afternoon,

Is there a particular reason why the USB3 controller on the rk3328 has
not been enabled?
It's enabled on the TeamFirefly source [0].
I pulled it in to my device tree and have been using a USB3 SSD as my
boot device for over a year now.

If I were to submit the patch, would y'all be open to pulling it in?

[0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi

Re: rk3328 USB3 controller

[Katsuhiro Suzuki]

Hello Peter,

USB3 phy driver "rockchip,rk3328-u3phy" has not been implemented on
upstream linux kernel.

FireflyTeam use the special version of linux that is modified by Rockchip.
(It seems based on linux-4.4)

rockchip,rk3328-u3phy is provided by
   https://github.com/FireflyTeam/kernel/drivers/phy/rockchip/phy-rockchip-inno-usb3.c

If you want to use USB 3.0 with upstream linux, we need to port this
USB3 phy driver from rockchip-linux to upstream kernel, I think.

Best Regards,
Katsuhiro Suzuki


On 2019/10/17 3:54, Peter Geis wrote:
> Good Afternoon,
> 
> Is there a particular reason why the USB3 controller on the rk3328 has
> not been enabled?
> It's enabled on the TeamFirefly source [0].
> I pulled it in to my device tree and have been using a USB3 SSD as my
> boot device for over a year now.
> 
> If I were to submit the patch, would y'all be open to pulling it in?
> 
> [0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
> 

Re: rk3328 USB3 controller

[4omecha-Re5JQEeQqe8AvxtiuMwx3w]

On 2019-10-17 14:07:43, Katsuhiro Suzuki wrote:
>Hello Peter,
>
>USB3 phy driver "rockchip,rk3328-u3phy" has not been implemented on
>upstream linux kernel.
>
>FireflyTeam use the special version of linux that is modified by Rockchip.
>(It seems based on linux-4.4)
>
>rockchip,rk3328-u3phy is provided by
>  https://github.com/FireflyTeam/kernel/drivers/phy/rockchip/phy-rockchip-inno-usb3.c
That's a 404 over here.


>
>If you want to use USB 3.0 with upstream linux, we need to port this
>USB3 phy driver from rockchip-linux to upstream kernel, I think.
>
>Best Regards,
>Katsuhiro Suzuki
>
>
>On 2019/10/17 3:54, Peter Geis wrote:
>>Good Afternoon,
>>
>>Is there a particular reason why the USB3 controller on the rk3328 has
>>not been enabled?
>>It's enabled on the TeamFirefly source [0].
>>I pulled it in to my device tree and have been using a USB3 SSD as my
>>boot device for over a year now.
>>
>>If I were to submit the patch, would y'all be open to pulling it in?
>>
>>[0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>>
>>_______________________________________________
>>Linux-rockchip mailing list
>>Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
>>http://lists.infradead.org/mailman/listinfo/linux-rockchip
>>
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: rk3328 USB3 controller

[Robin Murphy]

On 16/10/2019 19:54, Peter Geis wrote:
> Good Afternoon,
> 
> Is there a particular reason why the USB3 controller on the rk3328 has
> not been enabled?
> It's enabled on the TeamFirefly source [0].
> I pulled it in to my device tree and have been using a USB3 SSD as my
> boot device for over a year now.

IIRC, the issue is that it's effectively *only* usable for a boot device 
(or possibly with a fixed hub), since without the phy driver, as soon as 
the initial device is unplugged the controller can no longer detect 
anything being plugged in again.

Robin.

> 
> If I were to submit the patch, would y'all be open to pulling it in?
> 
> [0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
> 

Re: rk3328 USB3 controller

[Peter Geis]

On Thu, Oct 17, 2019 at 12:35 PM Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> wrote:
>
> On 16/10/2019 19:54, Peter Geis wrote:
> > Good Afternoon,
> >
> > Is there a particular reason why the USB3 controller on the rk3328 has
> > not been enabled?
> > It's enabled on the TeamFirefly source [0].
> > I pulled it in to my device tree and have been using a USB3 SSD as my
> > boot device for over a year now.
>
> IIRC, the issue is that it's effectively *only* usable for a boot device
> (or possibly with a fixed hub), since without the phy driver, as soon as
> the initial device is unplugged the controller can no longer detect
> anything being plugged in again.
>
> Robin.

Well that's the behavior I was seeing, but I've just pulled the driver
in and with very little tweaking it builds and loads fine.
Need to conduct usability testing but it should be good to go.

>
> >
> > If I were to submit the patch, would y'all be open to pulling it in?
> >
> > [0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
> >

Re: rk3328 USB3 controller

[Katsuhiro Suzuki]

Hello,

On 2019/10/18 1:21, 4omecha@gmail.com wrote:
> On 2019-10-17 14:07:43, Katsuhiro Suzuki wrote:
>> Hello Peter,
>>
>> USB3 phy driver "rockchip,rk3328-u3phy" has not been implemented on
>> upstream linux kernel.
>>
>> FireflyTeam use the special version of linux that is modified by Rockchip.
>> (It seems based on linux-4.4)
>>
>> rockchip,rk3328-u3phy is provided by
>>  https://github.com/FireflyTeam/kernel/drivers/phy/rockchip/phy-rockchip-inno-usb3.c
> That's a 404 over here.
> 
> 

Oops, this URL is correct.

https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/drivers/phy/rockchip/phy-rockchip-inno-usb3.c


>>
>> If you want to use USB 3.0 with upstream linux, we need to port this
>> USB3 phy driver from rockchip-linux to upstream kernel, I think.
>>
>> Best Regards,
>> Katsuhiro Suzuki
>>
>>
>> On 2019/10/17 3:54, Peter Geis wrote:
>>> Good Afternoon,
>>>
>>> Is there a particular reason why the USB3 controller on the rk3328 has
>>> not been enabled?
>>> It's enabled on the TeamFirefly source [0].
>>> I pulled it in to my device tree and have been using a USB3 SSD as my
>>> boot device for over a year now.
>>>
>>> If I were to submit the patch, would y'all be open to pulling it in?
>>>
>>> [0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>>>
>>> _______________________________________________
>>> Linux-rockchip mailing list
>>> Linux-rockchip@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>>>
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
> 
> 


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip