* commit 0e334db6bb4b1fd1e2d72c1f3d8f004313cd9f94 breaks timer
@ 2018-12-31 2:07 H.J. Lu
2019-01-03 16:53 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2018-12-31 2:07 UTC (permalink / raw)
To: LKML, Thomas Gleixner
On 4.19 branch,
commit 82c8dbb376b9fa9b831c157cbb15664cb4a343e3
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Mon Dec 17 13:31:05 2018 +0100
posix-timers: Fix division by zero bug
commit 0e334db6bb4b1fd1e2d72c1f3d8f004313cd9f94 upstream.
The signal delivery path of posix-timers can try to rearm the timer even if
the interval is zero. That's handled for the common case (hrtimer) but not
for alarm timers. In that case the forwarding function raises a division by
zero exception.
The handling for hrtimer based posix timers is wrong because it marks the
timer as active despite the fact that it is stopped.
Move the check from common_hrtimer_rearm() to posixtimer_rearm() to cure
both issues.
caused:
https://bugzilla.redhat.com/show_bug.cgi?id=1662602
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: commit 0e334db6bb4b1fd1e2d72c1f3d8f004313cd9f94 breaks timer
2018-12-31 2:07 commit 0e334db6bb4b1fd1e2d72c1f3d8f004313cd9f94 breaks timer H.J. Lu
@ 2019-01-03 16:53 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2019-01-03 16:53 UTC (permalink / raw)
To: LKML, Thomas Gleixner, Yu-cheng Yu
On Sun, Dec 30, 2018 at 6:07 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On 4.19 branch,
>
> commit 82c8dbb376b9fa9b831c157cbb15664cb4a343e3
> Author: Thomas Gleixner <tglx@linutronix.de>
> Date: Mon Dec 17 13:31:05 2018 +0100
>
> posix-timers: Fix division by zero bug
>
> commit 0e334db6bb4b1fd1e2d72c1f3d8f004313cd9f94 upstream.
>
> The signal delivery path of posix-timers can try to rearm the timer even if
> the interval is zero. That's handled for the common case (hrtimer) but not
> for alarm timers. In that case the forwarding function raises a division by
> zero exception.
>
> The handling for hrtimer based posix timers is wrong because it marks the
> timer as active despite the fact that it is stopped.
>
> Move the check from common_hrtimer_rearm() to posixtimer_rearm() to cure
> both issues.
>
> caused:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1662602
>
I opened:
https://bugzilla.kernel.org/show_bug.cgi?id=202123
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-03 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-31 2:07 commit 0e334db6bb4b1fd1e2d72c1f3d8f004313cd9f94 breaks timer H.J. Lu
2019-01-03 16:53 ` H.J. Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.