From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/gma500: fix double freeing
Date: Tue, 29 Sep 2015 15:20:35 +0200 [thread overview]
Message-ID: <CAMeQTsZvcpL3MRF_VTR_nvbhKKUTK-+c_kEc2UBP2t6WzAr3vg@mail.gmail.com> (raw)
In-Reply-To: <20150924155725.GE10109@sudip-pc>
On Thu, Sep 24, 2015 at 5:57 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Wed, Sep 09, 2015 at 06:20:40PM +0530, Sudip Mukherjee wrote:
>> If backing->stolen is true then we were freeing backing by calling
>> psb_gtt_free_range() but we called it again after unlocking the mutex.
>> Lets make it NULL after freeing in psb_gtt_free_range() and check for
>> NULL before calling the function for the second time.
>>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>> ---
> Hi Patrik,
> A gentle ping.
>
> regards
> sudip
Hi, sorry for the late reply.
Why are we freeing the range twice in the first case?
-Patrik
WARNING: multiple messages have this Message-ID (diff)
From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/gma500: fix double freeing
Date: Tue, 29 Sep 2015 15:20:35 +0200 [thread overview]
Message-ID: <CAMeQTsZvcpL3MRF_VTR_nvbhKKUTK-+c_kEc2UBP2t6WzAr3vg@mail.gmail.com> (raw)
In-Reply-To: <20150924155725.GE10109@sudip-pc>
On Thu, Sep 24, 2015 at 5:57 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Wed, Sep 09, 2015 at 06:20:40PM +0530, Sudip Mukherjee wrote:
>> If backing->stolen is true then we were freeing backing by calling
>> psb_gtt_free_range() but we called it again after unlocking the mutex.
>> Lets make it NULL after freeing in psb_gtt_free_range() and check for
>> NULL before calling the function for the second time.
>>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>> ---
> Hi Patrik,
> A gentle ping.
>
> regards
> sudip
Hi, sorry for the late reply.
Why are we freeing the range twice in the first case?
-Patrik
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-09-29 13:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 12:50 [PATCH] drm/gma500: fix double freeing Sudip Mukherjee
2015-09-09 12:50 ` Sudip Mukherjee
2015-09-24 15:57 ` Sudip Mukherjee
2015-09-24 15:57 ` Sudip Mukherjee
2015-09-29 13:20 ` Patrik Jakobsson [this message]
2015-09-29 13:20 ` Patrik Jakobsson
2015-09-30 6:12 ` Sudip Mukherjee
2015-09-30 6:12 ` Sudip Mukherjee
2015-10-01 17:07 ` Patrik Jakobsson
2015-10-01 17:07 ` Patrik Jakobsson
2015-10-02 15:56 ` Sudip Mukherjee
2015-10-02 15:56 ` Sudip Mukherjee
2015-10-05 23:54 ` Patrik Jakobsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMeQTsZvcpL3MRF_VTR_nvbhKKUTK-+c_kEc2UBP2t6WzAr3vg@mail.gmail.com \
--to=patrik.r.jakobsson@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.