Re: [PATCH] mfd: max8925-i2c: Add some blank lines before return

Re: [PATCH] mfd: max8925-i2c: Add some blank lines before return

[Lee Jones]

On Tue, 22 Jul 2014, pramod.gurav.etc@gmail.com wrote:

> From: Pramod Gurav <pramod.gurav.etc@gmail.com>
> 
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
> ---
> Lee, This is what I was referring to when I said there are more such
> changes needed. Hope they are ok.
> 
> Sending just to you as I could not send it on that mail chain.

I can't accept any patch which hasn't been on the list.  Please find a
way to do so.

> Please add these with your changes if ok.
> 
>  drivers/mfd/max8925-i2c.c |    5 +++++
>  1 file changed, 5 insertions(+)

Can you rebase this on top of my for-mfd-next branc please?

> diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c
> index a83eed5..d085cdf 100644
> --- a/drivers/mfd/max8925-i2c.c
> +++ b/drivers/mfd/max8925-i2c.c
> @@ -31,6 +31,7 @@ static inline int max8925_read_device(struct i2c_client *i2c,
>  			return ret;
>  		*(unsigned char *)dest = (unsigned char)ret;
>  	}
> +
>  	return ret;
>  }
>  
> @@ -46,6 +47,7 @@ static inline int max8925_write_device(struct i2c_client *i2c,
>  	ret = i2c_master_send(i2c, buf, bytes + 1);
>  	if (ret < 0)
>  		return ret;
> +
>  	return 0;
>  }
>  
> @@ -145,6 +147,7 @@ static int max8925_dt_init(struct device_node *np, struct device *dev,
>  		dev_err(dev, "Not found maxim,tsc-irq property\n");
>  		return -EINVAL;
>  	}
> +
>  	return 0;
>  }
>  
> @@ -220,6 +223,7 @@ static int max8925_suspend(struct device *dev)
>  
>  	if (device_may_wakeup(dev) && chip->wakeup_flag)
>  		enable_irq_wake(chip->core_irq);
> +
>  	return 0;
>  }
>  
> @@ -230,6 +234,7 @@ static int max8925_resume(struct device *dev)
>  
>  	if (device_may_wakeup(dev) && chip->wakeup_flag)
>  		disable_irq_wake(chip->core_irq);
> +
>  	return 0;
>  }
>  #endif

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: max8925-i2c: Add some blank lines before return

[pramod gurav]

On Tue, Jul 22, 2014 at 7:36 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Tue, 22 Jul 2014, pramod.gurav.etc@gmail.com wrote:
> I can't accept any patch which hasn't been on the list.  Please find a
> way to do so.
>
>> Please add these with your changes if ok.
>>
>>  drivers/mfd/max8925-i2c.c |    5 +++++
>>  1 file changed, 5 insertions(+)
>
> Can you rebase this on top of my for-mfd-next branc please?
>
Sure.


-- 
Thanks and Regards
Pramod