All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Manev <petermanev@gmail.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: John Fastabend <john.fastabend@gmail.com>,
	David Miller <davem@davemloft.net>, Eric Leblond <eric@regit.org>,
	Netdev <netdev@vger.kernel.org>,
	xdp-newbies@vger.kernel.org,
	Emil Tantilov <emil.s.tantilov@intel.com>
Subject: Re: ixgbe tuning reset when XDP is setup
Date: Wed, 21 Feb 2018 15:01:33 -0500	[thread overview]
Message-ID: <CAMhe82JhXWaO_30Ufd=jyQCqW2WkckYT6F=C5aHyyTbsNKtAuA@mail.gmail.com> (raw)
In-Reply-To: <CAKgT0UeMCpjq60ULZ7H8UEw+-hkB2nqBnroDQc8GGu56CY-83Q@mail.gmail.com>

>>
>> Hi,
>>
>> We were wondering if there is any follow up/potential solution for that?
>> If there is something we could help out testing with regards to that
>> - please let us know.
>>
>> Thank you
>>
>> --
>> Regards,
>> Peter Manev
>
> We don't have a solution available for this yet. Basically what it
> comes down to is that we have to change the driver code so that if
> assumes it is going to need to alloc Tx rings for XDP always, and then
> if it can't we have to disable the XDP feature. The current logic is
> to advertise the XDP feature, and then allocate the rings when XDP is
> actually used, and if that fails we fail to load the XDP program.
>
> Unfortunately I don't have an ETA for when we can get to that. It may
> be a while, however patches are always welcome.
>
> Thanks.
>
> - Alex

It seems the issue is not present on 4.15.2 (while it is in 4.13.10
for example) using the ixgbe available in tree
(/lib/modules/4.15.2-amd64/kernel/drivers/net/ethernet/intel/ixgbe)

Not sure what triggered the fix -  thought here would be a good place
to ask for some pointers.

Thank you

-- 
Regards,
Peter Manev

      reply	other threads:[~2018-02-21 20:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 10:24 ixgbe tuning reset when XDP is setup Eric Leblond
2017-12-15 15:53 ` David Miller
2017-12-15 16:03   ` John Fastabend
2017-12-15 16:51     ` Alexander Duyck
2017-12-15 16:56       ` Peter Manev
2018-01-25 13:09         ` Peter Manev
2018-01-25 15:07           ` Alexander Duyck
2018-02-21 20:01             ` Peter Manev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMhe82JhXWaO_30Ufd=jyQCqW2WkckYT6F=C5aHyyTbsNKtAuA@mail.gmail.com' \
    --to=petermanev@gmail.com \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=emil.s.tantilov@intel.com \
    --cc=eric@regit.org \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xdp-newbies@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.