Re: [PATCH 3/4] clk: ralink: make system controller node a reset provider

From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	 "open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	 linux-staging@lists.linux.dev, NeilBrown <neil@brown.name>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	John Crispin <john@phrozen.org>
Subject: Re: [PATCH 3/4] clk: ralink: make system controller node a reset provider
Date: Wed, 6 Oct 2021 12:20:24 +0200	[thread overview]
Message-ID: <CAMhs-H-isGf2Wq9FsnFPtGNK6gwObz39BC1ak-4DBXJjYebcNg@mail.gmail.com> (raw)
In-Reply-To: <20211006101458.GB2048@kadam>

On Wed, Oct 6, 2021 at 12:15 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Wed, Oct 06, 2021 at 12:02:12PM +0200, Sergio Paracuellos wrote:
> > Hi Dan,
> >
> > Thanks for the review. Comments below.
> >
> > On Wed, Oct 6, 2021 at 10:29 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > >
> > > On Wed, Oct 06, 2021 at 08:12:03AM +0200, Sergio Paracuellos wrote:
> > > > @@ -398,6 +401,76 @@ static void __init mt7621_clk_init(struct device_node *node)
> > > >  }
> > > >  CLK_OF_DECLARE_DRIVER(mt7621_clk, "mediatek,mt7621-sysc", mt7621_clk_init);
> > > >
> > > > +struct mt7621_rst {
> > > > +     struct reset_controller_dev rcdev;
> > > > +     struct regmap *sysc;
> > > > +};
> > > > +
> > > > +static inline struct mt7621_rst *to_mt7621_rst(struct reset_controller_dev *dev)
> > >
> > > No need to mark this as inline.  The compiler should do it automatically
> > > or it will ignore the inline.
> >
> > Ok, I have other functions to_* with the same inline syntax, that's
> > why I have added also here. I think I will maintain it to be coherent
> > and can be removed afterwards with another patch not belonging to this
> > series.
>
> Consistency is never an important goal.  It's better to be different
> than to be wrong.

Pretty clear, thanks. Will change this also, then.

>
> regards,
> dan carpenter
>

Best regards,
    Sergio Paracuellos