From: Sergio Paracuellos <sergio.paracuellos@gmail.com> To: Florian Fainelli <f.fainelli@gmail.com> Cc: Rob Herring <robh@kernel.org>, Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>, vivien.didelot@savoirfairelinux.com, driverdev-devel@linuxdriverproject.org, davem@davemloft.net, netdev@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode Date: Wed, 19 Dec 2018 20:49:19 +0100 [thread overview] Message-ID: <CAMhs-H8LMLquPEBa4w84OTWOdZGJwAaoMV9=psN2hNR+oeO46Q@mail.gmail.com> (raw) In-Reply-To: <538b1829-422a-bf15-b024-e0bf933c930a@gmail.com> On Wed, Dec 19, 2018 at 7:26 PM Florian Fainelli <f.fainelli@gmail.com> wrote: > > On 12/18/18 10:23 PM, Sergio Paracuellos wrote: > > Hi Rob, > > > > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@kernel.org> wrote: > >> > >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: > >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode. > >>> > >>> Cc: devicetree@vger.kernel.org > >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > >>> --- > >>> Changes v3: > >>> - No changes. Just resent patches together. > >>> > >>> Changes v2: > >>> - Use generic name for label of the switch and make sure reg and @X > >>> have the same value. > >>> > >>> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++ > >>> 1 file changed, 50 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt > >>> index 0f407fb371ce..d3c4b9d4f416 100644 > >>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt > >>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt > >>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0: > >>> }; > >>> }; > >>> }; > >>> + > >>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0: > >>> + > >>> + eth0: ethernet@10001000 { > >> > >> Why do we have all this indentation? Please remove. And use tab chars, > >> not spaces. > > > > The original file format is using all of this indentation. So I think > > we would need a patch to change de format of the original file and > > another with this new changes properly formatted. > > The original formatting should be fixed, but your changes should adopt > the correct style from the first time they are submitted. Do you mind > resubmitting with only one tab? We can fix the original examples as a > follow-up patch. I see. Thanks for let me know. I'll be more careful from now. v4 actually sent with changes proposed here. > > Thanks! > -- > Florian Best regards, Sergio Paracuellos
WARNING: multiple messages have this Message-ID (diff)
From: Sergio Paracuellos <sergio.paracuellos@gmail.com> To: Florian Fainelli <f.fainelli@gmail.com> Cc: Woojung.Huh@microchip.com, Rob Herring <robh@kernel.org>, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, driverdev-devel@linuxdriverproject.org, UNGLinuxDriver@microchip.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>, davem@davemloft.net Subject: Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode Date: Wed, 19 Dec 2018 20:49:19 +0100 [thread overview] Message-ID: <CAMhs-H8LMLquPEBa4w84OTWOdZGJwAaoMV9=psN2hNR+oeO46Q@mail.gmail.com> (raw) In-Reply-To: <538b1829-422a-bf15-b024-e0bf933c930a@gmail.com> On Wed, Dec 19, 2018 at 7:26 PM Florian Fainelli <f.fainelli@gmail.com> wrote: > > On 12/18/18 10:23 PM, Sergio Paracuellos wrote: > > Hi Rob, > > > > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@kernel.org> wrote: > >> > >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: > >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode. > >>> > >>> Cc: devicetree@vger.kernel.org > >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > >>> --- > >>> Changes v3: > >>> - No changes. Just resent patches together. > >>> > >>> Changes v2: > >>> - Use generic name for label of the switch and make sure reg and @X > >>> have the same value. > >>> > >>> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++ > >>> 1 file changed, 50 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt > >>> index 0f407fb371ce..d3c4b9d4f416 100644 > >>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt > >>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt > >>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0: > >>> }; > >>> }; > >>> }; > >>> + > >>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0: > >>> + > >>> + eth0: ethernet@10001000 { > >> > >> Why do we have all this indentation? Please remove. And use tab chars, > >> not spaces. > > > > The original file format is using all of this indentation. So I think > > we would need a patch to change de format of the original file and > > another with this new changes properly formatted. > > The original formatting should be fixed, but your changes should adopt > the correct style from the first time they are submitted. Do you mind > resubmitting with only one tab? We can fix the original examples as a > follow-up patch. I see. Thanks for let me know. I'll be more careful from now. v4 actually sent with changes proposed here. > > Thanks! > -- > Florian Best regards, Sergio Paracuellos _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-12-19 19:49 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-17 20:44 [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode Sergio Paracuellos 2018-12-17 20:44 ` Sergio Paracuellos 2018-12-17 22:22 ` Florian Fainelli 2018-12-17 22:22 ` Florian Fainelli 2018-12-18 6:32 ` Sergio Paracuellos 2018-12-18 6:32 ` Sergio Paracuellos 2018-12-18 15:10 ` Rob Herring 2018-12-18 15:10 ` Rob Herring 2018-12-19 6:23 ` Sergio Paracuellos 2018-12-19 6:23 ` Sergio Paracuellos 2018-12-19 18:26 ` Florian Fainelli 2018-12-19 18:26 ` Florian Fainelli 2018-12-19 19:49 ` Sergio Paracuellos [this message] 2018-12-19 19:49 ` Sergio Paracuellos
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMhs-H8LMLquPEBa4w84OTWOdZGJwAaoMV9=psN2hNR+oeO46Q@mail.gmail.com' \ --to=sergio.paracuellos@gmail.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=Woojung.Huh@microchip.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=driverdev-devel@linuxdriverproject.org \ --cc=f.fainelli@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=robh@kernel.org \ --cc=vivien.didelot@savoirfairelinux.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.