request for mt7621 SLUB boot fix for 6.1.y

request for mt7621 SLUB boot fix for 6.1.y

[John Thomson]

Hi stable team,

I would like to request for cherry picking to the linux-6.1.y branch:
19098934f910 ("PCI: mt7621: Add sentinel to quirks table")
a2cab953b4c0 ("mips: ralink: mt7621: define MT7621_SYSC_BASE with __iomem")
b4767d4c0725 ("mips: ralink: mt7621: soc queries and tests as functions")
7c18b64bba3b ("mips: ralink: mt7621: do not use kzalloc too early")


On the mips mt7621 SoC, a kzalloc is used too early and returns before reaching a soc_device_register.
soc_device_attribute->revision is used to identify MT7621 ver:1 eco:1 devices for a pci & phy-pci quirk.
A SLUB change in kernel 6.1 caused the device to fail to boot, rather than silently continue.

In fixing this, it was then seen that the pci & phy-pci drivers would oops,
as they were missing a sentinel in their soc_device_match quirks table.
The phy-pci fix has already been applied to stable.
The pci & early kzalloc fixes missed the 6.1rc window and are being taken for 6.2

In a quick web search I cannot find any reference to bootlogs for "ver:1 eco:1"
(which would use the quirk for PCI), so cannot see a current need to backport this
further than fixing the 6.1 boot error.

Link: https://lore.kernel.org/linux-mm/becf2ac3-2a90-4f3a-96d9-a70f67c66e4a@app.fastmail.com/
Link: https://lore.kernel.org/lkml/20221205204645.301301-1-git@johnthomson.fastmail.com.au/
Link: https://lore.kernel.org/lkml/20221114015658.2873120-1-git@johnthomson.fastmail.com.au/#t

cc'ed the maintainer, Sergio.


Thank you,

Cheers,
-- 
  John Thomson

Re: request for mt7621 SLUB boot fix for 6.1.y

[Sergio Paracuellos]

Hi John,

On Mon, Dec 19, 2022 at 7:53 AM John Thomson
<lists@johnthomson.fastmail.com.au> wrote:
>
> Hi stable team,
>
> I would like to request for cherry picking to the linux-6.1.y branch:
> 19098934f910 ("PCI: mt7621: Add sentinel to quirks table")
> a2cab953b4c0 ("mips: ralink: mt7621: define MT7621_SYSC_BASE with __iomem")
> b4767d4c0725 ("mips: ralink: mt7621: soc queries and tests as functions")
> 7c18b64bba3b ("mips: ralink: mt7621: do not use kzalloc too early")
>

I have tested all of these patches in the current tree for v6.2 and my
boards boot properly without issues now. I guess all of these will be
added to 6.1 when the merge window finishes.

Thanks,
    Sergio Paracuellos

Re: request for mt7621 SLUB boot fix for 6.1.y

[Greg KH]

On Mon, Dec 19, 2022 at 07:57:16AM +0100, Sergio Paracuellos wrote:
> Hi John,
> 
> On Mon, Dec 19, 2022 at 7:53 AM John Thomson
> <lists@johnthomson.fastmail.com.au> wrote:
> >
> > Hi stable team,
> >
> > I would like to request for cherry picking to the linux-6.1.y branch:
> > 19098934f910 ("PCI: mt7621: Add sentinel to quirks table")
> > a2cab953b4c0 ("mips: ralink: mt7621: define MT7621_SYSC_BASE with __iomem")
> > b4767d4c0725 ("mips: ralink: mt7621: soc queries and tests as functions")
> > 7c18b64bba3b ("mips: ralink: mt7621: do not use kzalloc too early")
> >
> 
> I have tested all of these patches in the current tree for v6.2 and my
> boards boot properly without issues now. I guess all of these will be
> added to 6.1 when the merge window finishes.

Now queued up, thanks.

greg k-h