All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-05  3:49 ` 'Wei Yongjun
  0 siblings, 0 replies; 12+ messages in thread
From: 'Wei Yongjun @ 2021-03-05  3:49 UTC (permalink / raw)
  To: weiyongjun1, Sergio Paracuellos, Kishon Vijay Abraham I,
	Vinod Koul, Matthias Brugger
  Cc: linux-phy, linux-arm-kernel, linux-mediatek, linux-kernel,
	kernel-janitors, Hulk Robot

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix the return value check which testing the wrong variable
in mt7621_pci_phy_probe().

Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c
index 84ee2b5c2228..753cb5bab930 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -319,9 +319,9 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
 		return PTR_ERR(phy->regmap);
 
 	phy->phy = devm_phy_create(dev, dev->of_node, &mt7621_pci_phy_ops);
-	if (IS_ERR(phy)) {
+	if (IS_ERR(phy->phy)) {
 		dev_err(dev, "failed to create phy\n");
-		return PTR_ERR(phy);
+		return PTR_ERR(phy->phy);
 	}
 
 	phy_set_drvdata(phy->phy, phy);


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-05  3:49 ` 'Wei Yongjun
  0 siblings, 0 replies; 12+ messages in thread
From: 'Wei Yongjun @ 2021-03-05  3:49 UTC (permalink / raw)
  To: weiyongjun1, Sergio Paracuellos, Kishon Vijay Abraham I,
	Vinod Koul, Matthias Brugger
  Cc: linux-phy, linux-arm-kernel, linux-mediatek, linux-kernel,
	kernel-janitors, Hulk Robot

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix the return value check which testing the wrong variable
in mt7621_pci_phy_probe().

Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c
index 84ee2b5c2228..753cb5bab930 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -319,9 +319,9 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
 		return PTR_ERR(phy->regmap);
 
 	phy->phy = devm_phy_create(dev, dev->of_node, &mt7621_pci_phy_ops);
-	if (IS_ERR(phy)) {
+	if (IS_ERR(phy->phy)) {
 		dev_err(dev, "failed to create phy\n");
-		return PTR_ERR(phy);
+		return PTR_ERR(phy->phy);
 	}
 
 	phy_set_drvdata(phy->phy, phy);


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-05  3:49 ` 'Wei Yongjun
  0 siblings, 0 replies; 12+ messages in thread
From: 'Wei Yongjun @ 2021-03-05  3:49 UTC (permalink / raw)
  To: weiyongjun1, Sergio Paracuellos, Kishon Vijay Abraham I,
	Vinod Koul, Matthias Brugger
  Cc: linux-phy, linux-arm-kernel, linux-mediatek, linux-kernel,
	kernel-janitors, Hulk Robot

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix the return value check which testing the wrong variable
in mt7621_pci_phy_probe().

Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c
index 84ee2b5c2228..753cb5bab930 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -319,9 +319,9 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
 		return PTR_ERR(phy->regmap);
 
 	phy->phy = devm_phy_create(dev, dev->of_node, &mt7621_pci_phy_ops);
-	if (IS_ERR(phy)) {
+	if (IS_ERR(phy->phy)) {
 		dev_err(dev, "failed to create phy\n");
-		return PTR_ERR(phy);
+		return PTR_ERR(phy->phy);
 	}
 
 	phy_set_drvdata(phy->phy, phy);


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-05  3:49 ` 'Wei Yongjun
  0 siblings, 0 replies; 12+ messages in thread
From: 'Wei Yongjun @ 2021-03-05  3:49 UTC (permalink / raw)
  To: weiyongjun1, Sergio Paracuellos, Kishon Vijay Abraham I,
	Vinod Koul, Matthias Brugger
  Cc: linux-phy, linux-arm-kernel, linux-mediatek, linux-kernel,
	kernel-janitors, Hulk Robot

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix the return value check which testing the wrong variable
in mt7621_pci_phy_probe().

Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c
index 84ee2b5c2228..753cb5bab930 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -319,9 +319,9 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
 		return PTR_ERR(phy->regmap);
 
 	phy->phy = devm_phy_create(dev, dev->of_node, &mt7621_pci_phy_ops);
-	if (IS_ERR(phy)) {
+	if (IS_ERR(phy->phy)) {
 		dev_err(dev, "failed to create phy\n");
-		return PTR_ERR(phy);
+		return PTR_ERR(phy->phy);
 	}
 
 	phy_set_drvdata(phy->phy, phy);


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
  2021-03-05  3:49 ` 'Wei Yongjun
  (?)
  (?)
@ 2021-03-05  4:59   ` Sergio Paracuellos
  -1 siblings, 0 replies; 12+ messages in thread
From: Sergio Paracuellos @ 2021-03-05  4:59 UTC (permalink / raw)
  To: 'Wei Yongjun
  Cc: Kishon Vijay Abraham I, Vinod Koul, Matthias Brugger, linux-phy,
	linux-arm-kernel, linux-mediatek, linux-kernel, kernel-janitors,
	Hulk Robot

On Fri, Mar 5, 2021 at 4:40 AM 'Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().
>
> Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-05  4:59   ` Sergio Paracuellos
  0 siblings, 0 replies; 12+ messages in thread
From: Sergio Paracuellos @ 2021-03-05  4:59 UTC (permalink / raw)
  To: 'Wei Yongjun
  Cc: Kishon Vijay Abraham I, Vinod Koul, Matthias Brugger, linux-phy,
	linux-arm-kernel, linux-mediatek, linux-kernel, kernel-janitors,
	Hulk Robot

On Fri, Mar 5, 2021 at 4:40 AM 'Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().
>
> Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-05  4:59   ` Sergio Paracuellos
  0 siblings, 0 replies; 12+ messages in thread
From: Sergio Paracuellos @ 2021-03-05  4:59 UTC (permalink / raw)
  To: 'Wei Yongjun
  Cc: Kishon Vijay Abraham I, Vinod Koul, Matthias Brugger, linux-phy,
	linux-arm-kernel, linux-mediatek, linux-kernel, kernel-janitors,
	Hulk Robot

On Fri, Mar 5, 2021 at 4:40 AM 'Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().
>
> Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-05  4:59   ` Sergio Paracuellos
  0 siblings, 0 replies; 12+ messages in thread
From: Sergio Paracuellos @ 2021-03-05  4:59 UTC (permalink / raw)
  To: 'Wei Yongjun
  Cc: Kishon Vijay Abraham I, Vinod Koul, Matthias Brugger, linux-phy,
	linux-arm-kernel, linux-mediatek, linux-kernel, kernel-janitors,
	Hulk Robot

On Fri, Mar 5, 2021 at 4:40 AM 'Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().
>
> Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
  2021-03-05  3:49 ` 'Wei Yongjun
  (?)
  (?)
@ 2021-03-15 10:18   ` Vinod Koul
  -1 siblings, 0 replies; 12+ messages in thread
From: Vinod Koul @ 2021-03-15 10:18 UTC (permalink / raw)
  To: 'Wei Yongjun
  Cc: Sergio Paracuellos, Kishon Vijay Abraham I, Matthias Brugger,
	linux-phy, linux-arm-kernel, linux-mediatek, linux-kernel,
	kernel-janitors, Hulk Robot

On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-15 10:18   ` Vinod Koul
  0 siblings, 0 replies; 12+ messages in thread
From: Vinod Koul @ 2021-03-15 10:18 UTC (permalink / raw)
  To: 'Wei Yongjun
  Cc: Sergio Paracuellos, Kishon Vijay Abraham I, Matthias Brugger,
	linux-phy, linux-arm-kernel, linux-mediatek, linux-kernel,
	kernel-janitors, Hulk Robot

On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().

Applied, thanks

-- 
~Vinod

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-15 10:18   ` Vinod Koul
  0 siblings, 0 replies; 12+ messages in thread
From: Vinod Koul @ 2021-03-15 10:18 UTC (permalink / raw)
  To: 'Wei Yongjun
  Cc: Sergio Paracuellos, Kishon Vijay Abraham I, Matthias Brugger,
	linux-phy, linux-arm-kernel, linux-mediatek, linux-kernel,
	kernel-janitors, Hulk Robot

On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().

Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
@ 2021-03-15 10:18   ` Vinod Koul
  0 siblings, 0 replies; 12+ messages in thread
From: Vinod Koul @ 2021-03-15 10:18 UTC (permalink / raw)
  To: 'Wei Yongjun
  Cc: Sergio Paracuellos, Kishon Vijay Abraham I, Matthias Brugger,
	linux-phy, linux-arm-kernel, linux-mediatek, linux-kernel,
	kernel-janitors, Hulk Robot

On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().

Applied, thanks

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-03-15 10:19 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05  3:49 [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe() 'Wei Yongjun
2021-03-05  3:49 ` 'Wei Yongjun
2021-03-05  3:49 ` 'Wei Yongjun
2021-03-05  3:49 ` 'Wei Yongjun
2021-03-05  4:59 ` Sergio Paracuellos
2021-03-05  4:59   ` Sergio Paracuellos
2021-03-05  4:59   ` Sergio Paracuellos
2021-03-05  4:59   ` Sergio Paracuellos
2021-03-15 10:18 ` Vinod Koul
2021-03-15 10:18   ` Vinod Koul
2021-03-15 10:18   ` Vinod Koul
2021-03-15 10:18   ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.