All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Brett Neumeier <bneumeier@gmail.com>
Cc: Neil Brown <neil@brown.name>,
	Greg KH <gregkh@linuxfoundation.org>,
	Greg Ungerer <gerg@kernel.org>,
	driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues
Date: Sun, 23 Jun 2019 07:58:51 +0200	[thread overview]
Message-ID: <CAMhs-H_c8sq=mX-rPRDHtkqyRj1fQcSNY_8M7Y5ZGU2FV9_zSA@mail.gmail.com> (raw)
In-Reply-To: <CAGSetNtcJkjnjO1Ftc01ueMuFMmJEv7HPpmQeSf313Rrbe2O5w@mail.gmail.com>

Hi Brett,

On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier <bneumeier@gmail.com> wrote:
>
> On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer <gerg@kernel.org> wrote:
> >
> > Hi Sergio,
> >
> > On 21/6/19 4:15 pm, Sergio Paracuellos wrote:
> > > This patch series properly handle minor issues in this driver. These are:
> > > * Disable pcie port clock on pci dirver instead of doing it in the phy
> > >    driver. The pci driver is the correct place to do this.
> > > * Add a missing call to phy_exit function to properly handle the function
> > >    'mt7621_pcie_init_port' error path.
> > > * Move driver to init in a later stage using 'module_init' instead of using
> > >    'arch_initcall'.
> > >
> > > Patches are only compile-tested. It would be awasome to be tested before applied
> > > them (mainly the change to 'module_init' stuff).
>
> I have similar results to Greg -- on GnuBee PC1 and PC2, six boot
> attempts each on a kernel built from staging-next, I have four hangs
> and eight successful boots. The hanging patterns are similar to
> previous results. If the full boot logs would be helpful let me know,
> I can provide them.

Thanks for letting me know. One thing we can try is check init order
in v4.20 kernel. Can you please try to compile pci driver for the
kernel v4.20 tag changing
driver's last line 'arch_initcall' into 'module_init'? Just to know if
at that working driver putting all the stuff in a later stage stills
work as expected.

Full dmesg's of this v4.20 wih the change would be helpful.

Best regards,
    Sergio Paracuellos

>
> --
> Brett Neumeier (bneumeier@gmail.com)
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2019-06-23  5:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  6:15 [PATCH 0/4] staging: mt7621-pci: Handle minor issues Sergio Paracuellos
2019-06-21  6:15 ` [PATCH 1/4] staging: mt7621-pci: disable pcie port clock if there is no pcie link Sergio Paracuellos
2019-06-21  6:15 ` [PATCH 2/4] staging: mt7621-pci: add phy exit call if phy_power_on call fails Sergio Paracuellos
2019-06-21  6:15 ` [PATCH 3/4] staging: mt7621-pci-phy: remove disable clock from the phy exit function Sergio Paracuellos
2019-06-21  6:15 ` [PATCH 4/4] staging: mt7621-pci: use 'module_init' instead of 'arch_initcall' Sergio Paracuellos
2019-06-21 12:35 ` [PATCH 0/4] staging: mt7621-pci: Handle minor issues Greg Ungerer
2019-06-21 13:23   ` Sergio Paracuellos
2019-06-23  2:15   ` Brett Neumeier
2019-06-23  5:58     ` Sergio Paracuellos [this message]
2019-06-25  5:10       ` Greg Ungerer
2019-06-25  5:18         ` Sergio Paracuellos
2019-06-25 12:47           ` Sergio Paracuellos
2019-06-26  3:31             ` Greg Ungerer
2019-06-26  7:10               ` Sergio Paracuellos
2019-06-26 12:18                 ` Greg Ungerer
2019-06-26 12:44                   ` Sergio Paracuellos
2019-07-05 18:43                     ` Brett Neumeier
2019-07-06  9:00                       ` Sergio Paracuellos
2019-07-06 13:43                         ` Brett Neumeier
2019-07-06 16:24                           ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMhs-H_c8sq=mX-rPRDHtkqyRj1fQcSNY_8M7Y5ZGU2FV9_zSA@mail.gmail.com' \
    --to=sergio.paracuellos@gmail.com \
    --cc=bneumeier@gmail.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gerg@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=neil@brown.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.