From: Ard Biesheuvel <ardb@kernel.org>
To: "Chen, Rong A" <rong.a.chen@intel.com>
Cc: Marc Zyngier <maz@kernel.org>,
Kalesh Singh <kaleshsingh@google.com>,
kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
Will Deacon <will@kernel.org>,
Quentin Perret <qperret@google.com>,
Fuad Tabba <tabba@google.com>,
Suren Baghdasaryan <surenb@google.com>,
Android Kernel Team <kernel-team@android.com>,
Catalin Marinas <catalin.marinas@arm.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Joey Gouly <joey.gouly@arm.com>,
Peter Collingbourne <pcc@google.com>,
Andrew Scull <ascull@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvmarm <kvmarm@lists.cs.columbia.edu>
Subject: Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
Date: Fri, 25 Feb 2022 16:38:10 +0100 [thread overview]
Message-ID: <CAMj1kXEfsxj44t13rpgNddvTeM3qgfv5zU_xpnxn7HV3xUN2YA@mail.gmail.com> (raw)
In-Reply-To: <16f47fa9-90b4-0b5c-33cb-cb004fc39266@intel.com>
On Fri, 25 Feb 2022 at 03:12, Chen, Rong A <rong.a.chen@intel.com> wrote:
>
>
>
> Hi Marc, Ard,
>
> We have ignored the warning related to asmlinkage according to the below
> advice:
>
> https://lore.kernel.org/lkml/CAMj1kXHrRYagSVniSetHdG15rkQS+fm4zVOtN=Zda3W0QaEoJA@mail.gmail.com/
>
Excellent! Thanks for implementing this - I wasn't aware that you
adopted this suggestion.
> do you want the bot ignore such warning if asmlinkage not specified?
>
Even though I think this warning has little value, I think asmlinkage
is sufficient for us to avoid it for symbols that are exported for use
by assembler code.
So I don't think this additional change is needed.
--
Ard.
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: "Chen, Rong A" <rong.a.chen@intel.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
llvm@lists.linux.dev, Joey Gouly <joey.gouly@arm.com>,
Kalesh Singh <kaleshsingh@google.com>,
Will Deacon <will@kernel.org>,
kvmarm <kvmarm@lists.cs.columbia.edu>,
kernel test robot <lkp@intel.com>, Marc Zyngier <maz@kernel.org>,
Android Kernel Team <kernel-team@android.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Suren Baghdasaryan <surenb@google.com>,
Peter Collingbourne <pcc@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
kbuild-all@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
Date: Fri, 25 Feb 2022 16:38:10 +0100 [thread overview]
Message-ID: <CAMj1kXEfsxj44t13rpgNddvTeM3qgfv5zU_xpnxn7HV3xUN2YA@mail.gmail.com> (raw)
In-Reply-To: <16f47fa9-90b4-0b5c-33cb-cb004fc39266@intel.com>
On Fri, 25 Feb 2022 at 03:12, Chen, Rong A <rong.a.chen@intel.com> wrote:
>
>
>
> Hi Marc, Ard,
>
> We have ignored the warning related to asmlinkage according to the below
> advice:
>
> https://lore.kernel.org/lkml/CAMj1kXHrRYagSVniSetHdG15rkQS+fm4zVOtN=Zda3W0QaEoJA@mail.gmail.com/
>
Excellent! Thanks for implementing this - I wasn't aware that you
adopted this suggestion.
> do you want the bot ignore such warning if asmlinkage not specified?
>
Even though I think this warning has little value, I think asmlinkage
is sufficient for us to avoid it for symbols that are exported for use
by assembler code.
So I don't think this additional change is needed.
--
Ard.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: "Chen, Rong A" <rong.a.chen@intel.com>
Cc: Marc Zyngier <maz@kernel.org>,
Kalesh Singh <kaleshsingh@google.com>,
kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
Will Deacon <will@kernel.org>,
Quentin Perret <qperret@google.com>,
Fuad Tabba <tabba@google.com>,
Suren Baghdasaryan <surenb@google.com>,
Android Kernel Team <kernel-team@android.com>,
Catalin Marinas <catalin.marinas@arm.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Joey Gouly <joey.gouly@arm.com>,
Peter Collingbourne <pcc@google.com>,
Andrew Scull <ascull@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvmarm <kvmarm@lists.cs.columbia.edu>
Subject: Re: [kbuild-all] Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
Date: Fri, 25 Feb 2022 16:38:10 +0100 [thread overview]
Message-ID: <CAMj1kXEfsxj44t13rpgNddvTeM3qgfv5zU_xpnxn7HV3xUN2YA@mail.gmail.com> (raw)
In-Reply-To: <16f47fa9-90b4-0b5c-33cb-cb004fc39266@intel.com>
On Fri, 25 Feb 2022 at 03:12, Chen, Rong A <rong.a.chen@intel.com> wrote:
>
>
>
> Hi Marc, Ard,
>
> We have ignored the warning related to asmlinkage according to the below
> advice:
>
> https://lore.kernel.org/lkml/CAMj1kXHrRYagSVniSetHdG15rkQS+fm4zVOtN=Zda3W0QaEoJA@mail.gmail.com/
>
Excellent! Thanks for implementing this - I wasn't aware that you
adopted this suggestion.
> do you want the bot ignore such warning if asmlinkage not specified?
>
Even though I think this warning has little value, I think asmlinkage
is sufficient for us to avoid it for symbols that are exported for use
by assembler code.
So I don't think this additional change is needed.
--
Ard.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows
Date: Fri, 25 Feb 2022 16:38:10 +0100 [thread overview]
Message-ID: <CAMj1kXEfsxj44t13rpgNddvTeM3qgfv5zU_xpnxn7HV3xUN2YA@mail.gmail.com> (raw)
In-Reply-To: <16f47fa9-90b4-0b5c-33cb-cb004fc39266@intel.com>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Fri, 25 Feb 2022 at 03:12, Chen, Rong A <rong.a.chen@intel.com> wrote:
>
>
>
> Hi Marc, Ard,
>
> We have ignored the warning related to asmlinkage according to the below
> advice:
>
> https://lore.kernel.org/lkml/CAMj1kXHrRYagSVniSetHdG15rkQS+fm4zVOtN=Zda3W0QaEoJA(a)mail.gmail.com/
>
Excellent! Thanks for implementing this - I wasn't aware that you
adopted this suggestion.
> do you want the bot ignore such warning if asmlinkage not specified?
>
Even though I think this warning has little value, I think asmlinkage
is sufficient for us to avoid it for symbols that are exported for use
by assembler code.
So I don't think this additional change is needed.
--
Ard.
next prev parent reply other threads:[~2022-02-25 15:38 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 16:51 [PATCH v2 0/9] KVM: arm64: Hypervisor stack enhancements Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` [PATCH v2 1/9] KVM: arm64: Introduce hyp_alloc_private_va_range() Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 18:53 ` Mark Rutland
2022-02-22 18:53 ` Mark Rutland
2022-02-22 18:53 ` Mark Rutland
2022-02-22 16:51 ` [PATCH v2 2/9] KVM: arm64: Introduce pkvm_alloc_private_va_range() Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` [PATCH v2 3/9] KVM: arm64: Add guard pages for KVM nVHE hypervisor stack Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` [PATCH v2 4/9] KVM: arm64: Add guard pages for pKVM (protected nVHE) " Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 18:55 ` Mark Rutland
2022-02-22 18:55 ` Mark Rutland
2022-02-22 18:55 ` Mark Rutland
2022-02-22 20:30 ` Kalesh Singh
2022-02-22 20:30 ` Kalesh Singh
2022-02-22 20:30 ` Kalesh Singh
2022-02-22 16:51 ` [PATCH v2 5/9] arm64: asm: Introduce test_sp_overflow macro Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 18:32 ` Mark Rutland
2022-02-22 18:32 ` Mark Rutland
2022-02-22 18:32 ` Mark Rutland
2022-02-22 20:20 ` Kalesh Singh
2022-02-22 20:20 ` Kalesh Singh
2022-02-22 20:20 ` Kalesh Singh
2022-02-22 16:51 ` [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-23 2:04 ` kernel test robot
2022-02-23 2:04 ` kernel test robot
2022-02-23 2:04 ` kernel test robot
2022-02-23 9:05 ` kernel test robot
2022-02-23 9:05 ` kernel test robot
2022-02-23 9:05 ` kernel test robot
2022-02-23 9:16 ` Marc Zyngier
2022-02-23 9:16 ` Marc Zyngier
2022-02-23 9:16 ` Marc Zyngier
2022-02-23 9:16 ` Marc Zyngier
2022-02-23 12:34 ` [kbuild-all] " Philip Li
2022-02-23 12:34 ` Philip Li
2022-02-23 12:34 ` Philip Li
2022-02-23 12:54 ` Marc Zyngier
2022-02-23 12:54 ` Marc Zyngier
2022-02-23 12:54 ` [kbuild-all] " Marc Zyngier
2022-02-23 12:54 ` Marc Zyngier
2022-02-23 12:56 ` Ard Biesheuvel
2022-02-23 12:56 ` Ard Biesheuvel
2022-02-23 12:56 ` [kbuild-all] " Ard Biesheuvel
2022-02-23 12:56 ` Ard Biesheuvel
2022-02-24 10:39 ` Marc Zyngier
2022-02-24 10:39 ` Marc Zyngier
2022-02-24 10:39 ` [kbuild-all] " Marc Zyngier
2022-02-24 10:39 ` Marc Zyngier
2022-02-25 2:12 ` Chen, Rong A
2022-02-25 2:12 ` Chen, Rong A
2022-02-25 2:12 ` Chen, Rong A
2022-02-25 3:11 ` Kalesh Singh
2022-02-25 3:11 ` Kalesh Singh
2022-02-25 3:11 ` [kbuild-all] " Kalesh Singh
2022-02-25 3:11 ` Kalesh Singh
2022-02-25 15:31 ` Marc Zyngier
2022-02-25 15:31 ` Marc Zyngier
2022-02-25 15:31 ` [kbuild-all] " Marc Zyngier
2022-02-25 15:31 ` Marc Zyngier
2022-02-25 15:38 ` Ard Biesheuvel [this message]
2022-02-25 15:38 ` Ard Biesheuvel
2022-02-25 15:38 ` [kbuild-all] " Ard Biesheuvel
2022-02-25 15:38 ` Ard Biesheuvel
2022-02-22 16:51 ` [PATCH v2 7/9] KVM: arm64: Add hypervisor overflow stack Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` [PATCH v2 8/9] KVM: arm64: Unwind and dump nVHE HYP stacktrace Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` [PATCH v2 9/9] KVM: arm64: Symbolize the nVHE HYP backtrace Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
2022-02-22 16:51 ` Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEfsxj44t13rpgNddvTeM3qgfv5zU_xpnxn7HV3xUN2YA@mail.gmail.com \
--to=ardb@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=ascull@google.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=kaleshsingh@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pbonzini@redhat.com \
--cc=pcc@google.com \
--cc=qperret@google.com \
--cc=rong.a.chen@intel.com \
--cc=surenb@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.