All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Chen Baozi <cbz@baozis.org>, Marc Zyngier <maz@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type
Date: Tue, 17 Nov 2020 09:46:49 +0100	[thread overview]
Message-ID: <CAMj1kXF+QoUwCdG=HL6Geyv8mxPTZF4PqEiFCXZm2kFQDC4N+Q@mail.gmail.com> (raw)
In-Reply-To: <20201117032015.11805-1-cbz@baozis.org>

(+ Marc)

On Tue, 17 Nov 2020 at 04:20, Chen Baozi <cbz@baozis.org> wrote:
>
> From: Chen Baozi <chenbaozi@phytium.com.cn>
>
> Since fwspec->param_count of ACPI node is two, the index of IRQ type
> in fwspec->param[] should be 1 rather than 2.
>
> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
> ---
>  drivers/irqchip/irq-sni-exiu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
> index 1d027623c776..abd011fcecf4 100644
> --- a/drivers/irqchip/irq-sni-exiu.c
> +++ b/drivers/irqchip/irq-sni-exiu.c
> @@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
>                 if (fwspec->param_count != 2)
>                         return -EINVAL;
>                 *hwirq = fwspec->param[0];
> -               *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
> +               *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
>         }
>         return 0;
>  }
> --
> 2.28.0
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: Chen Baozi <cbz@baozis.org>, Marc Zyngier <maz@kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type
Date: Tue, 17 Nov 2020 09:46:49 +0100	[thread overview]
Message-ID: <CAMj1kXF+QoUwCdG=HL6Geyv8mxPTZF4PqEiFCXZm2kFQDC4N+Q@mail.gmail.com> (raw)
In-Reply-To: <20201117032015.11805-1-cbz@baozis.org>

(+ Marc)

On Tue, 17 Nov 2020 at 04:20, Chen Baozi <cbz@baozis.org> wrote:
>
> From: Chen Baozi <chenbaozi@phytium.com.cn>
>
> Since fwspec->param_count of ACPI node is two, the index of IRQ type
> in fwspec->param[] should be 1 rather than 2.
>
> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
> ---
>  drivers/irqchip/irq-sni-exiu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
> index 1d027623c776..abd011fcecf4 100644
> --- a/drivers/irqchip/irq-sni-exiu.c
> +++ b/drivers/irqchip/irq-sni-exiu.c
> @@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
>                 if (fwspec->param_count != 2)
>                         return -EINVAL;
>                 *hwirq = fwspec->param[0];
> -               *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
> +               *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
>         }
>         return 0;
>  }
> --
> 2.28.0
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-17  8:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17  3:20 [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type Chen Baozi
2020-11-17  8:46 ` Ard Biesheuvel [this message]
2020-11-17  8:46   ` Ard Biesheuvel
2020-11-22 12:49 ` Marc Zyngier
2020-11-23 16:45 ` [irqchip: irq/irqchip-next] " irqchip-bot for Chen Baozi
  -- strict thread matches above, loose matches on Subject: below --
2020-11-17  3:18 [PATCH] " Chen Baozi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXF+QoUwCdG=HL6Geyv8mxPTZF4PqEiFCXZm2kFQDC4N+Q@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=cbz@baozis.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.