From: Ard Biesheuvel <ardb@kernel.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Atish Patra <Atish.Patra@wdc.com>, Will Deacon <will@kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-riscv <linux-riscv@lists.infradead.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [v2 PATCH 1/5] efi: Move arm-stub to a common file
Date: Sat, 25 Apr 2020 11:54:59 +0200 [thread overview]
Message-ID: <CAMj1kXHNcyVnEsB71KPjZEcPuCT9KCctbOJW8nOC5uy2GYLtLA@mail.gmail.com> (raw)
In-Reply-To: <8bf726ff-2f25-e8ba-17c7-2abf450b7c72@gmx.de>
On Sat, 25 Apr 2020 at 11:48, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 4/21/20 9:19 PM, Palmer Dabbelt wrote:
> > On Mon, 13 Apr 2020 14:29:03 PDT (-0700), Atish Patra wrote:
> >> Most of the arm-stub code is written in an architecture independent
> >> manner.
> >> As a result, RISC-V can reuse most of the arm-stub code.
> >>
> >> Rename the arm-stub.c to efi-stub.c so that ARM, ARM64 and RISC-V can
> >> use it.
> >> This patch doesn't introduce any functional changes.
> >>
> >> Signed-off-by: Atish Patra <atish.patra@wdc.com>
>
> The code being moved has some problems:
>
> The ARM stub ignores the return value of efi_setup_gop().
>
> drivers/firmware/efi/libstub/arm-stub.c and
> drivers/firmware/efi/libstub/x86-stub.c both call LocateHandle() before
> calling efi_setup_gop(). I think this should be moved to efi_setup_gop().
>
> I guess the issues can be addressed in some follow up patch.
>
Yes, I suppose this could be improved a bit, so patches welcome, as usual :-)
But I don't think it has any bearing on a patch that renames the file.
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: linux-efi <linux-efi@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
Atish Patra <Atish.Patra@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Will Deacon <will@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [v2 PATCH 1/5] efi: Move arm-stub to a common file
Date: Sat, 25 Apr 2020 11:54:59 +0200 [thread overview]
Message-ID: <CAMj1kXHNcyVnEsB71KPjZEcPuCT9KCctbOJW8nOC5uy2GYLtLA@mail.gmail.com> (raw)
In-Reply-To: <8bf726ff-2f25-e8ba-17c7-2abf450b7c72@gmx.de>
On Sat, 25 Apr 2020 at 11:48, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 4/21/20 9:19 PM, Palmer Dabbelt wrote:
> > On Mon, 13 Apr 2020 14:29:03 PDT (-0700), Atish Patra wrote:
> >> Most of the arm-stub code is written in an architecture independent
> >> manner.
> >> As a result, RISC-V can reuse most of the arm-stub code.
> >>
> >> Rename the arm-stub.c to efi-stub.c so that ARM, ARM64 and RISC-V can
> >> use it.
> >> This patch doesn't introduce any functional changes.
> >>
> >> Signed-off-by: Atish Patra <atish.patra@wdc.com>
>
> The code being moved has some problems:
>
> The ARM stub ignores the return value of efi_setup_gop().
>
> drivers/firmware/efi/libstub/arm-stub.c and
> drivers/firmware/efi/libstub/x86-stub.c both call LocateHandle() before
> calling efi_setup_gop(). I think this should be moved to efi_setup_gop().
>
> I guess the issues can be addressed in some follow up patch.
>
Yes, I suppose this could be improved a bit, so patches welcome, as usual :-)
But I don't think it has any bearing on a patch that renames the file.
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: linux-efi <linux-efi@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
Atish Patra <Atish.Patra@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Will Deacon <will@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [v2 PATCH 1/5] efi: Move arm-stub to a common file
Date: Sat, 25 Apr 2020 11:54:59 +0200 [thread overview]
Message-ID: <CAMj1kXHNcyVnEsB71KPjZEcPuCT9KCctbOJW8nOC5uy2GYLtLA@mail.gmail.com> (raw)
In-Reply-To: <8bf726ff-2f25-e8ba-17c7-2abf450b7c72@gmx.de>
On Sat, 25 Apr 2020 at 11:48, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 4/21/20 9:19 PM, Palmer Dabbelt wrote:
> > On Mon, 13 Apr 2020 14:29:03 PDT (-0700), Atish Patra wrote:
> >> Most of the arm-stub code is written in an architecture independent
> >> manner.
> >> As a result, RISC-V can reuse most of the arm-stub code.
> >>
> >> Rename the arm-stub.c to efi-stub.c so that ARM, ARM64 and RISC-V can
> >> use it.
> >> This patch doesn't introduce any functional changes.
> >>
> >> Signed-off-by: Atish Patra <atish.patra@wdc.com>
>
> The code being moved has some problems:
>
> The ARM stub ignores the return value of efi_setup_gop().
>
> drivers/firmware/efi/libstub/arm-stub.c and
> drivers/firmware/efi/libstub/x86-stub.c both call LocateHandle() before
> calling efi_setup_gop(). I think this should be moved to efi_setup_gop().
>
> I guess the issues can be addressed in some follow up patch.
>
Yes, I suppose this could be improved a bit, so patches welcome, as usual :-)
But I don't think it has any bearing on a patch that renames the file.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-25 9:55 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:29 [v2 PATCH 0/5] Add UEFI support for RISC-V Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-13 21:29 ` [v2 PATCH 1/5] efi: Move arm-stub to a common file Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-25 9:47 ` Heinrich Schuchardt
2020-04-25 9:47 ` Heinrich Schuchardt
2020-04-25 9:47 ` Heinrich Schuchardt
2020-04-25 9:54 ` Ard Biesheuvel [this message]
2020-04-25 9:54 ` Ard Biesheuvel
2020-04-25 9:54 ` Ard Biesheuvel
2020-04-13 21:29 ` [v2 PATCH 2/5] include: pe.h: Add RISC-V related PE definition Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-13 21:29 ` [v2 PATCH 3/5] RISC-V: Define fixmap bindings for generic early ioremap support Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-21 19:19 ` Palmer Dabbelt
2020-04-13 21:29 ` [v2 PATCH 4/5] RISC-V: Add PE/COFF header for EFI stub Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-13 21:29 ` [v2 PATCH 5/5] RISC-V: Add EFI stub support Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-13 21:29 ` Atish Patra
2020-04-14 0:20 ` kbuild test robot
2020-04-14 0:20 ` kbuild test robot
2020-04-14 1:28 ` kbuild test robot
2020-04-14 1:28 ` kbuild test robot
2020-04-14 7:41 ` Ard Biesheuvel
2020-04-14 7:41 ` Ard Biesheuvel
2020-04-14 7:41 ` Ard Biesheuvel
2020-04-15 0:10 ` Atish Patra
2020-04-15 0:10 ` Atish Patra
2020-04-15 0:10 ` Atish Patra
2020-04-15 7:38 ` Ard Biesheuvel
2020-04-15 7:38 ` Ard Biesheuvel
2020-04-15 7:38 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXHNcyVnEsB71KPjZEcPuCT9KCctbOJW8nOC5uy2GYLtLA@mail.gmail.com \
--to=ardb@kernel.org \
--cc=Atish.Patra@wdc.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=masahiroy@kernel.org \
--cc=mingo@kernel.org \
--cc=palmer@dabbelt.com \
--cc=will@kernel.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.