All of lore.kernel.org
 help / color / mirror / Atom feed
* crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd'
@ 2021-02-27 19:14 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-02-27 19:14 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: kbuild-all, linux-kernel, Herbert Xu, Ondrej Mosnacek

[-- Attachment #1: Type: text/plain, Size: 4443 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
commit: a4397635afea5d127548d64e0055ed471ef2d5be crypto: aegis128 - provide a SIMD implementation based on NEON intrinsics
date:   1 year, 6 months ago
config: arm64-randconfig-r035-20210226 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a4397635afea5d127548d64e0055ed471ef2d5be
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout a4397635afea5d127548d64e0055ed471ef2d5be
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd' [-Wmissing-prototypes]
      17 | bool crypto_aegis128_have_simd(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon.c:22:6: warning: no previous prototype for 'crypto_aegis128_update_simd' [-Wmissing-prototypes]
      22 | void crypto_aegis128_update_simd(union aegis_block *state, const void *msg)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon.c:29:6: warning: no previous prototype for 'crypto_aegis128_encrypt_chunk_simd' [-Wmissing-prototypes]
      29 | void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon.c:37:6: warning: no previous prototype for 'crypto_aegis128_decrypt_chunk_simd' [-Wmissing-prototypes]
      37 | void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from crypto/aegis128-neon.c:9:
   crypto/aegis.h:27:32: warning: 'crypto_aegis_const' defined but not used [-Wunused-const-variable=]
      27 | static const union aegis_block crypto_aegis_const[2] = {
         |                                ^~~~~~~~~~~~~~~~~~
--
>> crypto/aegis128-neon-inner.c:76:6: warning: no previous prototype for 'crypto_aegis128_update_neon' [-Wmissing-prototypes]
      76 | void crypto_aegis128_update_neon(void *state, const void *msg)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon-inner.c:85:6: warning: no previous prototype for 'crypto_aegis128_encrypt_chunk_neon' [-Wmissing-prototypes]
      85 | void crypto_aegis128_encrypt_chunk_neon(void *state, void *dst, const void *src,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon-inner.c:117:6: warning: no previous prototype for 'crypto_aegis128_decrypt_chunk_neon' [-Wmissing-prototypes]
     117 | void crypto_aegis128_decrypt_chunk_neon(void *state, void *dst, const void *src,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/crypto_aegis128_have_simd +17 crypto/aegis128-neon.c

    10	
    11	void crypto_aegis128_update_neon(void *state, const void *msg);
    12	void crypto_aegis128_encrypt_chunk_neon(void *state, void *dst, const void *src,
    13						unsigned int size);
    14	void crypto_aegis128_decrypt_chunk_neon(void *state, void *dst, const void *src,
    15						unsigned int size);
    16	
  > 17	bool crypto_aegis128_have_simd(void)
    18	{
    19		return cpu_have_feature(cpu_feature(AES));
    20	}
    21	
  > 22	void crypto_aegis128_update_simd(union aegis_block *state, const void *msg)
    23	{
    24		kernel_neon_begin();
    25		crypto_aegis128_update_neon(state, msg);
    26		kernel_neon_end();
    27	}
    28	
  > 29	void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
    30						const u8 *src, unsigned int size)
    31	{
    32		kernel_neon_begin();
    33		crypto_aegis128_encrypt_chunk_neon(state, dst, src, size);
    34		kernel_neon_end();
    35	}
    36	
  > 37	void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33938 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd'
@ 2021-02-27 19:14 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-02-27 19:14 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4528 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
commit: a4397635afea5d127548d64e0055ed471ef2d5be crypto: aegis128 - provide a SIMD implementation based on NEON intrinsics
date:   1 year, 6 months ago
config: arm64-randconfig-r035-20210226 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a4397635afea5d127548d64e0055ed471ef2d5be
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout a4397635afea5d127548d64e0055ed471ef2d5be
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd' [-Wmissing-prototypes]
      17 | bool crypto_aegis128_have_simd(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon.c:22:6: warning: no previous prototype for 'crypto_aegis128_update_simd' [-Wmissing-prototypes]
      22 | void crypto_aegis128_update_simd(union aegis_block *state, const void *msg)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon.c:29:6: warning: no previous prototype for 'crypto_aegis128_encrypt_chunk_simd' [-Wmissing-prototypes]
      29 | void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon.c:37:6: warning: no previous prototype for 'crypto_aegis128_decrypt_chunk_simd' [-Wmissing-prototypes]
      37 | void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from crypto/aegis128-neon.c:9:
   crypto/aegis.h:27:32: warning: 'crypto_aegis_const' defined but not used [-Wunused-const-variable=]
      27 | static const union aegis_block crypto_aegis_const[2] = {
         |                                ^~~~~~~~~~~~~~~~~~
--
>> crypto/aegis128-neon-inner.c:76:6: warning: no previous prototype for 'crypto_aegis128_update_neon' [-Wmissing-prototypes]
      76 | void crypto_aegis128_update_neon(void *state, const void *msg)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon-inner.c:85:6: warning: no previous prototype for 'crypto_aegis128_encrypt_chunk_neon' [-Wmissing-prototypes]
      85 | void crypto_aegis128_encrypt_chunk_neon(void *state, void *dst, const void *src,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/aegis128-neon-inner.c:117:6: warning: no previous prototype for 'crypto_aegis128_decrypt_chunk_neon' [-Wmissing-prototypes]
     117 | void crypto_aegis128_decrypt_chunk_neon(void *state, void *dst, const void *src,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/crypto_aegis128_have_simd +17 crypto/aegis128-neon.c

    10	
    11	void crypto_aegis128_update_neon(void *state, const void *msg);
    12	void crypto_aegis128_encrypt_chunk_neon(void *state, void *dst, const void *src,
    13						unsigned int size);
    14	void crypto_aegis128_decrypt_chunk_neon(void *state, void *dst, const void *src,
    15						unsigned int size);
    16	
  > 17	bool crypto_aegis128_have_simd(void)
    18	{
    19		return cpu_have_feature(cpu_feature(AES));
    20	}
    21	
  > 22	void crypto_aegis128_update_simd(union aegis_block *state, const void *msg)
    23	{
    24		kernel_neon_begin();
    25		crypto_aegis128_update_neon(state, msg);
    26		kernel_neon_end();
    27	}
    28	
  > 29	void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
    30						const u8 *src, unsigned int size)
    31	{
    32		kernel_neon_begin();
    33		crypto_aegis128_encrypt_chunk_neon(state, dst, src, size);
    34		kernel_neon_end();
    35	}
    36	
  > 37	void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33938 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] crypto: aegis128 - Move simd prototypes into aegis.h
  2021-02-27 19:14 ` kernel test robot
@ 2021-03-08  5:41   ` Herbert Xu
  -1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2021-03-08  5:41 UTC (permalink / raw)
  To: kernel test robot
  Cc: Ard Biesheuvel, kbuild-all, linux-kernel, Ondrej Mosnacek,
	Linux Crypto Mailing List

On Sun, Feb 28, 2021 at 03:14:55AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
> commit: a4397635afea5d127548d64e0055ed471ef2d5be crypto: aegis128 - provide a SIMD implementation based on NEON intrinsics
> date:   1 year, 6 months ago
> config: arm64-randconfig-r035-20210226 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a4397635afea5d127548d64e0055ed471ef2d5be
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout a4397635afea5d127548d64e0055ed471ef2d5be
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd' [-Wmissing-prototypes]
>       17 | bool crypto_aegis128_have_simd(void)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~~

---8<---
This patch fixes missing prototype warnings in crypto/aegis128-neon.c.

Fixes: a4397635afea ("crypto: aegis128 - provide a SIMD...")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/crypto/aegis.h b/crypto/aegis.h
index 6920ebe77679..6ef9c174c973 100644
--- a/crypto/aegis.h
+++ b/crypto/aegis.h
@@ -21,9 +21,28 @@ union aegis_block {
 	u8 bytes[AEGIS_BLOCK_SIZE];
 };
 
+struct aegis_state;
+
+extern int aegis128_have_aes_insn;
+
 #define AEGIS_BLOCK_ALIGN (__alignof__(union aegis_block))
 #define AEGIS_ALIGNED(p) IS_ALIGNED((uintptr_t)p, AEGIS_BLOCK_ALIGN)
 
+bool crypto_aegis128_have_simd(void);
+void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg);
+void crypto_aegis128_init_simd(struct aegis_state *state,
+			       const union aegis_block *key,
+			       const u8 *iv);
+void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
+					const u8 *src, unsigned int size);
+void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
+					const u8 *src, unsigned int size);
+int crypto_aegis128_final_simd(struct aegis_state *state,
+			       union aegis_block *tag_xor,
+			       unsigned int assoclen,
+			       unsigned int cryptlen,
+			       unsigned int authsize);
+
 static __always_inline void crypto_aegis_block_xor(union aegis_block *dst,
 						   const union aegis_block *src)
 {
diff --git a/crypto/aegis128-core.c b/crypto/aegis128-core.c
index 89dc1c559689..c4f1bfa1d04f 100644
--- a/crypto/aegis128-core.c
+++ b/crypto/aegis128-core.c
@@ -58,21 +58,6 @@ static bool aegis128_do_simd(void)
 	return false;
 }
 
-bool crypto_aegis128_have_simd(void);
-void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg);
-void crypto_aegis128_init_simd(struct aegis_state *state,
-			       const union aegis_block *key,
-			       const u8 *iv);
-void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
-					const u8 *src, unsigned int size);
-void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
-					const u8 *src, unsigned int size);
-int crypto_aegis128_final_simd(struct aegis_state *state,
-			       union aegis_block *tag_xor,
-			       unsigned int assoclen,
-			       unsigned int cryptlen,
-			       unsigned int authsize);
-
 static void crypto_aegis128_update(struct aegis_state *state)
 {
 	union aegis_block tmp;
diff --git a/crypto/aegis128-neon.c b/crypto/aegis128-neon.c
index 94d591a002a4..a7856915ec85 100644
--- a/crypto/aegis128-neon.c
+++ b/crypto/aegis128-neon.c
@@ -30,7 +30,7 @@ bool crypto_aegis128_have_simd(void)
 	return IS_ENABLED(CONFIG_ARM64);
 }
 
-void crypto_aegis128_init_simd(union aegis_block *state,
+void crypto_aegis128_init_simd(struct aegis_state *state,
 			       const union aegis_block *key,
 			       const u8 *iv)
 {
@@ -39,14 +39,14 @@ void crypto_aegis128_init_simd(union aegis_block *state,
 	kernel_neon_end();
 }
 
-void crypto_aegis128_update_simd(union aegis_block *state, const void *msg)
+void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg)
 {
 	kernel_neon_begin();
 	crypto_aegis128_update_neon(state, msg);
 	kernel_neon_end();
 }
 
-void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
+void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
 					const u8 *src, unsigned int size)
 {
 	kernel_neon_begin();
@@ -54,7 +54,7 @@ void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
 	kernel_neon_end();
 }
 
-void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
+void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
 					const u8 *src, unsigned int size)
 {
 	kernel_neon_begin();
@@ -62,7 +62,7 @@ void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
 	kernel_neon_end();
 }
 
-int crypto_aegis128_final_simd(union aegis_block *state,
+int crypto_aegis128_final_simd(struct aegis_state *state,
 			       union aegis_block *tag_xor,
 			       unsigned int assoclen,
 			       unsigned int cryptlen,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] crypto: aegis128 - Move simd prototypes into aegis.h
@ 2021-03-08  5:41   ` Herbert Xu
  0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2021-03-08  5:41 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 5942 bytes --]

On Sun, Feb 28, 2021 at 03:14:55AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
> commit: a4397635afea5d127548d64e0055ed471ef2d5be crypto: aegis128 - provide a SIMD implementation based on NEON intrinsics
> date:   1 year, 6 months ago
> config: arm64-randconfig-r035-20210226 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a4397635afea5d127548d64e0055ed471ef2d5be
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout a4397635afea5d127548d64e0055ed471ef2d5be
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd' [-Wmissing-prototypes]
>       17 | bool crypto_aegis128_have_simd(void)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~~

---8<---
This patch fixes missing prototype warnings in crypto/aegis128-neon.c.

Fixes: a4397635afea ("crypto: aegis128 - provide a SIMD...")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/crypto/aegis.h b/crypto/aegis.h
index 6920ebe77679..6ef9c174c973 100644
--- a/crypto/aegis.h
+++ b/crypto/aegis.h
@@ -21,9 +21,28 @@ union aegis_block {
 	u8 bytes[AEGIS_BLOCK_SIZE];
 };
 
+struct aegis_state;
+
+extern int aegis128_have_aes_insn;
+
 #define AEGIS_BLOCK_ALIGN (__alignof__(union aegis_block))
 #define AEGIS_ALIGNED(p) IS_ALIGNED((uintptr_t)p, AEGIS_BLOCK_ALIGN)
 
+bool crypto_aegis128_have_simd(void);
+void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg);
+void crypto_aegis128_init_simd(struct aegis_state *state,
+			       const union aegis_block *key,
+			       const u8 *iv);
+void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
+					const u8 *src, unsigned int size);
+void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
+					const u8 *src, unsigned int size);
+int crypto_aegis128_final_simd(struct aegis_state *state,
+			       union aegis_block *tag_xor,
+			       unsigned int assoclen,
+			       unsigned int cryptlen,
+			       unsigned int authsize);
+
 static __always_inline void crypto_aegis_block_xor(union aegis_block *dst,
 						   const union aegis_block *src)
 {
diff --git a/crypto/aegis128-core.c b/crypto/aegis128-core.c
index 89dc1c559689..c4f1bfa1d04f 100644
--- a/crypto/aegis128-core.c
+++ b/crypto/aegis128-core.c
@@ -58,21 +58,6 @@ static bool aegis128_do_simd(void)
 	return false;
 }
 
-bool crypto_aegis128_have_simd(void);
-void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg);
-void crypto_aegis128_init_simd(struct aegis_state *state,
-			       const union aegis_block *key,
-			       const u8 *iv);
-void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
-					const u8 *src, unsigned int size);
-void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
-					const u8 *src, unsigned int size);
-int crypto_aegis128_final_simd(struct aegis_state *state,
-			       union aegis_block *tag_xor,
-			       unsigned int assoclen,
-			       unsigned int cryptlen,
-			       unsigned int authsize);
-
 static void crypto_aegis128_update(struct aegis_state *state)
 {
 	union aegis_block tmp;
diff --git a/crypto/aegis128-neon.c b/crypto/aegis128-neon.c
index 94d591a002a4..a7856915ec85 100644
--- a/crypto/aegis128-neon.c
+++ b/crypto/aegis128-neon.c
@@ -30,7 +30,7 @@ bool crypto_aegis128_have_simd(void)
 	return IS_ENABLED(CONFIG_ARM64);
 }
 
-void crypto_aegis128_init_simd(union aegis_block *state,
+void crypto_aegis128_init_simd(struct aegis_state *state,
 			       const union aegis_block *key,
 			       const u8 *iv)
 {
@@ -39,14 +39,14 @@ void crypto_aegis128_init_simd(union aegis_block *state,
 	kernel_neon_end();
 }
 
-void crypto_aegis128_update_simd(union aegis_block *state, const void *msg)
+void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg)
 {
 	kernel_neon_begin();
 	crypto_aegis128_update_neon(state, msg);
 	kernel_neon_end();
 }
 
-void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
+void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
 					const u8 *src, unsigned int size)
 {
 	kernel_neon_begin();
@@ -54,7 +54,7 @@ void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
 	kernel_neon_end();
 }
 
-void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
+void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
 					const u8 *src, unsigned int size)
 {
 	kernel_neon_begin();
@@ -62,7 +62,7 @@ void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
 	kernel_neon_end();
 }
 
-int crypto_aegis128_final_simd(union aegis_block *state,
+int crypto_aegis128_final_simd(struct aegis_state *state,
 			       union aegis_block *tag_xor,
 			       unsigned int assoclen,
 			       unsigned int cryptlen,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: aegis128 - Move simd prototypes into aegis.h
  2021-03-08  5:41   ` Herbert Xu
@ 2021-03-08  9:37     ` Ard Biesheuvel
  -1 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2021-03-08  9:37 UTC (permalink / raw)
  To: Herbert Xu
  Cc: kernel test robot, Ard Biesheuvel, kbuild-all,
	Linux Kernel Mailing List, Ondrej Mosnacek,
	Linux Crypto Mailing List

On Mon, 8 Mar 2021 at 06:42, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sun, Feb 28, 2021 at 03:14:55AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
> > commit: a4397635afea5d127548d64e0055ed471ef2d5be crypto: aegis128 - provide a SIMD implementation based on NEON intrinsics
> > date:   1 year, 6 months ago
> > config: arm64-randconfig-r035-20210226 (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a4397635afea5d127548d64e0055ed471ef2d5be
> >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >         git fetch --no-tags linus master
> >         git checkout a4397635afea5d127548d64e0055ed471ef2d5be
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd' [-Wmissing-prototypes]
> >       17 | bool crypto_aegis128_have_simd(void)
> >          |      ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> ---8<---
> This patch fixes missing prototype warnings in crypto/aegis128-neon.c.
>
> Fixes: a4397635afea ("crypto: aegis128 - provide a SIMD...")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

>
> diff --git a/crypto/aegis.h b/crypto/aegis.h
> index 6920ebe77679..6ef9c174c973 100644
> --- a/crypto/aegis.h
> +++ b/crypto/aegis.h
> @@ -21,9 +21,28 @@ union aegis_block {
>         u8 bytes[AEGIS_BLOCK_SIZE];
>  };
>
> +struct aegis_state;
> +
> +extern int aegis128_have_aes_insn;
> +
>  #define AEGIS_BLOCK_ALIGN (__alignof__(union aegis_block))
>  #define AEGIS_ALIGNED(p) IS_ALIGNED((uintptr_t)p, AEGIS_BLOCK_ALIGN)
>
> +bool crypto_aegis128_have_simd(void);
> +void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg);
> +void crypto_aegis128_init_simd(struct aegis_state *state,
> +                              const union aegis_block *key,
> +                              const u8 *iv);
> +void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
> +                                       const u8 *src, unsigned int size);
> +void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
> +                                       const u8 *src, unsigned int size);
> +int crypto_aegis128_final_simd(struct aegis_state *state,
> +                              union aegis_block *tag_xor,
> +                              unsigned int assoclen,
> +                              unsigned int cryptlen,
> +                              unsigned int authsize);
> +
>  static __always_inline void crypto_aegis_block_xor(union aegis_block *dst,
>                                                    const union aegis_block *src)
>  {
> diff --git a/crypto/aegis128-core.c b/crypto/aegis128-core.c
> index 89dc1c559689..c4f1bfa1d04f 100644
> --- a/crypto/aegis128-core.c
> +++ b/crypto/aegis128-core.c
> @@ -58,21 +58,6 @@ static bool aegis128_do_simd(void)
>         return false;
>  }
>
> -bool crypto_aegis128_have_simd(void);
> -void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg);
> -void crypto_aegis128_init_simd(struct aegis_state *state,
> -                              const union aegis_block *key,
> -                              const u8 *iv);
> -void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
> -                                       const u8 *src, unsigned int size);
> -void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
> -                                       const u8 *src, unsigned int size);
> -int crypto_aegis128_final_simd(struct aegis_state *state,
> -                              union aegis_block *tag_xor,
> -                              unsigned int assoclen,
> -                              unsigned int cryptlen,
> -                              unsigned int authsize);
> -
>  static void crypto_aegis128_update(struct aegis_state *state)
>  {
>         union aegis_block tmp;
> diff --git a/crypto/aegis128-neon.c b/crypto/aegis128-neon.c
> index 94d591a002a4..a7856915ec85 100644
> --- a/crypto/aegis128-neon.c
> +++ b/crypto/aegis128-neon.c
> @@ -30,7 +30,7 @@ bool crypto_aegis128_have_simd(void)
>         return IS_ENABLED(CONFIG_ARM64);
>  }
>
> -void crypto_aegis128_init_simd(union aegis_block *state,
> +void crypto_aegis128_init_simd(struct aegis_state *state,
>                                const union aegis_block *key,
>                                const u8 *iv)
>  {
> @@ -39,14 +39,14 @@ void crypto_aegis128_init_simd(union aegis_block *state,
>         kernel_neon_end();
>  }
>
> -void crypto_aegis128_update_simd(union aegis_block *state, const void *msg)
> +void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg)
>  {
>         kernel_neon_begin();
>         crypto_aegis128_update_neon(state, msg);
>         kernel_neon_end();
>  }
>
> -void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
> +void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
>                                         const u8 *src, unsigned int size)
>  {
>         kernel_neon_begin();
> @@ -54,7 +54,7 @@ void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
>         kernel_neon_end();
>  }
>
> -void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
> +void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
>                                         const u8 *src, unsigned int size)
>  {
>         kernel_neon_begin();
> @@ -62,7 +62,7 @@ void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
>         kernel_neon_end();
>  }
>
> -int crypto_aegis128_final_simd(union aegis_block *state,
> +int crypto_aegis128_final_simd(struct aegis_state *state,
>                                union aegis_block *tag_xor,
>                                unsigned int assoclen,
>                                unsigned int cryptlen,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: aegis128 - Move simd prototypes into aegis.h
@ 2021-03-08  9:37     ` Ard Biesheuvel
  0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2021-03-08  9:37 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 6992 bytes --]

On Mon, 8 Mar 2021 at 06:42, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sun, Feb 28, 2021 at 03:14:55AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
> > commit: a4397635afea5d127548d64e0055ed471ef2d5be crypto: aegis128 - provide a SIMD implementation based on NEON intrinsics
> > date:   1 year, 6 months ago
> > config: arm64-randconfig-r035-20210226 (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a4397635afea5d127548d64e0055ed471ef2d5be
> >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >         git fetch --no-tags linus master
> >         git checkout a4397635afea5d127548d64e0055ed471ef2d5be
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd' [-Wmissing-prototypes]
> >       17 | bool crypto_aegis128_have_simd(void)
> >          |      ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> ---8<---
> This patch fixes missing prototype warnings in crypto/aegis128-neon.c.
>
> Fixes: a4397635afea ("crypto: aegis128 - provide a SIMD...")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

>
> diff --git a/crypto/aegis.h b/crypto/aegis.h
> index 6920ebe77679..6ef9c174c973 100644
> --- a/crypto/aegis.h
> +++ b/crypto/aegis.h
> @@ -21,9 +21,28 @@ union aegis_block {
>         u8 bytes[AEGIS_BLOCK_SIZE];
>  };
>
> +struct aegis_state;
> +
> +extern int aegis128_have_aes_insn;
> +
>  #define AEGIS_BLOCK_ALIGN (__alignof__(union aegis_block))
>  #define AEGIS_ALIGNED(p) IS_ALIGNED((uintptr_t)p, AEGIS_BLOCK_ALIGN)
>
> +bool crypto_aegis128_have_simd(void);
> +void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg);
> +void crypto_aegis128_init_simd(struct aegis_state *state,
> +                              const union aegis_block *key,
> +                              const u8 *iv);
> +void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
> +                                       const u8 *src, unsigned int size);
> +void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
> +                                       const u8 *src, unsigned int size);
> +int crypto_aegis128_final_simd(struct aegis_state *state,
> +                              union aegis_block *tag_xor,
> +                              unsigned int assoclen,
> +                              unsigned int cryptlen,
> +                              unsigned int authsize);
> +
>  static __always_inline void crypto_aegis_block_xor(union aegis_block *dst,
>                                                    const union aegis_block *src)
>  {
> diff --git a/crypto/aegis128-core.c b/crypto/aegis128-core.c
> index 89dc1c559689..c4f1bfa1d04f 100644
> --- a/crypto/aegis128-core.c
> +++ b/crypto/aegis128-core.c
> @@ -58,21 +58,6 @@ static bool aegis128_do_simd(void)
>         return false;
>  }
>
> -bool crypto_aegis128_have_simd(void);
> -void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg);
> -void crypto_aegis128_init_simd(struct aegis_state *state,
> -                              const union aegis_block *key,
> -                              const u8 *iv);
> -void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
> -                                       const u8 *src, unsigned int size);
> -void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
> -                                       const u8 *src, unsigned int size);
> -int crypto_aegis128_final_simd(struct aegis_state *state,
> -                              union aegis_block *tag_xor,
> -                              unsigned int assoclen,
> -                              unsigned int cryptlen,
> -                              unsigned int authsize);
> -
>  static void crypto_aegis128_update(struct aegis_state *state)
>  {
>         union aegis_block tmp;
> diff --git a/crypto/aegis128-neon.c b/crypto/aegis128-neon.c
> index 94d591a002a4..a7856915ec85 100644
> --- a/crypto/aegis128-neon.c
> +++ b/crypto/aegis128-neon.c
> @@ -30,7 +30,7 @@ bool crypto_aegis128_have_simd(void)
>         return IS_ENABLED(CONFIG_ARM64);
>  }
>
> -void crypto_aegis128_init_simd(union aegis_block *state,
> +void crypto_aegis128_init_simd(struct aegis_state *state,
>                                const union aegis_block *key,
>                                const u8 *iv)
>  {
> @@ -39,14 +39,14 @@ void crypto_aegis128_init_simd(union aegis_block *state,
>         kernel_neon_end();
>  }
>
> -void crypto_aegis128_update_simd(union aegis_block *state, const void *msg)
> +void crypto_aegis128_update_simd(struct aegis_state *state, const void *msg)
>  {
>         kernel_neon_begin();
>         crypto_aegis128_update_neon(state, msg);
>         kernel_neon_end();
>  }
>
> -void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
> +void crypto_aegis128_encrypt_chunk_simd(struct aegis_state *state, u8 *dst,
>                                         const u8 *src, unsigned int size)
>  {
>         kernel_neon_begin();
> @@ -54,7 +54,7 @@ void crypto_aegis128_encrypt_chunk_simd(union aegis_block *state, u8 *dst,
>         kernel_neon_end();
>  }
>
> -void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
> +void crypto_aegis128_decrypt_chunk_simd(struct aegis_state *state, u8 *dst,
>                                         const u8 *src, unsigned int size)
>  {
>         kernel_neon_begin();
> @@ -62,7 +62,7 @@ void crypto_aegis128_decrypt_chunk_simd(union aegis_block *state, u8 *dst,
>         kernel_neon_end();
>  }
>
> -int crypto_aegis128_final_simd(union aegis_block *state,
> +int crypto_aegis128_final_simd(struct aegis_state *state,
>                                union aegis_block *tag_xor,
>                                unsigned int assoclen,
>                                unsigned int cryptlen,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-08  9:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-27 19:14 crypto/aegis128-neon.c:17:6: warning: no previous prototype for 'crypto_aegis128_have_simd' kernel test robot
2021-02-27 19:14 ` kernel test robot
2021-03-08  5:41 ` [PATCH] crypto: aegis128 - Move simd prototypes into aegis.h Herbert Xu
2021-03-08  5:41   ` Herbert Xu
2021-03-08  9:37   ` Ard Biesheuvel
2021-03-08  9:37     ` Ard Biesheuvel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.