Build with -Werror=declaration-after-statement

Build with -Werror=declaration-after-statement

[ASM]

Hi folks!

Many groups have flag  -Werror=declaration-after-statement in the
their coding conventions. Dpdk have many code as static inline
function in the headers files and have trouble with it.

For example:
* lib/librte_ether/rte_ether.h, function rte_vlan_strip
* lib/librte_eal/common/include/rte_dev.h, function rte_pmd_debug_trace
* lib/librte_eal/common/include/arch/x86/rte_spinlock.h, fucntion rte_try_tm

Any project who use  -Werror=declaration-after-statement can't to
compile own projects without
patching this headers.

How do you look at to fix this problem?

---
Best regards,
Leonid Myravjev

Re: Build with -Werror=declaration-after-statement

[Thomas Monjalon]

2016-09-02 13:49, ASM:
> Hi folks!
> 
> Many groups have flag  -Werror=declaration-after-statement in the
> their coding conventions. Dpdk have many code as static inline
> function in the headers files and have trouble with it.
> 
> For example:
> * lib/librte_ether/rte_ether.h, function rte_vlan_strip
> * lib/librte_eal/common/include/rte_dev.h, function rte_pmd_debug_trace
> * lib/librte_eal/common/include/arch/x86/rte_spinlock.h, fucntion rte_try_tm
> 
> Any project who use  -Werror=declaration-after-statement can't to
> compile own projects without
> patching this headers.
> 
> How do you look at to fix this problem?

It is probably a good fix to have on top of Adrien's series:
	http://dpdk.org/ml/archives/dev/2016-July/043928.html

You are welcome to fix any header to be more widely used :)