[PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove

[PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove

[Axel Lin]

Remove a previously registered clock provider when unload the module.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/clk/clk-cdce706.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-cdce706.c b/drivers/clk/clk-cdce706.c
index 8a2dfd0..f01164f 100644
--- a/drivers/clk/clk-cdce706.c
+++ b/drivers/clk/clk-cdce706.c
@@ -666,6 +666,7 @@ static int cdce706_probe(struct i2c_client *client,
 
 static int cdce706_remove(struct i2c_client *client)
 {
+	of_clk_del_provider(client->dev.of_node);
 	return 0;
 }
 
-- 
2.1.0

Re: [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove

[Stephen Boyd]

On 05/21, Axel Lin wrote:
> Remove a previously registered clock provider when unload the module.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---

What about all the clocks that are registered? Don't those need
to be unregistered as well?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove

[Max Filippov]

On Thu, May 21, 2015 at 9:14 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 05/21, Axel Lin wrote:
>> Remove a previously registered clock provider when unload the module.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>
> What about all the clocks that are registered? Don't those need
> to be unregistered as well?

They're registered with devm_clk_register, should be managed automatically.

-- 
Thanks.
-- Max

Re: [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove

[Max Filippov]

On Thu, May 21, 2015 at 5:26 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Remove a previously registered clock provider when unload the module.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/clk/clk-cdce706.c | 1 +
>  1 file changed, 1 insertion(+)

Good catch, thank you!
Acked-by: Max Filippov <jcmvbkbc@gmail.com>

Re: [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove

[Stephen Boyd]

On 05/21/15 11:35, Max Filippov wrote:
> On Thu, May 21, 2015 at 9:14 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> On 05/21, Axel Lin wrote:
>>> Remove a previously registered clock provider when unload the module.
>>>
>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>> ---
>> What about all the clocks that are registered? Don't those need
>> to be unregistered as well?
> They're registered with devm_clk_register, should be managed automatically.
>

Ah good. Applied.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project