All of lore.kernel.org
 help / color / mirror / Atom feed
* running TCG tests for xtensaeb
@ 2021-10-02  4:33 Max Filippov
  0 siblings, 0 replies; only message in thread
From: Max Filippov @ 2021-10-02  4:33 UTC (permalink / raw)
  To: Alex Bennée; +Cc: qemu-devel

Hi Alex,

I've tried to use

  make check-tcg CORE=test_kc705_be CROSS_CC_GUEST=xtensa-test_kc705_be-elf-gcc

to run TCG tests for a big-endian xtensa core. I thought the following change
would be sufficient to do it:

---8<---
diff --git a/tests/tcg/xtensa/Makefile.softmmu-target
b/tests/tcg/xtensa/Makefile.softmmu-target
index 9530cac2ad95..6588388967d9 100644
--- a/tests/tcg/xtensa/Makefile.softmmu-target
+++ b/tests/tcg/xtensa/Makefile.softmmu-target
@@ -2,7 +2,7 @@
# Xtensa softmmu tests
#

-ifneq ($(TARGET_WORDS_BIGENDIAN),y)
+ifneq ($(shell $(QEMU) -cpu help | grep -w $(CORE)),)

XTENSA_SRC = $(SRC_PATH)/tests/tcg/xtensa
XTENSA_ALL = $(filter-out $(XTENSA_SRC)/linker.ld.S,$(wildcard
$(XTENSA_SRC)/*.S))
---8<---

but it turns out that tests/tcg/Makefile.target uses the following
code to load target-specific bits:

-include $(SRC_PATH)/tests/tcg/$(TARGET_NAME)/Makefile.softmmu-target

and for big-endian xtensa TARGET_NAME is xtensaeb.
However all xtensa tests are under tests/tcg/xtensa, so
Makefile.softmmu-target isn't getting loaded at all.
If I replace '$(TARGET_NAME)' with 'xtensa' in the above
line everything works as expected.

What do you think would be the best way to fix it?

-- 
Thanks.
-- Max


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-02  4:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-02  4:33 running TCG tests for xtensaeb Max Filippov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.