* [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine
@ 2012-08-08 23:31 Max Filippov
2012-08-09 7:43 ` Markus Armbruster
2012-08-09 19:58 ` Blue Swirl
0 siblings, 2 replies; 6+ messages in thread
From: Max Filippov @ 2012-08-08 23:31 UTC (permalink / raw)
To: qemu-devel; +Cc: Max Filippov
This fixes the following error:
$ qemu-system-xtensa -cpu help
Segmentation fault
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
hw/xtensa_sim.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/xtensa_sim.c b/hw/xtensa_sim.c
index ed38bd4..831460b 100644
--- a/hw/xtensa_sim.c
+++ b/hw/xtensa_sim.c
@@ -111,6 +111,7 @@ static void xtensa_sim_init(ram_addr_t ram_size,
static QEMUMachine xtensa_sim_machine = {
.name = "sim",
.desc = "sim machine (" XTENSA_DEFAULT_CPU_MODEL ")",
+ .is_default = true,
.init = xtensa_sim_init,
.max_cpus = 4,
};
--
1.7.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine
2012-08-08 23:31 [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine Max Filippov
@ 2012-08-09 7:43 ` Markus Armbruster
2012-08-09 7:52 ` Dunrong Huang
2012-08-09 10:36 ` Max Filippov
2012-08-09 19:58 ` Blue Swirl
1 sibling, 2 replies; 6+ messages in thread
From: Markus Armbruster @ 2012-08-09 7:43 UTC (permalink / raw)
To: Max Filippov; +Cc: qemu-devel, Crístian Viana
Max Filippov <jcmvbkbc@gmail.com> writes:
> This fixes the following error:
>
> $ qemu-system-xtensa -cpu help
> Segmentation fault
main() attempts to cope with "no machine found", it just screws it up:
if (machine->hw_version) {
qemu_set_version(machine->hw_version);
}
[...]
if (machine == NULL) {
fprintf(stderr, "No machine found.\n");
exit(1);
}
Probably broken in commit 93bfef4c, cc'ing its author.
Of course, I don't mind you picking a default machine for xtensa, if
that's what you want.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine
2012-08-09 7:43 ` Markus Armbruster
@ 2012-08-09 7:52 ` Dunrong Huang
2012-08-09 8:01 ` Markus Armbruster
2012-08-09 10:36 ` Max Filippov
1 sibling, 1 reply; 6+ messages in thread
From: Dunrong Huang @ 2012-08-09 7:52 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Max Filippov, qemu-devel, Crístian Viana
2012/8/9 Markus Armbruster <armbru@redhat.com>:
> Max Filippov <jcmvbkbc@gmail.com> writes:
>
>> This fixes the following error:
>>
>> $ qemu-system-xtensa -cpu help
>> Segmentation fault
>
> main() attempts to cope with "no machine found", it just screws it up:
>
> if (machine->hw_version) {
> qemu_set_version(machine->hw_version);
> }
> [...]
> if (machine == NULL) {
> fprintf(stderr, "No machine found.\n");
> exit(1);
> }
>
I have sent
a trivial patch to fix this bug, but no one replied it.
I resend it just now.
http://lists.nongnu.org/archive/html/qemu-devel/2012-08/msg01437.html
> Probably broken in commit 93bfef4c, cc'ing its author.
>
> Of course, I don't mind you picking a default machine for xtensa, if
> that's what you want.
>
--
Best Regards,
Dunrong Huang
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine
2012-08-09 7:52 ` Dunrong Huang
@ 2012-08-09 8:01 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2012-08-09 8:01 UTC (permalink / raw)
To: Dunrong Huang; +Cc: Max Filippov, qemu-devel, Crístian Viana
Dunrong Huang <riegamaths@gmail.com> writes:
> 2012/8/9 Markus Armbruster <armbru@redhat.com>:
>> Max Filippov <jcmvbkbc@gmail.com> writes:
>>
>>> This fixes the following error:
>>>
>>> $ qemu-system-xtensa -cpu help
>>> Segmentation fault
>>
>> main() attempts to cope with "no machine found", it just screws it up:
>>
>> if (machine->hw_version) {
>> qemu_set_version(machine->hw_version);
>> }
>> [...]
>> if (machine == NULL) {
>> fprintf(stderr, "No machine found.\n");
>> exit(1);
>> }
>>
> I have sent
> a trivial patch to fix this bug, but no one replied it.
>
> I resend it just now.
> http://lists.nongnu.org/archive/html/qemu-devel/2012-08/msg01437.html
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine
2012-08-09 7:43 ` Markus Armbruster
2012-08-09 7:52 ` Dunrong Huang
@ 2012-08-09 10:36 ` Max Filippov
1 sibling, 0 replies; 6+ messages in thread
From: Max Filippov @ 2012-08-09 10:36 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, Crístian Viana
On Thu, Aug 9, 2012 at 11:43 AM, Markus Armbruster <armbru@redhat.com> wrote:
> Max Filippov <jcmvbkbc@gmail.com> writes:
>
>> This fixes the following error:
>>
>> $ qemu-system-xtensa -cpu help
>> Segmentation fault
>
> main() attempts to cope with "no machine found", it just screws it up:
>
> if (machine->hw_version) {
> qemu_set_version(machine->hw_version);
> }
> [...]
> if (machine == NULL) {
> fprintf(stderr, "No machine found.\n");
> exit(1);
> }
>
> Probably broken in commit 93bfef4c, cc'ing its author.
>
> Of course, I don't mind you picking a default machine for xtensa, if
> that's what you want.
I guess it would make no harm. Also this way it will less likely break
next time,
and I remember Blue once wondered why xtensa doesn't have the default
machine.
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine
2012-08-08 23:31 [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine Max Filippov
2012-08-09 7:43 ` Markus Armbruster
@ 2012-08-09 19:58 ` Blue Swirl
1 sibling, 0 replies; 6+ messages in thread
From: Blue Swirl @ 2012-08-09 19:58 UTC (permalink / raw)
To: Max Filippov; +Cc: qemu-devel
Thanks, applied.
On Wed, Aug 8, 2012 at 11:31 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> This fixes the following error:
>
> $ qemu-system-xtensa -cpu help
> Segmentation fault
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> hw/xtensa_sim.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/xtensa_sim.c b/hw/xtensa_sim.c
> index ed38bd4..831460b 100644
> --- a/hw/xtensa_sim.c
> +++ b/hw/xtensa_sim.c
> @@ -111,6 +111,7 @@ static void xtensa_sim_init(ram_addr_t ram_size,
> static QEMUMachine xtensa_sim_machine = {
> .name = "sim",
> .desc = "sim machine (" XTENSA_DEFAULT_CPU_MODEL ")",
> + .is_default = true,
> .init = xtensa_sim_init,
> .max_cpus = 4,
> };
> --
> 1.7.7.6
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-09 19:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-08 23:31 [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine Max Filippov
2012-08-09 7:43 ` Markus Armbruster
2012-08-09 7:52 ` Dunrong Huang
2012-08-09 8:01 ` Markus Armbruster
2012-08-09 10:36 ` Max Filippov
2012-08-09 19:58 ` Blue Swirl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.