All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Jinchao Wang <wjc@cdjrlc.com>
Cc: "andy.shevchenko" <andy.shevchenko@gmail.com>,
	shawnguo <shawnguo@kernel.org>,
	"s.hauer" <s.hauer@pengutronix.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gpio: mxs: Prefer unsigned int to bare use of unsigned
Date: Fri, 25 Jun 2021 12:34:14 +0200	[thread overview]
Message-ID: <CAMpxmJUsnAYbAyY8OaO6fm27Sj+itxge4PqBdefUBXv5WK7Tqw@mail.gmail.com> (raw)
In-Reply-To: <20210624101517.15167-1-wjc@cdjrlc.com>

On Thu, Jun 24, 2021 at 12:15 PM Jinchao Wang <wjc@cdjrlc.com> wrote:
>
> Fix checkpatch warnings:
>     WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Jinchao Wang <wjc@cdjrlc.com>
> ---
> - changes for v2:
> - Use full prefix
>
> ---
>  drivers/gpio/gpio-mxs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
> index 524b668eb1ac..31a336b86ff2 100644
> --- a/drivers/gpio/gpio-mxs.c
> +++ b/drivers/gpio/gpio-mxs.c
> @@ -229,14 +229,14 @@ static int mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
>         return rv;
>  }
>
> -static int mxs_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
> +static int mxs_gpio_to_irq(struct gpio_chip *gc, unsigned int offset)
>  {
>         struct mxs_gpio_port *port = gpiochip_get_data(gc);
>
>         return irq_find_mapping(port->domain, offset);
>  }
>
> -static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned offset)
> +static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
>  {
>         struct mxs_gpio_port *port = gpiochip_get_data(gc);
>         u32 mask = 1 << offset;
> --
> 2.31.1
>

Applied, thanks!

Bartosz

WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Jinchao Wang <wjc@cdjrlc.com>
Cc: "andy.shevchenko" <andy.shevchenko@gmail.com>,
	shawnguo <shawnguo@kernel.org>,
	"s.hauer" <s.hauer@pengutronix.de>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 linux-gpio <linux-gpio@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gpio: mxs: Prefer unsigned int to bare use of unsigned
Date: Fri, 25 Jun 2021 12:34:14 +0200	[thread overview]
Message-ID: <CAMpxmJUsnAYbAyY8OaO6fm27Sj+itxge4PqBdefUBXv5WK7Tqw@mail.gmail.com> (raw)
In-Reply-To: <20210624101517.15167-1-wjc@cdjrlc.com>

On Thu, Jun 24, 2021 at 12:15 PM Jinchao Wang <wjc@cdjrlc.com> wrote:
>
> Fix checkpatch warnings:
>     WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Jinchao Wang <wjc@cdjrlc.com>
> ---
> - changes for v2:
> - Use full prefix
>
> ---
>  drivers/gpio/gpio-mxs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
> index 524b668eb1ac..31a336b86ff2 100644
> --- a/drivers/gpio/gpio-mxs.c
> +++ b/drivers/gpio/gpio-mxs.c
> @@ -229,14 +229,14 @@ static int mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
>         return rv;
>  }
>
> -static int mxs_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
> +static int mxs_gpio_to_irq(struct gpio_chip *gc, unsigned int offset)
>  {
>         struct mxs_gpio_port *port = gpiochip_get_data(gc);
>
>         return irq_find_mapping(port->domain, offset);
>  }
>
> -static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned offset)
> +static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
>  {
>         struct mxs_gpio_port *port = gpiochip_get_data(gc);
>         u32 mask = 1 << offset;
> --
> 2.31.1
>

Applied, thanks!

Bartosz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-25 10:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 10:15 [PATCH v2] gpio: mxs: Prefer unsigned int to bare use of unsigned Jinchao Wang
2021-06-25 10:34 ` Bartosz Golaszewski [this message]
2021-06-25 10:34   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMpxmJUsnAYbAyY8OaO6fm27Sj+itxge4PqBdefUBXv5WK7Tqw@mail.gmail.com \
    --to=bgolaszewski@baylibre.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=wjc@cdjrlc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.