From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Anson Huang <Anson.Huang@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally
Date: Wed, 10 Feb 2021 14:25:21 +0100 [thread overview]
Message-ID: <CAMpxmJV5vMuyA8bc4MJfwPAKM-0vKQP2oAPZTigGtDtHvoaByg@mail.gmail.com> (raw)
In-Reply-To: <20210208145153.422093-1-geert+renesas@glider.be>
On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS,
> and ask the user in case of compile-testing.
>
> Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/gpio/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5fdf526fe973da38..412728ff2ab45c0d 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -442,8 +442,9 @@ config GPIO_MXC
> select GENERIC_IRQ_CHIP
>
> config GPIO_MXS
> - def_bool y
> + bool "Freescale MXS GPIO support" if COMPILE_TEST
> depends on ARCH_MXS || COMPILE_TEST
> + default y if ARCH_MXS
> select GPIO_GENERIC
> select GENERIC_IRQ_CHIP
>
> --
> 2.25.1
>
Applied, thanks!
Bartosz
next prev parent reply other threads:[~2021-02-10 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:51 [PATCH] gpio: GPIO_MXS should not default to y, unconditionally Geert Uytterhoeven
2021-02-10 13:25 ` Bartosz Golaszewski [this message]
2021-02-12 12:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJV5vMuyA8bc4MJfwPAKM-0vKQP2oAPZTigGtDtHvoaByg@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=Anson.Huang@nxp.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.