Re: [PATCH v2 4/6] dt-bindings: power: max77650: convert the binding document to yaml

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Linux Input <linux-input@vger.kernel.org>,
	linux-devicetree <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	linux-pm <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 4/6] dt-bindings: power: max77650: convert the binding document to yaml
Date: Wed, 16 Oct 2019 10:31:17 +0200	[thread overview]
Message-ID: <CAMpxmJXH6k7PqEE_VfRZ-k1eL+7NSPRuZY8yP8XbYzgVdOAvJQ@mail.gmail.com> (raw)
In-Reply-To: <20191015191837.jd6lbk3qbsmzuwfu@earth.universe>

wt., 15 paź 2019 o 21:18 Sebastian Reichel <sre@kernel.org> napisał(a):
>
> Hi,
>
> On Tue, Oct 15, 2019 at 06:22:58PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Convert the binding document for MAX77650 charger module to YAML.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
>
> Looks sensible to me. Assuming this goes through Rob:
>
> Acked-by: Sebastian Reichel <sre@kernel.org>

Oops, I added your ack for v1 to the leds patch in v2 by mistake.
There'll be a v3 though so no worries.

Thanks!
Bart

>
> -- Sebastian
>
> >  .../power/supply/max77650-charger.txt         | 29 +------------
> >  .../power/supply/max77650-charger.yaml        | 42 +++++++++++++++++++
> >  2 files changed, 43 insertions(+), 28 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > index e6d0fb6ff94e..fbab7d3ac8e3 100644
> > --- a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > @@ -1,28 +1 @@
> > -Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> > -
> > -This module is part of the MAX77650 MFD device. For more details
> > -see Documentation/devicetree/bindings/mfd/max77650.txt.
> > -
> > -The charger is represented as a sub-node of the PMIC node on the device tree.
> > -
> > -Required properties:
> > ---------------------
> > -- compatible:                Must be "maxim,max77650-charger"
> > -
> > -Optional properties:
> > ---------------------
> > -- input-voltage-min-microvolt:       Minimum CHGIN regulation voltage. Must be one
> > -                             of: 4000000, 4100000, 4200000, 4300000,
> > -                             4400000, 4500000, 4600000, 4700000.
> > -- input-current-limit-microamp:      CHGIN input current limit (in microamps). Must
> > -                             be one of: 95000, 190000, 285000, 380000,
> > -                             475000.
> > -
> > -Example:
> > ---------
> > -
> > -     charger {
> > -             compatible = "maxim,max77650-charger";
> > -             input-voltage-min-microvolt = <4200000>;
> > -             input-current-limit-microamp = <285000>;
> > -     };
> > +This file was moved to max77650-charger.yaml.
> > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml b/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
> > new file mode 100644
> > index 000000000000..9dd0dad0f948
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/max77650-charger.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> > +
> > +maintainers:
> > +  - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > +
> > +description: |
> > +  This module is part of the MAX77650 MFD device. For more details
> > +  see Documentation/devicetree/bindings/mfd/max77650.txt.
> > +
> > +  The charger is represented as a sub-node of the PMIC node on the device tree.
> > +
> > +properties:
> > +  compatible:
> > +    const: maxim,max77650-charger
> > +
> > +  input-voltage-min-microvolt:
> > +    description:
> > +      Minimum CHGIN regulation voltage.
> > +    enum: [ 4000000, 4100000, 4200000, 4300000,
> > +            4400000, 4500000, 4600000, 4700000 ]
> > +
> > +  input-current-limit-microamp:
> > +    description:
> > +      CHGIN input current limit (in microamps).
> > +    enum: [ 95000, 190000, 285000, 380000, 475000 ]
> > +
> > +required:
> > +  - compatible
> > +
> > +examples:
> > +  - |
> > +    charger {
> > +        compatible = "maxim,max77650-charger";
> > +        input-voltage-min-microvolt = <4200000>;
> > +        input-current-limit-microamp = <285000>;
> > +    };
> > --
> > 2.23.0
> >