* [PATCH v2 0/6] dt-bindings: max77650: convert the device-tree bindings to yaml
@ 2019-10-15 16:22 Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document " Bartosz Golaszewski
` (5 more replies)
0 siblings, 6 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-15 16:22 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Dmitry Torokhov, Jacek Anaszewski,
Pavel Machek, Dan Murphy, Lee Jones, Sebastian Reichel,
Liam Girdwood, Mark Brown
Cc: linux-input, devicetree, linux-kernel, linux-leds, linux-pm,
Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
This series converts all DT binding documents for MAX77650 PMIC to YAML.
v1 -> v2:
- use upper case for abbreviations in commit messages
Bartosz Golaszewski (6):
dt-bindings: mfd: max77650: convert the binding document to yaml
dt-bindings: input: max77650: convert the binding document to yaml
dt-bindings: regulator: max77650: convert the binding document to yaml
dt-bindings: power: max77650: convert the binding document to yaml
dt-bindings: leds: max77650: convert the binding document to yaml
MAINTAINERS: update the list of maintained files for max77650
.../bindings/input/max77650-onkey.txt | 27 +-----
.../bindings/input/max77650-onkey.yaml | 43 ++++++++++
.../bindings/leds/leds-max77650.txt | 58 +------------
.../bindings/leds/leds-max77650.yaml | 82 ++++++++++++++++++
.../devicetree/bindings/mfd/max77650.txt | 47 +----------
.../devicetree/bindings/mfd/max77650.yaml | 83 +++++++++++++++++++
.../power/supply/max77650-charger.txt | 29 +------
.../power/supply/max77650-charger.yaml | 42 ++++++++++
.../bindings/regulator/max77650-regulator.txt | 42 +---------
.../regulator/max77650-regulator.yaml | 51 ++++++++++++
MAINTAINERS | 4 +-
11 files changed, 308 insertions(+), 200 deletions(-)
create mode 100644 Documentation/devicetree/bindings/input/max77650-onkey.yaml
create mode 100644 Documentation/devicetree/bindings/leds/leds-max77650.yaml
create mode 100644 Documentation/devicetree/bindings/mfd/max77650.yaml
create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
create mode 100644 Documentation/devicetree/bindings/regulator/max77650-regulator.yaml
--
2.23.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document to yaml
2019-10-15 16:22 [PATCH v2 0/6] dt-bindings: max77650: convert the device-tree bindings to yaml Bartosz Golaszewski
@ 2019-10-15 16:22 ` Bartosz Golaszewski
2019-10-15 21:13 ` Rob Herring
2019-10-15 21:17 ` Rob Herring
2019-10-15 16:22 ` [PATCH v2 2/6] dt-bindings: input: " Bartosz Golaszewski
` (4 subsequent siblings)
5 siblings, 2 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-15 16:22 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Dmitry Torokhov, Jacek Anaszewski,
Pavel Machek, Dan Murphy, Lee Jones, Sebastian Reichel,
Liam Girdwood, Mark Brown
Cc: linux-input, devicetree, linux-kernel, linux-leds, linux-pm,
Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Convert the binding document for MAX77650 core MFD module to YAML.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
.../devicetree/bindings/mfd/max77650.txt | 47 +----------
.../devicetree/bindings/mfd/max77650.yaml | 83 +++++++++++++++++++
2 files changed, 84 insertions(+), 46 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/max77650.yaml
diff --git a/Documentation/devicetree/bindings/mfd/max77650.txt b/Documentation/devicetree/bindings/mfd/max77650.txt
index b529d8d19335..080871686b3b 100644
--- a/Documentation/devicetree/bindings/mfd/max77650.txt
+++ b/Documentation/devicetree/bindings/mfd/max77650.txt
@@ -1,46 +1 @@
-MAX77650 ultra low-power PMIC from Maxim Integrated.
-
-Required properties:
--------------------
-- compatible: Must be "maxim,max77650"
-- reg: I2C device address.
-- interrupts: The interrupt on the parent the controller is
- connected to.
-- interrupt-controller: Marks the device node as an interrupt controller.
-- #interrupt-cells: Must be <2>.
-
-- gpio-controller: Marks the device node as a gpio controller.
-- #gpio-cells: Must be <2>. The first cell is the pin number and
- the second cell is used to specify the gpio active
- state.
-
-Optional properties:
---------------------
-gpio-line-names: Single string containing the name of the GPIO line.
-
-The GPIO-controller module is represented as part of the top-level PMIC
-node. The device exposes a single GPIO line.
-
-For device-tree bindings of other sub-modules (regulator, power supply,
-LEDs and onkey) refer to the binding documents under the respective
-sub-system directories.
-
-For more details on GPIO bindings, please refer to the generic GPIO DT
-binding document <devicetree/bindings/gpio/gpio.txt>.
-
-Example:
---------
-
- pmic@48 {
- compatible = "maxim,max77650";
- reg = <0x48>;
-
- interrupt-controller;
- interrupt-parent = <&gpio2>;
- #interrupt-cells = <2>;
- interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
-
- gpio-controller;
- #gpio-cells = <2>;
- gpio-line-names = "max77650-charger";
- };
+This file has been moved to max77650.yaml.
diff --git a/Documentation/devicetree/bindings/mfd/max77650.yaml b/Documentation/devicetree/bindings/mfd/max77650.yaml
new file mode 100644
index 000000000000..5186ad287ec7
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/max77650.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/max77650.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MAX77650 ultra low-power PMIC from Maxim Integrated.
+
+maintainers:
+ - Bartosz Golaszewski <bgolaszewski@baylibre.com>
+
+description: |
+ This document describes the DT properties of the core MFD controller.
+
+ The GPIO-controller module is represented as part of the top-level PMIC
+ node. The device exposes a single GPIO line.
+
+ For device-tree bindings of other sub-modules (regulator, power supply,
+ LEDs and onkey) refer to the binding documents under the respective
+ sub-system directories.
+
+ For more details on GPIO bindings, please refer to the generic GPIO DT
+ binding document <devicetree/bindings/gpio/gpio.txt>.
+
+properties:
+ compatible:
+ const: maxim,max77650
+
+ reg:
+ description:
+ I2C device address.
+ maxItems: 1
+
+ interrupts:
+ description:
+ The interrupt on the parent the controller is connected to.
+ maxItems: 1
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+ description:
+ The first cell is the IRQ number, the second cell is the trigger type.
+
+ gpio-controller: true
+
+ "#gpio-cells":
+ const: 2
+ description:
+ The first cell is the pin number and the second cell is used to specify
+ the gpio active state.
+
+ gpio-line-names:
+ $ref: '/schemas/types.yaml#/definitions/string-array'
+ maxItems: 1
+ description:
+ Single string containing the name of the GPIO line.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-controller
+ - "#interrupt-cells"
+ - gpio-controller
+ - "#gpio-cells"
+
+examples:
+ - |
+ pmic@48 {
+ compatible = "maxim,max77650";
+ reg = <0x48>;
+
+ interrupt-controller;
+ interrupt-parent = <&gpio2>;
+ #interrupt-cells = <2>;
+ interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names = "max77650-charger";
+ };
--
2.23.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 2/6] dt-bindings: input: max77650: convert the binding document to yaml
2019-10-15 16:22 [PATCH v2 0/6] dt-bindings: max77650: convert the device-tree bindings to yaml Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document " Bartosz Golaszewski
@ 2019-10-15 16:22 ` Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 3/6] dt-bindings: regulator: " Bartosz Golaszewski
` (3 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-15 16:22 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Dmitry Torokhov, Jacek Anaszewski,
Pavel Machek, Dan Murphy, Lee Jones, Sebastian Reichel,
Liam Girdwood, Mark Brown
Cc: linux-input, devicetree, linux-kernel, linux-leds, linux-pm,
Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Convert the binding document for MAX77650 onkey module to YAML.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
.../bindings/input/max77650-onkey.txt | 27 +-----------
.../bindings/input/max77650-onkey.yaml | 43 +++++++++++++++++++
2 files changed, 44 insertions(+), 26 deletions(-)
create mode 100644 Documentation/devicetree/bindings/input/max77650-onkey.yaml
diff --git a/Documentation/devicetree/bindings/input/max77650-onkey.txt b/Documentation/devicetree/bindings/input/max77650-onkey.txt
index 477dc74f452a..a691fc49f1ea 100644
--- a/Documentation/devicetree/bindings/input/max77650-onkey.txt
+++ b/Documentation/devicetree/bindings/input/max77650-onkey.txt
@@ -1,26 +1 @@
-Onkey driver for MAX77650 PMIC from Maxim Integrated.
-
-This module is part of the MAX77650 MFD device. For more details
-see Documentation/devicetree/bindings/mfd/max77650.txt.
-
-The onkey controller is represented as a sub-node of the PMIC node on
-the device tree.
-
-Required properties:
---------------------
-- compatible: Must be "maxim,max77650-onkey".
-
-Optional properties:
-- linux,code: The key-code to be reported when the key is pressed.
- Defaults to KEY_POWER.
-- maxim,onkey-slide: The system's button is a slide switch, not the default
- push button.
-
-Example:
---------
-
- onkey {
- compatible = "maxim,max77650-onkey";
- linux,code = <KEY_END>;
- maxim,onkey-slide;
- };
+This file has been moved to max77650-onkey.yaml.
diff --git a/Documentation/devicetree/bindings/input/max77650-onkey.yaml b/Documentation/devicetree/bindings/input/max77650-onkey.yaml
new file mode 100644
index 000000000000..eb2f8609bae2
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/max77650-onkey.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/max77650-onkey.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Onkey driver for MAX77650 PMIC from Maxim Integrated.
+
+maintainers:
+ - Bartosz Golaszewski <bgolaszewski@baylibre.com>
+
+description: |
+ This module is part of the MAX77650 MFD device. For more details
+ see Documentation/devicetree/bindings/mfd/max77650.yaml.
+
+ The onkey controller is represented as a sub-node of the PMIC node on
+ the device tree.
+
+properties:
+ compatible:
+ const: maxim,max77650-onkey
+
+ linux,code:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ The key-code to be reported when the key is pressed. Defaults
+ to KEY_POWER.
+
+ maxim,onkey-slide:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ The system's button is a slide switch, not the default push button.
+
+required:
+ - compatible
+
+examples:
+ - |
+ onkey {
+ compatible = "maxim,max77650-onkey";
+ linux,code = <KEY_END>;
+ maxim,onkey-slide;
+ };
--
2.23.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 3/6] dt-bindings: regulator: max77650: convert the binding document to yaml
2019-10-15 16:22 [PATCH v2 0/6] dt-bindings: max77650: convert the device-tree bindings to yaml Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document " Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 2/6] dt-bindings: input: " Bartosz Golaszewski
@ 2019-10-15 16:22 ` Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 4/6] dt-bindings: power: " Bartosz Golaszewski
` (2 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-15 16:22 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Dmitry Torokhov, Jacek Anaszewski,
Pavel Machek, Dan Murphy, Lee Jones, Sebastian Reichel,
Liam Girdwood, Mark Brown
Cc: linux-input, devicetree, linux-kernel, linux-leds, linux-pm,
Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Convert the binding document for MAX77650 regulator module to YAML.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
.../bindings/regulator/max77650-regulator.txt | 42 +--------------
.../regulator/max77650-regulator.yaml | 51 +++++++++++++++++++
2 files changed, 52 insertions(+), 41 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/max77650-regulator.yaml
diff --git a/Documentation/devicetree/bindings/regulator/max77650-regulator.txt b/Documentation/devicetree/bindings/regulator/max77650-regulator.txt
index f1cbe813c30f..39686610589c 100644
--- a/Documentation/devicetree/bindings/regulator/max77650-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/max77650-regulator.txt
@@ -1,41 +1 @@
-Regulator driver for MAX77650 PMIC from Maxim Integrated.
-
-This module is part of the MAX77650 MFD device. For more details
-see Documentation/devicetree/bindings/mfd/max77650.txt.
-
-The regulator controller is represented as a sub-node of the PMIC node
-on the device tree.
-
-The device has a single LDO regulator and a SIMO buck-boost regulator with
-three independent power rails.
-
-Required properties:
---------------------
-- compatible: Must be "maxim,max77650-regulator"
-
-Each rail must be instantiated under the regulators subnode of the top PMIC
-node. Up to four regulators can be defined. For standard regulator properties
-refer to Documentation/devicetree/bindings/regulator/regulator.txt.
-
-Available regulator compatible strings are: "ldo", "sbb0", "sbb1", "sbb2".
-
-Example:
---------
-
- regulators {
- compatible = "maxim,max77650-regulator";
-
- max77650_ldo: regulator@0 {
- regulator-compatible = "ldo";
- regulator-name = "max77650-ldo";
- regulator-min-microvolt = <1350000>;
- regulator-max-microvolt = <2937500>;
- };
-
- max77650_sbb0: regulator@1 {
- regulator-compatible = "sbb0";
- regulator-name = "max77650-sbb0";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <1587500>;
- };
- };
+This file has been moved to max77650-regulator.yaml.
diff --git a/Documentation/devicetree/bindings/regulator/max77650-regulator.yaml b/Documentation/devicetree/bindings/regulator/max77650-regulator.yaml
new file mode 100644
index 000000000000..c0d986948ac8
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/max77650-regulator.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/max77650-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Regulator driver for MAX77650 PMIC from Maxim Integrated.
+
+maintainers:
+ - Bartosz Golaszewski <bgolaszewski@baylibre.com>
+
+description: |
+ This module is part of the MAX77650 MFD device. For more details
+ see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+ The regulator controller is represented as a sub-node of the PMIC node
+ on the device tree.
+
+ The device has a single LDO regulator and a SIMO buck-boost regulator with
+ three independent power rails.
+
+properties:
+ compatible:
+ const: maxim,max77650-regulator
+
+patternProperties:
+ "^regulator@[0-3]$":
+ $ref: "regulator.yaml#"
+
+required:
+ - compatible
+
+examples:
+ - |
+ regulators {
+ compatible = "maxim,max77650-regulator";
+
+ max77650_ldo: regulator@0 {
+ regulator-compatible = "ldo";
+ regulator-name = "max77650-ldo";
+ regulator-min-microvolt = <1350000>;
+ regulator-max-microvolt = <2937500>;
+ };
+
+ max77650_sbb0: regulator@1 {
+ regulator-compatible = "sbb0";
+ regulator-name = "max77650-sbb0";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1587500>;
+ };
+ };
--
2.23.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 4/6] dt-bindings: power: max77650: convert the binding document to yaml
2019-10-15 16:22 [PATCH v2 0/6] dt-bindings: max77650: convert the device-tree bindings to yaml Bartosz Golaszewski
` (2 preceding siblings ...)
2019-10-15 16:22 ` [PATCH v2 3/6] dt-bindings: regulator: " Bartosz Golaszewski
@ 2019-10-15 16:22 ` Bartosz Golaszewski
2019-10-15 19:18 ` Sebastian Reichel
2019-10-15 16:22 ` [PATCH v2 5/6] dt-bindings: leds: " Bartosz Golaszewski
2019-10-15 16:23 ` [PATCH v2 6/6] MAINTAINERS: update the list of maintained files for max77650 Bartosz Golaszewski
5 siblings, 1 reply; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-15 16:22 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Dmitry Torokhov, Jacek Anaszewski,
Pavel Machek, Dan Murphy, Lee Jones, Sebastian Reichel,
Liam Girdwood, Mark Brown
Cc: linux-input, devicetree, linux-kernel, linux-leds, linux-pm,
Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Convert the binding document for MAX77650 charger module to YAML.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
.../power/supply/max77650-charger.txt | 29 +------------
.../power/supply/max77650-charger.yaml | 42 +++++++++++++++++++
2 files changed, 43 insertions(+), 28 deletions(-)
create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
index e6d0fb6ff94e..fbab7d3ac8e3 100644
--- a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
+++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
@@ -1,28 +1 @@
-Battery charger driver for MAX77650 PMIC from Maxim Integrated.
-
-This module is part of the MAX77650 MFD device. For more details
-see Documentation/devicetree/bindings/mfd/max77650.txt.
-
-The charger is represented as a sub-node of the PMIC node on the device tree.
-
-Required properties:
---------------------
-- compatible: Must be "maxim,max77650-charger"
-
-Optional properties:
---------------------
-- input-voltage-min-microvolt: Minimum CHGIN regulation voltage. Must be one
- of: 4000000, 4100000, 4200000, 4300000,
- 4400000, 4500000, 4600000, 4700000.
-- input-current-limit-microamp: CHGIN input current limit (in microamps). Must
- be one of: 95000, 190000, 285000, 380000,
- 475000.
-
-Example:
---------
-
- charger {
- compatible = "maxim,max77650-charger";
- input-voltage-min-microvolt = <4200000>;
- input-current-limit-microamp = <285000>;
- };
+This file was moved to max77650-charger.yaml.
diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml b/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
new file mode 100644
index 000000000000..9dd0dad0f948
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/max77650-charger.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+maintainers:
+ - Bartosz Golaszewski <bgolaszewski@baylibre.com>
+
+description: |
+ This module is part of the MAX77650 MFD device. For more details
+ see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+ The charger is represented as a sub-node of the PMIC node on the device tree.
+
+properties:
+ compatible:
+ const: maxim,max77650-charger
+
+ input-voltage-min-microvolt:
+ description:
+ Minimum CHGIN regulation voltage.
+ enum: [ 4000000, 4100000, 4200000, 4300000,
+ 4400000, 4500000, 4600000, 4700000 ]
+
+ input-current-limit-microamp:
+ description:
+ CHGIN input current limit (in microamps).
+ enum: [ 95000, 190000, 285000, 380000, 475000 ]
+
+required:
+ - compatible
+
+examples:
+ - |
+ charger {
+ compatible = "maxim,max77650-charger";
+ input-voltage-min-microvolt = <4200000>;
+ input-current-limit-microamp = <285000>;
+ };
--
2.23.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 5/6] dt-bindings: leds: max77650: convert the binding document to yaml
2019-10-15 16:22 [PATCH v2 0/6] dt-bindings: max77650: convert the device-tree bindings to yaml Bartosz Golaszewski
` (3 preceding siblings ...)
2019-10-15 16:22 ` [PATCH v2 4/6] dt-bindings: power: " Bartosz Golaszewski
@ 2019-10-15 16:22 ` Bartosz Golaszewski
2019-10-15 16:23 ` [PATCH v2 6/6] MAINTAINERS: update the list of maintained files for max77650 Bartosz Golaszewski
5 siblings, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-15 16:22 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Dmitry Torokhov, Jacek Anaszewski,
Pavel Machek, Dan Murphy, Lee Jones, Sebastian Reichel,
Liam Girdwood, Mark Brown
Cc: linux-input, devicetree, linux-kernel, linux-leds, linux-pm,
Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Convert the binding document for MAX77650 LED module to YAML.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Sebastian Reichel <sre@kernel.org>
---
.../bindings/leds/leds-max77650.txt | 58 +------------
.../bindings/leds/leds-max77650.yaml | 82 +++++++++++++++++++
2 files changed, 83 insertions(+), 57 deletions(-)
create mode 100644 Documentation/devicetree/bindings/leds/leds-max77650.yaml
diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.txt b/Documentation/devicetree/bindings/leds/leds-max77650.txt
index 3a67115cc1da..33d6ff23f0ef 100644
--- a/Documentation/devicetree/bindings/leds/leds-max77650.txt
+++ b/Documentation/devicetree/bindings/leds/leds-max77650.txt
@@ -1,57 +1 @@
-LED driver for MAX77650 PMIC from Maxim Integrated.
-
-This module is part of the MAX77650 MFD device. For more details
-see Documentation/devicetree/bindings/mfd/max77650.txt.
-
-The LED controller is represented as a sub-node of the PMIC node on
-the device tree.
-
-This device has three current sinks.
-
-Required properties:
---------------------
-- compatible: Must be "maxim,max77650-led"
-- #address-cells: Must be <1>.
-- #size-cells: Must be <0>.
-
-Each LED is represented as a sub-node of the LED-controller node. Up to
-three sub-nodes can be defined.
-
-Required properties of the sub-node:
-------------------------------------
-
-- reg: Must be <0>, <1> or <2>.
-
-Optional properties of the sub-node:
-------------------------------------
-
-- label: See Documentation/devicetree/bindings/leds/common.txt
-- linux,default-trigger: See Documentation/devicetree/bindings/leds/common.txt
-
-For more details, please refer to the generic GPIO DT binding document
-<devicetree/bindings/gpio/gpio.txt>.
-
-Example:
---------
-
- leds {
- compatible = "maxim,max77650-led";
- #address-cells = <1>;
- #size-cells = <0>;
-
- led@0 {
- reg = <0>;
- label = "blue:usr0";
- };
-
- led@1 {
- reg = <1>;
- label = "red:usr1";
- linux,default-trigger = "heartbeat";
- };
-
- led@2 {
- reg = <2>;
- label = "green:usr2";
- };
- };
+This file has been moved to leds-max77650.yaml.
diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.yaml b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
new file mode 100644
index 000000000000..bb541ff67f80
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-max77650.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LED driver for MAX77650 PMIC from Maxim Integrated.
+
+maintainers:
+ - Bartosz Golaszewski <bgolaszewski@baylibre.com>
+
+description: |
+ This module is part of the MAX77650 MFD device. For more details
+ see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+ The LED controller is represented as a sub-node of the PMIC node on
+ the device tree.
+
+ This device has three current sinks.
+
+properties:
+ compatible:
+ const: maxim,max77650-led
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+patternProperties:
+ "^led@[0-2]$":
+ type: object
+ description: |
+ Properties for a single LED.
+
+ properties:
+ reg:
+ description:
+ Index of the LED.
+ maxItems: 1
+ minimum: 0
+ maximum: 2
+
+ label:
+ $ref: "/schemas/types.yaml#/definitions/string"
+ description:
+ The label of this LED.
+
+ linux,default-trigger:
+ $ref: "/schemas/types.yaml#/definitions/string"
+ description:
+ String defining the default trigger assigned to this LED.
+
+required:
+ - compatible
+ - "#address-cells"
+ - "#size-cells"
+
+examples:
+ - |
+ leds {
+ compatible = "maxim,max77650-led";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@0 {
+ reg = <0>;
+ label = "blue:usr0";
+ };
+
+ led@1 {
+ reg = <1>;
+ label = "red:usr1";
+ linux,default-trigger = "heartbeat";
+ };
+
+ led@2 {
+ reg = <2>;
+ label = "green:usr2";
+ };
+ };
--
2.23.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 6/6] MAINTAINERS: update the list of maintained files for max77650
2019-10-15 16:22 [PATCH v2 0/6] dt-bindings: max77650: convert the device-tree bindings to yaml Bartosz Golaszewski
` (4 preceding siblings ...)
2019-10-15 16:22 ` [PATCH v2 5/6] dt-bindings: leds: " Bartosz Golaszewski
@ 2019-10-15 16:23 ` Bartosz Golaszewski
5 siblings, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-15 16:23 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Dmitry Torokhov, Jacek Anaszewski,
Pavel Machek, Dan Murphy, Lee Jones, Sebastian Reichel,
Liam Girdwood, Mark Brown
Cc: linux-input, devicetree, linux-kernel, linux-leds, linux-pm,
Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
The DT bindings for MAX77650 MFD have now been converted to YAML.
Update the MAINTAINERS entry for this set of drivers.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a69e6db80c79..c05e6fd6aedb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9903,8 +9903,8 @@ MAXIM MAX77650 PMIC MFD DRIVER
M: Bartosz Golaszewski <bgolaszewski@baylibre.com>
L: linux-kernel@vger.kernel.org
S: Maintained
-F: Documentation/devicetree/bindings/*/*max77650.txt
-F: Documentation/devicetree/bindings/*/max77650*.txt
+F: Documentation/devicetree/bindings/*/*max77650.yaml
+F: Documentation/devicetree/bindings/*/max77650*.yaml
F: include/linux/mfd/max77650.h
F: drivers/mfd/max77650.c
F: drivers/regulator/max77650-regulator.c
--
2.23.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/6] dt-bindings: power: max77650: convert the binding document to yaml
2019-10-15 16:22 ` [PATCH v2 4/6] dt-bindings: power: " Bartosz Golaszewski
@ 2019-10-15 19:18 ` Sebastian Reichel
2019-10-16 8:31 ` Bartosz Golaszewski
0 siblings, 1 reply; 15+ messages in thread
From: Sebastian Reichel @ 2019-10-15 19:18 UTC (permalink / raw)
To: Bartosz Golaszewski, Rob Herring
Cc: Mark Rutland, Dmitry Torokhov, Jacek Anaszewski, Pavel Machek,
Dan Murphy, Lee Jones, Liam Girdwood, Mark Brown, linux-input,
devicetree, linux-kernel, linux-leds, linux-pm,
Bartosz Golaszewski
[-- Attachment #1: Type: text/plain, Size: 3753 bytes --]
Hi,
On Tue, Oct 15, 2019 at 06:22:58PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Convert the binding document for MAX77650 charger module to YAML.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
Looks sensible to me. Assuming this goes through Rob:
Acked-by: Sebastian Reichel <sre@kernel.org>
-- Sebastian
> .../power/supply/max77650-charger.txt | 29 +------------
> .../power/supply/max77650-charger.yaml | 42 +++++++++++++++++++
> 2 files changed, 43 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> index e6d0fb6ff94e..fbab7d3ac8e3 100644
> --- a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> @@ -1,28 +1 @@
> -Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> -
> -This module is part of the MAX77650 MFD device. For more details
> -see Documentation/devicetree/bindings/mfd/max77650.txt.
> -
> -The charger is represented as a sub-node of the PMIC node on the device tree.
> -
> -Required properties:
> ---------------------
> -- compatible: Must be "maxim,max77650-charger"
> -
> -Optional properties:
> ---------------------
> -- input-voltage-min-microvolt: Minimum CHGIN regulation voltage. Must be one
> - of: 4000000, 4100000, 4200000, 4300000,
> - 4400000, 4500000, 4600000, 4700000.
> -- input-current-limit-microamp: CHGIN input current limit (in microamps). Must
> - be one of: 95000, 190000, 285000, 380000,
> - 475000.
> -
> -Example:
> ---------
> -
> - charger {
> - compatible = "maxim,max77650-charger";
> - input-voltage-min-microvolt = <4200000>;
> - input-current-limit-microamp = <285000>;
> - };
> +This file was moved to max77650-charger.yaml.
> diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml b/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
> new file mode 100644
> index 000000000000..9dd0dad0f948
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/max77650-charger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> +
> +maintainers:
> + - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> +
> +description: |
> + This module is part of the MAX77650 MFD device. For more details
> + see Documentation/devicetree/bindings/mfd/max77650.txt.
> +
> + The charger is represented as a sub-node of the PMIC node on the device tree.
> +
> +properties:
> + compatible:
> + const: maxim,max77650-charger
> +
> + input-voltage-min-microvolt:
> + description:
> + Minimum CHGIN regulation voltage.
> + enum: [ 4000000, 4100000, 4200000, 4300000,
> + 4400000, 4500000, 4600000, 4700000 ]
> +
> + input-current-limit-microamp:
> + description:
> + CHGIN input current limit (in microamps).
> + enum: [ 95000, 190000, 285000, 380000, 475000 ]
> +
> +required:
> + - compatible
> +
> +examples:
> + - |
> + charger {
> + compatible = "maxim,max77650-charger";
> + input-voltage-min-microvolt = <4200000>;
> + input-current-limit-microamp = <285000>;
> + };
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document to yaml
2019-10-15 16:22 ` [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document " Bartosz Golaszewski
@ 2019-10-15 21:13 ` Rob Herring
2019-10-15 21:17 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2019-10-15 21:13 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Mark Rutland, Dmitry Torokhov, Jacek Anaszewski, Pavel Machek,
Dan Murphy, Lee Jones, Sebastian Reichel, Liam Girdwood,
Mark Brown, Linux Input, devicetree, linux-kernel,
Linux LED Subsystem, open list:THERMAL, Bartosz Golaszewski
On Tue, Oct 15, 2019 at 11:23 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Convert the binding document for MAX77650 core MFD module to YAML.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> .../devicetree/bindings/mfd/max77650.txt | 47 +----------
> .../devicetree/bindings/mfd/max77650.yaml | 83 +++++++++++++++++++
> 2 files changed, 84 insertions(+), 46 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/max77650.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77650.txt b/Documentation/devicetree/bindings/mfd/max77650.txt
> index b529d8d19335..080871686b3b 100644
> --- a/Documentation/devicetree/bindings/mfd/max77650.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77650.txt
> @@ -1,46 +1 @@
> -MAX77650 ultra low-power PMIC from Maxim Integrated.
> -
> -Required properties:
> --------------------
> -- compatible: Must be "maxim,max77650"
> -- reg: I2C device address.
> -- interrupts: The interrupt on the parent the controller is
> - connected to.
> -- interrupt-controller: Marks the device node as an interrupt controller.
> -- #interrupt-cells: Must be <2>.
> -
> -- gpio-controller: Marks the device node as a gpio controller.
> -- #gpio-cells: Must be <2>. The first cell is the pin number and
> - the second cell is used to specify the gpio active
> - state.
> -
> -Optional properties:
> ---------------------
> -gpio-line-names: Single string containing the name of the GPIO line.
> -
> -The GPIO-controller module is represented as part of the top-level PMIC
> -node. The device exposes a single GPIO line.
> -
> -For device-tree bindings of other sub-modules (regulator, power supply,
> -LEDs and onkey) refer to the binding documents under the respective
> -sub-system directories.
> -
> -For more details on GPIO bindings, please refer to the generic GPIO DT
> -binding document <devicetree/bindings/gpio/gpio.txt>.
> -
> -Example:
> ---------
> -
> - pmic@48 {
> - compatible = "maxim,max77650";
> - reg = <0x48>;
> -
> - interrupt-controller;
> - interrupt-parent = <&gpio2>;
> - #interrupt-cells = <2>;
> - interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> -
> - gpio-controller;
> - #gpio-cells = <2>;
> - gpio-line-names = "max77650-charger";
> - };
> +This file has been moved to max77650.yaml.
We do this for common files with lots of references. I don't think
that applies here.
> diff --git a/Documentation/devicetree/bindings/mfd/max77650.yaml b/Documentation/devicetree/bindings/mfd/max77650.yaml
> new file mode 100644
> index 000000000000..5186ad287ec7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/max77650.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/max77650.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MAX77650 ultra low-power PMIC from Maxim Integrated.
> +
> +maintainers:
> + - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> +
> +description: |
> + This document describes the DT properties of the core MFD controller.
> +
> + The GPIO-controller module is represented as part of the top-level PMIC
> + node. The device exposes a single GPIO line.
> +
> + For device-tree bindings of other sub-modules (regulator, power supply,
> + LEDs and onkey) refer to the binding documents under the respective
> + sub-system directories.
> +
> + For more details on GPIO bindings, please refer to the generic GPIO DT
> + binding document <devicetree/bindings/gpio/gpio.txt>.
> +
> +properties:
> + compatible:
> + const: maxim,max77650
> +
> + reg:
> + description:
> + I2C device address.
> + maxItems: 1
> +
> + interrupts:
> + description:
> + The interrupt on the parent the controller is connected to.
No need for 'description' if there's only one entry and you have
nothing specific about this device.
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> + description:
> + The first cell is the IRQ number, the second cell is the trigger type.
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> + description:
> + The first cell is the pin number and the second cell is used to specify
> + the gpio active state.
> +
> + gpio-line-names:
> + $ref: '/schemas/types.yaml#/definitions/string-array'
*-names already has a type, so you can drop this.
> + maxItems: 1
> + description:
> + Single string containing the name of the GPIO line.
You need to link all the child node schemas into here. Something like this:
onkey:
$ref: ../input/max77650-onkey.yaml
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> + - gpio-controller
> + - "#gpio-cells"
> +
> +examples:
> + - |
> + pmic@48 {
> + compatible = "maxim,max77650";
> + reg = <0x48>;
> +
> + interrupt-controller;
> + interrupt-parent = <&gpio2>;
> + #interrupt-cells = <2>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-line-names = "max77650-charger";
I'd prefer to see a complete example here rather than piecemeal
examples scattered.
Rob
> + };
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document to yaml
2019-10-15 16:22 ` [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document " Bartosz Golaszewski
2019-10-15 21:13 ` Rob Herring
@ 2019-10-15 21:17 ` Rob Herring
2019-10-16 12:55 ` Bartosz Golaszewski
1 sibling, 1 reply; 15+ messages in thread
From: Rob Herring @ 2019-10-15 21:17 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Mark Rutland, Dmitry Torokhov, Jacek Anaszewski, Pavel Machek,
Dan Murphy, Lee Jones, Sebastian Reichel, Liam Girdwood,
Mark Brown, Linux Input, devicetree, linux-kernel,
Linux LED Subsystem, open list:THERMAL, Bartosz Golaszewski
On Tue, Oct 15, 2019 at 11:23 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Convert the binding document for MAX77650 core MFD module to YAML.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> .../devicetree/bindings/mfd/max77650.txt | 47 +----------
> .../devicetree/bindings/mfd/max77650.yaml | 83 +++++++++++++++++++
> 2 files changed, 84 insertions(+), 46 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/max77650.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77650.txt b/Documentation/devicetree/bindings/mfd/max77650.txt
> index b529d8d19335..080871686b3b 100644
> --- a/Documentation/devicetree/bindings/mfd/max77650.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77650.txt
> @@ -1,46 +1 @@
> -MAX77650 ultra low-power PMIC from Maxim Integrated.
> -
> -Required properties:
> --------------------
> -- compatible: Must be "maxim,max77650"
> -- reg: I2C device address.
> -- interrupts: The interrupt on the parent the controller is
> - connected to.
> -- interrupt-controller: Marks the device node as an interrupt controller.
> -- #interrupt-cells: Must be <2>.
> -
> -- gpio-controller: Marks the device node as a gpio controller.
> -- #gpio-cells: Must be <2>. The first cell is the pin number and
> - the second cell is used to specify the gpio active
> - state.
> -
> -Optional properties:
> ---------------------
> -gpio-line-names: Single string containing the name of the GPIO line.
> -
> -The GPIO-controller module is represented as part of the top-level PMIC
> -node. The device exposes a single GPIO line.
> -
> -For device-tree bindings of other sub-modules (regulator, power supply,
> -LEDs and onkey) refer to the binding documents under the respective
> -sub-system directories.
> -
> -For more details on GPIO bindings, please refer to the generic GPIO DT
> -binding document <devicetree/bindings/gpio/gpio.txt>.
> -
> -Example:
> ---------
> -
> - pmic@48 {
> - compatible = "maxim,max77650";
> - reg = <0x48>;
> -
> - interrupt-controller;
> - interrupt-parent = <&gpio2>;
> - #interrupt-cells = <2>;
> - interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> -
> - gpio-controller;
> - #gpio-cells = <2>;
> - gpio-line-names = "max77650-charger";
> - };
> +This file has been moved to max77650.yaml.
> diff --git a/Documentation/devicetree/bindings/mfd/max77650.yaml b/Documentation/devicetree/bindings/mfd/max77650.yaml
> new file mode 100644
> index 000000000000..5186ad287ec7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/max77650.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/max77650.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MAX77650 ultra low-power PMIC from Maxim Integrated.
> +
> +maintainers:
> + - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> +
> +description: |
> + This document describes the DT properties of the core MFD controller.
> +
> + The GPIO-controller module is represented as part of the top-level PMIC
> + node. The device exposes a single GPIO line.
> +
> + For device-tree bindings of other sub-modules (regulator, power supply,
> + LEDs and onkey) refer to the binding documents under the respective
> + sub-system directories.
> +
> + For more details on GPIO bindings, please refer to the generic GPIO DT
> + binding document <devicetree/bindings/gpio/gpio.txt>.
> +
> +properties:
> + compatible:
> + const: maxim,max77650
> +
> + reg:
> + description:
> + I2C device address.
> + maxItems: 1
> +
> + interrupts:
> + description:
> + The interrupt on the parent the controller is connected to.
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> + description:
> + The first cell is the IRQ number, the second cell is the trigger type.
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> + description:
> + The first cell is the pin number and the second cell is used to specify
> + the gpio active state.
> +
> + gpio-line-names:
> + $ref: '/schemas/types.yaml#/definitions/string-array'
> + maxItems: 1
> + description:
> + Single string containing the name of the GPIO line.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> + - gpio-controller
> + - "#gpio-cells"
> +
> +examples:
> + - |
> + pmic@48 {
> + compatible = "maxim,max77650";
> + reg = <0x48>;
> +
> + interrupt-controller;
> + interrupt-parent = <&gpio2>;
> + #interrupt-cells = <2>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Examples are built now. Run 'make dt_binding_check' on bindings before
sending them:
Error: Documentation/devicetree/bindings/mfd/max77650.example.dts:24.29-30
syntax error
FATAL ERROR: Unable to parse input tree
scripts/Makefile.lib:321: recipe for target
'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml'
failed
make[1]: *** [Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml]
Error 1
You need to include any includes that you use.
Rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/6] dt-bindings: power: max77650: convert the binding document to yaml
2019-10-15 19:18 ` Sebastian Reichel
@ 2019-10-16 8:31 ` Bartosz Golaszewski
0 siblings, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-16 8:31 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Bartosz Golaszewski, Rob Herring, Mark Rutland, Dmitry Torokhov,
Jacek Anaszewski, Pavel Machek, Dan Murphy, Lee Jones,
Liam Girdwood, Mark Brown, Linux Input, linux-devicetree, LKML,
Linux LED Subsystem, linux-pm
wt., 15 paź 2019 o 21:18 Sebastian Reichel <sre@kernel.org> napisał(a):
>
> Hi,
>
> On Tue, Oct 15, 2019 at 06:22:58PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Convert the binding document for MAX77650 charger module to YAML.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
>
> Looks sensible to me. Assuming this goes through Rob:
>
> Acked-by: Sebastian Reichel <sre@kernel.org>
Oops, I added your ack for v1 to the leds patch in v2 by mistake.
There'll be a v3 though so no worries.
Thanks!
Bart
>
> -- Sebastian
>
> > .../power/supply/max77650-charger.txt | 29 +------------
> > .../power/supply/max77650-charger.yaml | 42 +++++++++++++++++++
> > 2 files changed, 43 insertions(+), 28 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > index e6d0fb6ff94e..fbab7d3ac8e3 100644
> > --- a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > @@ -1,28 +1 @@
> > -Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> > -
> > -This module is part of the MAX77650 MFD device. For more details
> > -see Documentation/devicetree/bindings/mfd/max77650.txt.
> > -
> > -The charger is represented as a sub-node of the PMIC node on the device tree.
> > -
> > -Required properties:
> > ---------------------
> > -- compatible: Must be "maxim,max77650-charger"
> > -
> > -Optional properties:
> > ---------------------
> > -- input-voltage-min-microvolt: Minimum CHGIN regulation voltage. Must be one
> > - of: 4000000, 4100000, 4200000, 4300000,
> > - 4400000, 4500000, 4600000, 4700000.
> > -- input-current-limit-microamp: CHGIN input current limit (in microamps). Must
> > - be one of: 95000, 190000, 285000, 380000,
> > - 475000.
> > -
> > -Example:
> > ---------
> > -
> > - charger {
> > - compatible = "maxim,max77650-charger";
> > - input-voltage-min-microvolt = <4200000>;
> > - input-current-limit-microamp = <285000>;
> > - };
> > +This file was moved to max77650-charger.yaml.
> > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml b/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
> > new file mode 100644
> > index 000000000000..9dd0dad0f948
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/max77650-charger.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> > +
> > +maintainers:
> > + - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > +
> > +description: |
> > + This module is part of the MAX77650 MFD device. For more details
> > + see Documentation/devicetree/bindings/mfd/max77650.txt.
> > +
> > + The charger is represented as a sub-node of the PMIC node on the device tree.
> > +
> > +properties:
> > + compatible:
> > + const: maxim,max77650-charger
> > +
> > + input-voltage-min-microvolt:
> > + description:
> > + Minimum CHGIN regulation voltage.
> > + enum: [ 4000000, 4100000, 4200000, 4300000,
> > + 4400000, 4500000, 4600000, 4700000 ]
> > +
> > + input-current-limit-microamp:
> > + description:
> > + CHGIN input current limit (in microamps).
> > + enum: [ 95000, 190000, 285000, 380000, 475000 ]
> > +
> > +required:
> > + - compatible
> > +
> > +examples:
> > + - |
> > + charger {
> > + compatible = "maxim,max77650-charger";
> > + input-voltage-min-microvolt = <4200000>;
> > + input-current-limit-microamp = <285000>;
> > + };
> > --
> > 2.23.0
> >
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document to yaml
2019-10-15 21:17 ` Rob Herring
@ 2019-10-16 12:55 ` Bartosz Golaszewski
2019-10-16 13:51 ` Rob Herring
0 siblings, 1 reply; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-16 12:55 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Dmitry Torokhov, Jacek Anaszewski, Pavel Machek,
Dan Murphy, Lee Jones, Sebastian Reichel, Liam Girdwood,
Mark Brown, Linux Input, devicetree, linux-kernel,
Linux LED Subsystem, open list:THERMAL, Bartosz Golaszewski
wt., 15 paź 2019 o 23:17 Rob Herring <robh+dt@kernel.org> napisał(a):
>
> On Tue, Oct 15, 2019 at 11:23 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Convert the binding document for MAX77650 core MFD module to YAML.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> > .../devicetree/bindings/mfd/max77650.txt | 47 +----------
> > .../devicetree/bindings/mfd/max77650.yaml | 83 +++++++++++++++++++
> > 2 files changed, 84 insertions(+), 46 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/mfd/max77650.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/max77650.txt b/Documentation/devicetree/bindings/mfd/max77650.txt
> > index b529d8d19335..080871686b3b 100644
> > --- a/Documentation/devicetree/bindings/mfd/max77650.txt
> > +++ b/Documentation/devicetree/bindings/mfd/max77650.txt
> > @@ -1,46 +1 @@
> > -MAX77650 ultra low-power PMIC from Maxim Integrated.
> > -
> > -Required properties:
> > --------------------
> > -- compatible: Must be "maxim,max77650"
> > -- reg: I2C device address.
> > -- interrupts: The interrupt on the parent the controller is
> > - connected to.
> > -- interrupt-controller: Marks the device node as an interrupt controller.
> > -- #interrupt-cells: Must be <2>.
> > -
> > -- gpio-controller: Marks the device node as a gpio controller.
> > -- #gpio-cells: Must be <2>. The first cell is the pin number and
> > - the second cell is used to specify the gpio active
> > - state.
> > -
> > -Optional properties:
> > ---------------------
> > -gpio-line-names: Single string containing the name of the GPIO line.
> > -
> > -The GPIO-controller module is represented as part of the top-level PMIC
> > -node. The device exposes a single GPIO line.
> > -
> > -For device-tree bindings of other sub-modules (regulator, power supply,
> > -LEDs and onkey) refer to the binding documents under the respective
> > -sub-system directories.
> > -
> > -For more details on GPIO bindings, please refer to the generic GPIO DT
> > -binding document <devicetree/bindings/gpio/gpio.txt>.
> > -
> > -Example:
> > ---------
> > -
> > - pmic@48 {
> > - compatible = "maxim,max77650";
> > - reg = <0x48>;
> > -
> > - interrupt-controller;
> > - interrupt-parent = <&gpio2>;
> > - #interrupt-cells = <2>;
> > - interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > -
> > - gpio-controller;
> > - #gpio-cells = <2>;
> > - gpio-line-names = "max77650-charger";
> > - };
> > +This file has been moved to max77650.yaml.
> > diff --git a/Documentation/devicetree/bindings/mfd/max77650.yaml b/Documentation/devicetree/bindings/mfd/max77650.yaml
> > new file mode 100644
> > index 000000000000..5186ad287ec7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/max77650.yaml
> > @@ -0,0 +1,83 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/max77650.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MAX77650 ultra low-power PMIC from Maxim Integrated.
> > +
> > +maintainers:
> > + - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > +
> > +description: |
> > + This document describes the DT properties of the core MFD controller.
> > +
> > + The GPIO-controller module is represented as part of the top-level PMIC
> > + node. The device exposes a single GPIO line.
> > +
> > + For device-tree bindings of other sub-modules (regulator, power supply,
> > + LEDs and onkey) refer to the binding documents under the respective
> > + sub-system directories.
> > +
> > + For more details on GPIO bindings, please refer to the generic GPIO DT
> > + binding document <devicetree/bindings/gpio/gpio.txt>.
> > +
> > +properties:
> > + compatible:
> > + const: maxim,max77650
> > +
> > + reg:
> > + description:
> > + I2C device address.
> > + maxItems: 1
> > +
> > + interrupts:
> > + description:
> > + The interrupt on the parent the controller is connected to.
> > + maxItems: 1
> > +
> > + interrupt-controller: true
> > +
> > + "#interrupt-cells":
> > + const: 2
> > + description:
> > + The first cell is the IRQ number, the second cell is the trigger type.
> > +
> > + gpio-controller: true
> > +
> > + "#gpio-cells":
> > + const: 2
> > + description:
> > + The first cell is the pin number and the second cell is used to specify
> > + the gpio active state.
> > +
> > + gpio-line-names:
> > + $ref: '/schemas/types.yaml#/definitions/string-array'
> > + maxItems: 1
> > + description:
> > + Single string containing the name of the GPIO line.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - interrupt-controller
> > + - "#interrupt-cells"
> > + - gpio-controller
> > + - "#gpio-cells"
> > +
> > +examples:
> > + - |
> > + pmic@48 {
> > + compatible = "maxim,max77650";
> > + reg = <0x48>;
> > +
> > + interrupt-controller;
> > + interrupt-parent = <&gpio2>;
> > + #interrupt-cells = <2>;
> > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>
> Examples are built now. Run 'make dt_binding_check' on bindings before
> sending them:
>
> Error: Documentation/devicetree/bindings/mfd/max77650.example.dts:24.29-30
> syntax error
> FATAL ERROR: Unable to parse input tree
> scripts/Makefile.lib:321: recipe for target
> 'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml'
> failed
> make[1]: *** [Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml]
> Error 1
>
> You need to include any includes that you use.
>
> Rob
Hi Rob,
thanks for the review.
I'm on v5.4-rc3 and when running dt_binding_check, the error I'm
getting is this:
# make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/max77650.yaml
SCHEMA Documentation/devicetree/bindings/processed-schema.yaml
CHKDT Documentation/devicetree/bindings/mfd/max77650.yaml
make[1]: *** No rule to make target
'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml',
needed by '__build'. Stop.
make: *** [Makefile:1263: dt_binding_check] Error 2
Is this caused by the same issue or am I missing something?
Bartosz
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document to yaml
2019-10-16 12:55 ` Bartosz Golaszewski
@ 2019-10-16 13:51 ` Rob Herring
2019-10-16 15:28 ` Bartosz Golaszewski
0 siblings, 1 reply; 15+ messages in thread
From: Rob Herring @ 2019-10-16 13:51 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Mark Rutland, Dmitry Torokhov, Jacek Anaszewski, Pavel Machek,
Dan Murphy, Lee Jones, Sebastian Reichel, Liam Girdwood,
Mark Brown, Linux Input, devicetree, linux-kernel,
Linux LED Subsystem, open list:THERMAL, Bartosz Golaszewski
On Wed, Oct 16, 2019 at 7:55 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> wt., 15 paź 2019 o 23:17 Rob Herring <robh+dt@kernel.org> napisał(a):
> >
> > On Tue, Oct 15, 2019 at 11:23 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > Convert the binding document for MAX77650 core MFD module to YAML.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > ---
> > > .../devicetree/bindings/mfd/max77650.txt | 47 +----------
> > > .../devicetree/bindings/mfd/max77650.yaml | 83 +++++++++++++++++++
> > > 2 files changed, 84 insertions(+), 46 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/mfd/max77650.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/max77650.txt b/Documentation/devicetree/bindings/mfd/max77650.txt
> > > index b529d8d19335..080871686b3b 100644
> > > --- a/Documentation/devicetree/bindings/mfd/max77650.txt
> > > +++ b/Documentation/devicetree/bindings/mfd/max77650.txt
> > > @@ -1,46 +1 @@
> > > -MAX77650 ultra low-power PMIC from Maxim Integrated.
> > > -
> > > -Required properties:
> > > --------------------
> > > -- compatible: Must be "maxim,max77650"
> > > -- reg: I2C device address.
> > > -- interrupts: The interrupt on the parent the controller is
> > > - connected to.
> > > -- interrupt-controller: Marks the device node as an interrupt controller.
> > > -- #interrupt-cells: Must be <2>.
> > > -
> > > -- gpio-controller: Marks the device node as a gpio controller.
> > > -- #gpio-cells: Must be <2>. The first cell is the pin number and
> > > - the second cell is used to specify the gpio active
> > > - state.
> > > -
> > > -Optional properties:
> > > ---------------------
> > > -gpio-line-names: Single string containing the name of the GPIO line.
> > > -
> > > -The GPIO-controller module is represented as part of the top-level PMIC
> > > -node. The device exposes a single GPIO line.
> > > -
> > > -For device-tree bindings of other sub-modules (regulator, power supply,
> > > -LEDs and onkey) refer to the binding documents under the respective
> > > -sub-system directories.
> > > -
> > > -For more details on GPIO bindings, please refer to the generic GPIO DT
> > > -binding document <devicetree/bindings/gpio/gpio.txt>.
> > > -
> > > -Example:
> > > ---------
> > > -
> > > - pmic@48 {
> > > - compatible = "maxim,max77650";
> > > - reg = <0x48>;
> > > -
> > > - interrupt-controller;
> > > - interrupt-parent = <&gpio2>;
> > > - #interrupt-cells = <2>;
> > > - interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > > -
> > > - gpio-controller;
> > > - #gpio-cells = <2>;
> > > - gpio-line-names = "max77650-charger";
> > > - };
> > > +This file has been moved to max77650.yaml.
> > > diff --git a/Documentation/devicetree/bindings/mfd/max77650.yaml b/Documentation/devicetree/bindings/mfd/max77650.yaml
> > > new file mode 100644
> > > index 000000000000..5186ad287ec7
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/max77650.yaml
> > > @@ -0,0 +1,83 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mfd/max77650.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: MAX77650 ultra low-power PMIC from Maxim Integrated.
> > > +
> > > +maintainers:
> > > + - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > +
> > > +description: |
> > > + This document describes the DT properties of the core MFD controller.
> > > +
> > > + The GPIO-controller module is represented as part of the top-level PMIC
> > > + node. The device exposes a single GPIO line.
> > > +
> > > + For device-tree bindings of other sub-modules (regulator, power supply,
> > > + LEDs and onkey) refer to the binding documents under the respective
> > > + sub-system directories.
> > > +
> > > + For more details on GPIO bindings, please refer to the generic GPIO DT
> > > + binding document <devicetree/bindings/gpio/gpio.txt>.
> > > +
> > > +properties:
> > > + compatible:
> > > + const: maxim,max77650
> > > +
> > > + reg:
> > > + description:
> > > + I2C device address.
> > > + maxItems: 1
> > > +
> > > + interrupts:
> > > + description:
> > > + The interrupt on the parent the controller is connected to.
> > > + maxItems: 1
> > > +
> > > + interrupt-controller: true
> > > +
> > > + "#interrupt-cells":
> > > + const: 2
> > > + description:
> > > + The first cell is the IRQ number, the second cell is the trigger type.
> > > +
> > > + gpio-controller: true
> > > +
> > > + "#gpio-cells":
> > > + const: 2
> > > + description:
> > > + The first cell is the pin number and the second cell is used to specify
> > > + the gpio active state.
> > > +
> > > + gpio-line-names:
> > > + $ref: '/schemas/types.yaml#/definitions/string-array'
> > > + maxItems: 1
> > > + description:
> > > + Single string containing the name of the GPIO line.
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - interrupts
> > > + - interrupt-controller
> > > + - "#interrupt-cells"
> > > + - gpio-controller
> > > + - "#gpio-cells"
> > > +
> > > +examples:
> > > + - |
> > > + pmic@48 {
> > > + compatible = "maxim,max77650";
> > > + reg = <0x48>;
> > > +
> > > + interrupt-controller;
> > > + interrupt-parent = <&gpio2>;
> > > + #interrupt-cells = <2>;
> > > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> >
> > Examples are built now. Run 'make dt_binding_check' on bindings before
> > sending them:
> >
> > Error: Documentation/devicetree/bindings/mfd/max77650.example.dts:24.29-30
> > syntax error
> > FATAL ERROR: Unable to parse input tree
> > scripts/Makefile.lib:321: recipe for target
> > 'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml'
> > failed
> > make[1]: *** [Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml]
> > Error 1
> >
> > You need to include any includes that you use.
> >
> > Rob
>
> Hi Rob,
>
> thanks for the review.
>
> I'm on v5.4-rc3 and when running dt_binding_check, the error I'm
> getting is this:
>
> # make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/max77650.yaml
> SCHEMA Documentation/devicetree/bindings/processed-schema.yaml
> CHKDT Documentation/devicetree/bindings/mfd/max77650.yaml
> make[1]: *** No rule to make target
> 'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml',
> needed by '__build'. Stop.
> make: *** [Makefile:1263: dt_binding_check] Error 2
>
> Is this caused by the same issue or am I missing something?
I believe that's because dtc needs to be built with libyaml support.
Rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document to yaml
2019-10-16 13:51 ` Rob Herring
@ 2019-10-16 15:28 ` Bartosz Golaszewski
2019-10-16 15:48 ` Rob Herring
0 siblings, 1 reply; 15+ messages in thread
From: Bartosz Golaszewski @ 2019-10-16 15:28 UTC (permalink / raw)
To: Rob Herring
Cc: Bartosz Golaszewski, Mark Rutland, Dmitry Torokhov,
Jacek Anaszewski, Pavel Machek, Dan Murphy, Lee Jones,
Sebastian Reichel, Liam Girdwood, Mark Brown, Linux Input,
devicetree, linux-kernel, Linux LED Subsystem, open list:THERMAL
śr., 16 paź 2019 o 15:51 Rob Herring <robh+dt@kernel.org> napisał(a):
>
> On Wed, Oct 16, 2019 at 7:55 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > wt., 15 paź 2019 o 23:17 Rob Herring <robh+dt@kernel.org> napisał(a):
> > >
> > > On Tue, Oct 15, 2019 at 11:23 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > >
> > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > >
> > > > Convert the binding document for MAX77650 core MFD module to YAML.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > ---
> > > > .../devicetree/bindings/mfd/max77650.txt | 47 +----------
> > > > .../devicetree/bindings/mfd/max77650.yaml | 83 +++++++++++++++++++
> > > > 2 files changed, 84 insertions(+), 46 deletions(-)
> > > > create mode 100644 Documentation/devicetree/bindings/mfd/max77650.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/mfd/max77650.txt b/Documentation/devicetree/bindings/mfd/max77650.txt
> > > > index b529d8d19335..080871686b3b 100644
> > > > --- a/Documentation/devicetree/bindings/mfd/max77650.txt
> > > > +++ b/Documentation/devicetree/bindings/mfd/max77650.txt
> > > > @@ -1,46 +1 @@
> > > > -MAX77650 ultra low-power PMIC from Maxim Integrated.
> > > > -
> > > > -Required properties:
> > > > --------------------
> > > > -- compatible: Must be "maxim,max77650"
> > > > -- reg: I2C device address.
> > > > -- interrupts: The interrupt on the parent the controller is
> > > > - connected to.
> > > > -- interrupt-controller: Marks the device node as an interrupt controller.
> > > > -- #interrupt-cells: Must be <2>.
> > > > -
> > > > -- gpio-controller: Marks the device node as a gpio controller.
> > > > -- #gpio-cells: Must be <2>. The first cell is the pin number and
> > > > - the second cell is used to specify the gpio active
> > > > - state.
> > > > -
> > > > -Optional properties:
> > > > ---------------------
> > > > -gpio-line-names: Single string containing the name of the GPIO line.
> > > > -
> > > > -The GPIO-controller module is represented as part of the top-level PMIC
> > > > -node. The device exposes a single GPIO line.
> > > > -
> > > > -For device-tree bindings of other sub-modules (regulator, power supply,
> > > > -LEDs and onkey) refer to the binding documents under the respective
> > > > -sub-system directories.
> > > > -
> > > > -For more details on GPIO bindings, please refer to the generic GPIO DT
> > > > -binding document <devicetree/bindings/gpio/gpio.txt>.
> > > > -
> > > > -Example:
> > > > ---------
> > > > -
> > > > - pmic@48 {
> > > > - compatible = "maxim,max77650";
> > > > - reg = <0x48>;
> > > > -
> > > > - interrupt-controller;
> > > > - interrupt-parent = <&gpio2>;
> > > > - #interrupt-cells = <2>;
> > > > - interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > > > -
> > > > - gpio-controller;
> > > > - #gpio-cells = <2>;
> > > > - gpio-line-names = "max77650-charger";
> > > > - };
> > > > +This file has been moved to max77650.yaml.
> > > > diff --git a/Documentation/devicetree/bindings/mfd/max77650.yaml b/Documentation/devicetree/bindings/mfd/max77650.yaml
> > > > new file mode 100644
> > > > index 000000000000..5186ad287ec7
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/mfd/max77650.yaml
> > > > @@ -0,0 +1,83 @@
> > > > +# SPDX-License-Identifier: GPL-2.0
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/mfd/max77650.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: MAX77650 ultra low-power PMIC from Maxim Integrated.
> > > > +
> > > > +maintainers:
> > > > + - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > +
> > > > +description: |
> > > > + This document describes the DT properties of the core MFD controller.
> > > > +
> > > > + The GPIO-controller module is represented as part of the top-level PMIC
> > > > + node. The device exposes a single GPIO line.
> > > > +
> > > > + For device-tree bindings of other sub-modules (regulator, power supply,
> > > > + LEDs and onkey) refer to the binding documents under the respective
> > > > + sub-system directories.
> > > > +
> > > > + For more details on GPIO bindings, please refer to the generic GPIO DT
> > > > + binding document <devicetree/bindings/gpio/gpio.txt>.
> > > > +
> > > > +properties:
> > > > + compatible:
> > > > + const: maxim,max77650
> > > > +
> > > > + reg:
> > > > + description:
> > > > + I2C device address.
> > > > + maxItems: 1
> > > > +
> > > > + interrupts:
> > > > + description:
> > > > + The interrupt on the parent the controller is connected to.
> > > > + maxItems: 1
> > > > +
> > > > + interrupt-controller: true
> > > > +
> > > > + "#interrupt-cells":
> > > > + const: 2
> > > > + description:
> > > > + The first cell is the IRQ number, the second cell is the trigger type.
> > > > +
> > > > + gpio-controller: true
> > > > +
> > > > + "#gpio-cells":
> > > > + const: 2
> > > > + description:
> > > > + The first cell is the pin number and the second cell is used to specify
> > > > + the gpio active state.
> > > > +
> > > > + gpio-line-names:
> > > > + $ref: '/schemas/types.yaml#/definitions/string-array'
> > > > + maxItems: 1
> > > > + description:
> > > > + Single string containing the name of the GPIO line.
> > > > +
> > > > +required:
> > > > + - compatible
> > > > + - reg
> > > > + - interrupts
> > > > + - interrupt-controller
> > > > + - "#interrupt-cells"
> > > > + - gpio-controller
> > > > + - "#gpio-cells"
> > > > +
> > > > +examples:
> > > > + - |
> > > > + pmic@48 {
> > > > + compatible = "maxim,max77650";
> > > > + reg = <0x48>;
> > > > +
> > > > + interrupt-controller;
> > > > + interrupt-parent = <&gpio2>;
> > > > + #interrupt-cells = <2>;
> > > > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > >
> > > Examples are built now. Run 'make dt_binding_check' on bindings before
> > > sending them:
> > >
> > > Error: Documentation/devicetree/bindings/mfd/max77650.example.dts:24.29-30
> > > syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > scripts/Makefile.lib:321: recipe for target
> > > 'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml'
> > > failed
> > > make[1]: *** [Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml]
> > > Error 1
> > >
> > > You need to include any includes that you use.
> > >
> > > Rob
> >
> > Hi Rob,
> >
> > thanks for the review.
> >
> > I'm on v5.4-rc3 and when running dt_binding_check, the error I'm
> > getting is this:
> >
> > # make dt_binding_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/max77650.yaml
> > SCHEMA Documentation/devicetree/bindings/processed-schema.yaml
> > CHKDT Documentation/devicetree/bindings/mfd/max77650.yaml
> > make[1]: *** No rule to make target
> > 'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml',
> > needed by '__build'. Stop.
> > make: *** [Makefile:1263: dt_binding_check] Error 2
> >
> > Is this caused by the same issue or am I missing something?
>
> I believe that's because dtc needs to be built with libyaml support.
>
Indeed, I didn't have the development package installed, but
surprisingly I didn't get the warning from scripts/dtc/Makefile about
that either.
Bart
> Rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document to yaml
2019-10-16 15:28 ` Bartosz Golaszewski
@ 2019-10-16 15:48 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2019-10-16 15:48 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Bartosz Golaszewski, Mark Rutland, Dmitry Torokhov,
Jacek Anaszewski, Pavel Machek, Dan Murphy, Lee Jones,
Sebastian Reichel, Liam Girdwood, Mark Brown, Linux Input,
devicetree, linux-kernel, Linux LED Subsystem, open list:THERMAL
On Wed, Oct 16, 2019 at 10:29 AM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
>
> śr., 16 paź 2019 o 15:51 Rob Herring <robh+dt@kernel.org> napisał(a):
> >
> > On Wed, Oct 16, 2019 at 7:55 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > wt., 15 paź 2019 o 23:17 Rob Herring <robh+dt@kernel.org> napisał(a):
> > > >
> > > > On Tue, Oct 15, 2019 at 11:23 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > >
> > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > >
> > > > > Convert the binding document for MAX77650 core MFD module to YAML.
> > > > >
> > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > ---
> > > > > .../devicetree/bindings/mfd/max77650.txt | 47 +----------
> > > > > .../devicetree/bindings/mfd/max77650.yaml | 83 +++++++++++++++++++
> > > > > 2 files changed, 84 insertions(+), 46 deletions(-)
> > > > > create mode 100644 Documentation/devicetree/bindings/mfd/max77650.yaml
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/mfd/max77650.txt b/Documentation/devicetree/bindings/mfd/max77650.txt
> > > > > index b529d8d19335..080871686b3b 100644
> > > > > --- a/Documentation/devicetree/bindings/mfd/max77650.txt
> > > > > +++ b/Documentation/devicetree/bindings/mfd/max77650.txt
> > > > > @@ -1,46 +1 @@
> > > > > -MAX77650 ultra low-power PMIC from Maxim Integrated.
> > > > > -
> > > > > -Required properties:
> > > > > --------------------
> > > > > -- compatible: Must be "maxim,max77650"
> > > > > -- reg: I2C device address.
> > > > > -- interrupts: The interrupt on the parent the controller is
> > > > > - connected to.
> > > > > -- interrupt-controller: Marks the device node as an interrupt controller.
> > > > > -- #interrupt-cells: Must be <2>.
> > > > > -
> > > > > -- gpio-controller: Marks the device node as a gpio controller.
> > > > > -- #gpio-cells: Must be <2>. The first cell is the pin number and
> > > > > - the second cell is used to specify the gpio active
> > > > > - state.
> > > > > -
> > > > > -Optional properties:
> > > > > ---------------------
> > > > > -gpio-line-names: Single string containing the name of the GPIO line.
> > > > > -
> > > > > -The GPIO-controller module is represented as part of the top-level PMIC
> > > > > -node. The device exposes a single GPIO line.
> > > > > -
> > > > > -For device-tree bindings of other sub-modules (regulator, power supply,
> > > > > -LEDs and onkey) refer to the binding documents under the respective
> > > > > -sub-system directories.
> > > > > -
> > > > > -For more details on GPIO bindings, please refer to the generic GPIO DT
> > > > > -binding document <devicetree/bindings/gpio/gpio.txt>.
> > > > > -
> > > > > -Example:
> > > > > ---------
> > > > > -
> > > > > - pmic@48 {
> > > > > - compatible = "maxim,max77650";
> > > > > - reg = <0x48>;
> > > > > -
> > > > > - interrupt-controller;
> > > > > - interrupt-parent = <&gpio2>;
> > > > > - #interrupt-cells = <2>;
> > > > > - interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > > > > -
> > > > > - gpio-controller;
> > > > > - #gpio-cells = <2>;
> > > > > - gpio-line-names = "max77650-charger";
> > > > > - };
> > > > > +This file has been moved to max77650.yaml.
> > > > > diff --git a/Documentation/devicetree/bindings/mfd/max77650.yaml b/Documentation/devicetree/bindings/mfd/max77650.yaml
> > > > > new file mode 100644
> > > > > index 000000000000..5186ad287ec7
> > > > > --- /dev/null
> > > > > +++ b/Documentation/devicetree/bindings/mfd/max77650.yaml
> > > > > @@ -0,0 +1,83 @@
> > > > > +# SPDX-License-Identifier: GPL-2.0
> > > > > +%YAML 1.2
> > > > > +---
> > > > > +$id: http://devicetree.org/schemas/mfd/max77650.yaml#
> > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > > +
> > > > > +title: MAX77650 ultra low-power PMIC from Maxim Integrated.
> > > > > +
> > > > > +maintainers:
> > > > > + - Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > +
> > > > > +description: |
> > > > > + This document describes the DT properties of the core MFD controller.
> > > > > +
> > > > > + The GPIO-controller module is represented as part of the top-level PMIC
> > > > > + node. The device exposes a single GPIO line.
> > > > > +
> > > > > + For device-tree bindings of other sub-modules (regulator, power supply,
> > > > > + LEDs and onkey) refer to the binding documents under the respective
> > > > > + sub-system directories.
> > > > > +
> > > > > + For more details on GPIO bindings, please refer to the generic GPIO DT
> > > > > + binding document <devicetree/bindings/gpio/gpio.txt>.
> > > > > +
> > > > > +properties:
> > > > > + compatible:
> > > > > + const: maxim,max77650
> > > > > +
> > > > > + reg:
> > > > > + description:
> > > > > + I2C device address.
> > > > > + maxItems: 1
> > > > > +
> > > > > + interrupts:
> > > > > + description:
> > > > > + The interrupt on the parent the controller is connected to.
> > > > > + maxItems: 1
> > > > > +
> > > > > + interrupt-controller: true
> > > > > +
> > > > > + "#interrupt-cells":
> > > > > + const: 2
> > > > > + description:
> > > > > + The first cell is the IRQ number, the second cell is the trigger type.
> > > > > +
> > > > > + gpio-controller: true
> > > > > +
> > > > > + "#gpio-cells":
> > > > > + const: 2
> > > > > + description:
> > > > > + The first cell is the pin number and the second cell is used to specify
> > > > > + the gpio active state.
> > > > > +
> > > > > + gpio-line-names:
> > > > > + $ref: '/schemas/types.yaml#/definitions/string-array'
> > > > > + maxItems: 1
> > > > > + description:
> > > > > + Single string containing the name of the GPIO line.
> > > > > +
> > > > > +required:
> > > > > + - compatible
> > > > > + - reg
> > > > > + - interrupts
> > > > > + - interrupt-controller
> > > > > + - "#interrupt-cells"
> > > > > + - gpio-controller
> > > > > + - "#gpio-cells"
> > > > > +
> > > > > +examples:
> > > > > + - |
> > > > > + pmic@48 {
> > > > > + compatible = "maxim,max77650";
> > > > > + reg = <0x48>;
> > > > > +
> > > > > + interrupt-controller;
> > > > > + interrupt-parent = <&gpio2>;
> > > > > + #interrupt-cells = <2>;
> > > > > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > > >
> > > > Examples are built now. Run 'make dt_binding_check' on bindings before
> > > > sending them:
> > > >
> > > > Error: Documentation/devicetree/bindings/mfd/max77650.example.dts:24.29-30
> > > > syntax error
> > > > FATAL ERROR: Unable to parse input tree
> > > > scripts/Makefile.lib:321: recipe for target
> > > > 'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml'
> > > > failed
> > > > make[1]: *** [Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml]
> > > > Error 1
> > > >
> > > > You need to include any includes that you use.
> > > >
> > > > Rob
> > >
> > > Hi Rob,
> > >
> > > thanks for the review.
> > >
> > > I'm on v5.4-rc3 and when running dt_binding_check, the error I'm
> > > getting is this:
> > >
> > > # make dt_binding_check
> > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/max77650.yaml
> > > SCHEMA Documentation/devicetree/bindings/processed-schema.yaml
> > > CHKDT Documentation/devicetree/bindings/mfd/max77650.yaml
> > > make[1]: *** No rule to make target
> > > 'Documentation/devicetree/bindings/mfd/max77650.example.dt.yaml',
> > > needed by '__build'. Stop.
> > > make: *** [Makefile:1263: dt_binding_check] Error 2
> > >
> > > Is this caused by the same issue or am I missing something?
> >
> > I believe that's because dtc needs to be built with libyaml support.
> >
>
> Indeed, I didn't have the development package installed, but
> surprisingly I didn't get the warning from scripts/dtc/Makefile about
> that either.
That's because CHECK_DTBS only gets set for 'dtbs_check' and not
'dt_binding_check'. I'm testing whether I can add it. The issue is I
also want to enable 'dt_binding_check', but not 'dtbs_check' for
all{yes,mod}config. I guess I need 2 variables or some other approach.
Rob
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-10-16 15:49 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 16:22 [PATCH v2 0/6] dt-bindings: max77650: convert the device-tree bindings to yaml Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 1/6] dt-bindings: mfd: max77650: convert the binding document " Bartosz Golaszewski
2019-10-15 21:13 ` Rob Herring
2019-10-15 21:17 ` Rob Herring
2019-10-16 12:55 ` Bartosz Golaszewski
2019-10-16 13:51 ` Rob Herring
2019-10-16 15:28 ` Bartosz Golaszewski
2019-10-16 15:48 ` Rob Herring
2019-10-15 16:22 ` [PATCH v2 2/6] dt-bindings: input: " Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 3/6] dt-bindings: regulator: " Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 4/6] dt-bindings: power: " Bartosz Golaszewski
2019-10-15 19:18 ` Sebastian Reichel
2019-10-16 8:31 ` Bartosz Golaszewski
2019-10-15 16:22 ` [PATCH v2 5/6] dt-bindings: leds: " Bartosz Golaszewski
2019-10-15 16:23 ` [PATCH v2 6/6] MAINTAINERS: update the list of maintained files for max77650 Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.