* [PATCH] gpio: ixp4xx: remove redundant dev_err message
@ 2019-07-31 9:47 Ding Xiang
2019-07-31 10:05 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Ding Xiang @ 2019-07-31 9:47 UTC (permalink / raw)
To: linus.walleij, bgolaszewski; +Cc: linux-gpio, linux-kernel
devm_ioremap_resource already contains error message, so remove
the redundant dev_err message
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/gpio/gpio-ixp4xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
index 670c2a8..2b2b89b 100644
--- a/drivers/gpio/gpio-ixp4xx.c
+++ b/drivers/gpio/gpio-ixp4xx.c
@@ -321,10 +321,8 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
g->base = devm_ioremap_resource(dev, res);
- if (IS_ERR(g->base)) {
- dev_err(dev, "ioremap error\n");
+ if (IS_ERR(g->base))
return PTR_ERR(g->base);
- }
/*
* Make sure GPIO 14 and 15 are NOT used as clocks but GPIO on
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: ixp4xx: remove redundant dev_err message
2019-07-31 9:47 [PATCH] gpio: ixp4xx: remove redundant dev_err message Ding Xiang
@ 2019-07-31 10:05 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-07-31 10:05 UTC (permalink / raw)
To: Ding Xiang; +Cc: Linus Walleij, linux-gpio, LKML
śr., 31 lip 2019 o 11:48 Ding Xiang <dingxiang@cmss.chinamobile.com> napisał(a):
>
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/gpio/gpio-ixp4xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
> index 670c2a8..2b2b89b 100644
> --- a/drivers/gpio/gpio-ixp4xx.c
> +++ b/drivers/gpio/gpio-ixp4xx.c
> @@ -321,10 +321,8 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> g->base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(g->base)) {
> - dev_err(dev, "ioremap error\n");
> + if (IS_ERR(g->base))
> return PTR_ERR(g->base);
> - }
>
> /*
> * Make sure GPIO 14 and 15 are NOT used as clocks but GPIO on
> --
> 1.9.1
>
>
>
Patch applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-31 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 9:47 [PATCH] gpio: ixp4xx: remove redundant dev_err message Ding Xiang
2019-07-31 10:05 ` Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.