All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] sun50i: h6: Fix Beelink GS1 board config
@ 2019-05-14 18:26 peron.clem at gmail.com
  2019-05-20 16:34 ` Jagan Teki
  0 siblings, 1 reply; 6+ messages in thread
From: peron.clem at gmail.com @ 2019-05-14 18:26 UTC (permalink / raw)
  To: u-boot

From: Clément Péron <peron.clem@gmail.com>

SPL_TEXT_BASE has been moved to Kconfig with commit:
f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig

But Beelink GS1 config file has been introduced in the
same time without this modification.

Fix this by settings the CONFIG_SPL_TEXT_BASE

Suggested-by: Jonas Smedegaard <dr@jones.dk>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 configs/beelink_gs1_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
index ef4dd29549..f16d0fee22 100644
--- a/configs/beelink_gs1_defconfig
+++ b/configs/beelink_gs1_defconfig
@@ -1,12 +1,13 @@
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_MMC0_CD_PIN="PF6"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 # CONFIG_PSCI_RESET is not set
-CONFIG_NR_DRAM_BANKS=1
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_SPL_TEXT_BASE=0x20060
 # CONFIG_CMD_FLASH is not set
 # CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_SPL_EFI_PARTITION is not set
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun50i: h6: Fix Beelink GS1 board config
  2019-05-14 18:26 [U-Boot] [PATCH] sun50i: h6: Fix Beelink GS1 board config peron.clem at gmail.com
@ 2019-05-20 16:34 ` Jagan Teki
  2019-05-20 16:36   ` Clément Péron
  0 siblings, 1 reply; 6+ messages in thread
From: Jagan Teki @ 2019-05-20 16:34 UTC (permalink / raw)
  To: u-boot

On Tue, May 14, 2019 at 11:56 PM <peron.clem@gmail.com> wrote:
>
> From: Clément Péron <peron.clem@gmail.com>
>
> SPL_TEXT_BASE has been moved to Kconfig with commit:
> f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig
>
> But Beelink GS1 config file has been introduced in the
> same time without this modification.
>
> Fix this by settings the CONFIG_SPL_TEXT_BASE
>
> Suggested-by: Jonas Smedegaard <dr@jones.dk>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>  configs/beelink_gs1_defconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
> index ef4dd29549..f16d0fee22 100644
> --- a/configs/beelink_gs1_defconfig
> +++ b/configs/beelink_gs1_defconfig
> @@ -1,12 +1,13 @@
>  CONFIG_ARM=y
>  CONFIG_ARCH_SUNXI=y
> +CONFIG_NR_DRAM_BANKS=1
>  CONFIG_SPL=y
>  CONFIG_MACH_SUN50I_H6=y
>  CONFIG_MMC0_CD_PIN="PF6"
>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>  # CONFIG_PSCI_RESET is not set
> -CONFIG_NR_DRAM_BANKS=1

Change changes seems different

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun50i: h6: Fix Beelink GS1 board config
  2019-05-20 16:34 ` Jagan Teki
@ 2019-05-20 16:36   ` Clément Péron
  2019-05-20 16:38     ` Jagan Teki
  0 siblings, 1 reply; 6+ messages in thread
From: Clément Péron @ 2019-05-20 16:36 UTC (permalink / raw)
  To: u-boot

Hi Jagan,

On Mon, 20 May 2019 at 18:34, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Tue, May 14, 2019 at 11:56 PM <peron.clem@gmail.com> wrote:
> >
> > From: Clément Péron <peron.clem@gmail.com>
> >
> > SPL_TEXT_BASE has been moved to Kconfig with commit:
> > f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig
> >
> > But Beelink GS1 config file has been introduced in the
> > same time without this modification.
> >
> > Fix this by settings the CONFIG_SPL_TEXT_BASE
> >
> > Suggested-by: Jonas Smedegaard <dr@jones.dk>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >  configs/beelink_gs1_defconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
> > index ef4dd29549..f16d0fee22 100644
> > --- a/configs/beelink_gs1_defconfig
> > +++ b/configs/beelink_gs1_defconfig
> > @@ -1,12 +1,13 @@
> >  CONFIG_ARM=y
> >  CONFIG_ARCH_SUNXI=y
> > +CONFIG_NR_DRAM_BANKS=1
> >  CONFIG_SPL=y
> >  CONFIG_MACH_SUN50I_H6=y
> >  CONFIG_MMC0_CD_PIN="PF6"
> >  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> >  # CONFIG_PSCI_RESET is not set
> > -CONFIG_NR_DRAM_BANKS=1
>
> Change changes seems different

This happens when I made the "make save_defconfig"

Do you want to split this in two commits ?

Regards,
Clément

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun50i: h6: Fix Beelink GS1 board config
  2019-05-20 16:36   ` Clément Péron
@ 2019-05-20 16:38     ` Jagan Teki
  2019-05-20 16:44       ` Clément Péron
  0 siblings, 1 reply; 6+ messages in thread
From: Jagan Teki @ 2019-05-20 16:38 UTC (permalink / raw)
  To: u-boot

On Mon, May 20, 2019 at 10:07 PM Clément Péron <peron.clem@gmail.com> wrote:
>
> Hi Jagan,
>
> On Mon, 20 May 2019 at 18:34, Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Tue, May 14, 2019 at 11:56 PM <peron.clem@gmail.com> wrote:
> > >
> > > From: Clément Péron <peron.clem@gmail.com>
> > >
> > > SPL_TEXT_BASE has been moved to Kconfig with commit:
> > > f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig
> > >
> > > But Beelink GS1 config file has been introduced in the
> > > same time without this modification.
> > >
> > > Fix this by settings the CONFIG_SPL_TEXT_BASE
> > >
> > > Suggested-by: Jonas Smedegaard <dr@jones.dk>
> > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > ---
> > >  configs/beelink_gs1_defconfig | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
> > > index ef4dd29549..f16d0fee22 100644
> > > --- a/configs/beelink_gs1_defconfig
> > > +++ b/configs/beelink_gs1_defconfig
> > > @@ -1,12 +1,13 @@
> > >  CONFIG_ARM=y
> > >  CONFIG_ARCH_SUNXI=y
> > > +CONFIG_NR_DRAM_BANKS=1
> > >  CONFIG_SPL=y
> > >  CONFIG_MACH_SUN50I_H6=y
> > >  CONFIG_MMC0_CD_PIN="PF6"
> > >  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> > >  # CONFIG_PSCI_RESET is not set
> > > -CONFIG_NR_DRAM_BANKS=1
> >
> > Change changes seems different
>
> This happens when I made the "make save_defconfig"
>
> Do you want to split this in two commits ?

I can drop that while applying, if you agree?

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun50i: h6: Fix Beelink GS1 board config
  2019-05-20 16:38     ` Jagan Teki
@ 2019-05-20 16:44       ` Clément Péron
  2019-05-20 16:55         ` Jagan Teki
  0 siblings, 1 reply; 6+ messages in thread
From: Clément Péron @ 2019-05-20 16:44 UTC (permalink / raw)
  To: u-boot

Hi Jagan,


On Mon, 20 May 2019 at 18:38, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Mon, May 20, 2019 at 10:07 PM Clément Péron <peron.clem@gmail.com> wrote:
> >
> > Hi Jagan,
> >
> > On Mon, 20 May 2019 at 18:34, Jagan Teki <jagan@amarulasolutions.com> wrote:
> > >
> > > On Tue, May 14, 2019 at 11:56 PM <peron.clem@gmail.com> wrote:
> > > >
> > > > From: Clément Péron <peron.clem@gmail.com>
> > > >
> > > > SPL_TEXT_BASE has been moved to Kconfig with commit:
> > > > f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig
> > > >
> > > > But Beelink GS1 config file has been introduced in the
> > > > same time without this modification.
> > > >
> > > > Fix this by settings the CONFIG_SPL_TEXT_BASE
> > > >
> > > > Suggested-by: Jonas Smedegaard <dr@jones.dk>
> > > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > > ---
> > > >  configs/beelink_gs1_defconfig | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
> > > > index ef4dd29549..f16d0fee22 100644
> > > > --- a/configs/beelink_gs1_defconfig
> > > > +++ b/configs/beelink_gs1_defconfig
> > > > @@ -1,12 +1,13 @@
> > > >  CONFIG_ARM=y
> > > >  CONFIG_ARCH_SUNXI=y
> > > > +CONFIG_NR_DRAM_BANKS=1
> > > >  CONFIG_SPL=y
> > > >  CONFIG_MACH_SUN50I_H6=y
> > > >  CONFIG_MMC0_CD_PIN="PF6"
> > > >  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> > > >  # CONFIG_PSCI_RESET is not set
> > > > -CONFIG_NR_DRAM_BANKS=1
> > >
> > > Change changes seems different
> >
> > This happens when I made the "make save_defconfig"
> >
> > Do you want to split this in two commits ?
>
> I can drop that while applying, if you agree?

Please do so,
Thanks,
Clément

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun50i: h6: Fix Beelink GS1 board config
  2019-05-20 16:44       ` Clément Péron
@ 2019-05-20 16:55         ` Jagan Teki
  0 siblings, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2019-05-20 16:55 UTC (permalink / raw)
  To: u-boot

On Mon, May 20, 2019 at 10:14 PM Clément Péron <peron.clem@gmail.com> wrote:
>
> Hi Jagan,
>
>
> On Mon, 20 May 2019 at 18:38, Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Mon, May 20, 2019 at 10:07 PM Clément Péron <peron.clem@gmail.com> wrote:
> > >
> > > Hi Jagan,
> > >
> > > On Mon, 20 May 2019 at 18:34, Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > >
> > > > On Tue, May 14, 2019 at 11:56 PM <peron.clem@gmail.com> wrote:
> > > > >
> > > > > From: Clément Péron <peron.clem@gmail.com>
> > > > >
> > > > > SPL_TEXT_BASE has been moved to Kconfig with commit:
> > > > > f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig
> > > > >
> > > > > But Beelink GS1 config file has been introduced in the
> > > > > same time without this modification.
> > > > >
> > > > > Fix this by settings the CONFIG_SPL_TEXT_BASE
> > > > >
> > > > > Suggested-by: Jonas Smedegaard <dr@jones.dk>
> > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > > > ---
> > > > >  configs/beelink_gs1_defconfig | 3 ++-
> > > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
> > > > > index ef4dd29549..f16d0fee22 100644
> > > > > --- a/configs/beelink_gs1_defconfig
> > > > > +++ b/configs/beelink_gs1_defconfig
> > > > > @@ -1,12 +1,13 @@
> > > > >  CONFIG_ARM=y
> > > > >  CONFIG_ARCH_SUNXI=y
> > > > > +CONFIG_NR_DRAM_BANKS=1
> > > > >  CONFIG_SPL=y
> > > > >  CONFIG_MACH_SUN50I_H6=y
> > > > >  CONFIG_MMC0_CD_PIN="PF6"
> > > > >  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> > > > >  # CONFIG_PSCI_RESET is not set
> > > > > -CONFIG_NR_DRAM_BANKS=1
> > > >
> > > > Change changes seems different
> > >
> > > This happens when I made the "make save_defconfig"
> > >
> > > Do you want to split this in two commits ?
> >
> > I can drop that while applying, if you agree?

Applied to u-boot-sunxi/master

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-20 16:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-14 18:26 [U-Boot] [PATCH] sun50i: h6: Fix Beelink GS1 board config peron.clem at gmail.com
2019-05-20 16:34 ` Jagan Teki
2019-05-20 16:36   ` Clément Péron
2019-05-20 16:38     ` Jagan Teki
2019-05-20 16:44       ` Clément Péron
2019-05-20 16:55         ` Jagan Teki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.