From: Jagan Teki <jagan@amarulasolutions.com>
To: Adam Ford <aford173@gmail.com>
Cc: dri-devel@lists.freedesktop.org, aford@beaconembedded.com,
Conor Dooley <conor.dooley@microchip.com>,
Inki Dae <inki.dae@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
Date: Sun, 28 May 2023 19:04:01 +0530 [thread overview]
Message-ID: <CAMty3ZB=XfMr7k31yHzZ+YHFxT0ifCbmR4+s5yw+YgTSJE0Jxg@mail.gmail.com> (raw)
In-Reply-To: <20230528132727.3933-1-aford173@gmail.com>
On Sun, May 28, 2023 at 6:57 PM Adam Ford <aford173@gmail.com> wrote:
>
> In the event a device is connected to the samsung-dsim
> controller that doesn't support the burst-clock, the
> driver is able to get the requested pixel clock from the
> attached device or bridge. In these instances, the
> samsung,burst-clock-frequency isn't needed, so remove
> it from the required list.
>
> The pll-clock frequency can be set by the device tree entry
> for samsung,pll-clock-frequency, but in some cases, the
> pll-clock may have the same clock rate as sclk_mipi clock.
> If they are equal, this flag is not needed since the driver
> will use the sclk_mipi rate as a fallback.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> V2: Split from driver series. Re-word updates for burst
> and pll-clock frequency.
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> index 9f61ebdfefa8..06b6c44d4641 100644
> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> @@ -70,7 +70,9 @@ properties:
> samsung,burst-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
> - DSIM high speed burst mode frequency.
> + DSIM high speed burst mode frequency. If absent,
> + the pixel clock from the attached device or bridge
> + will be used instead.
>
> samsung,esc-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -80,7 +82,8 @@ properties:
> samsung,pll-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
> - DSIM oscillator clock frequency.
> + DSIM oscillator clock frequency. If absent, the clock frequency
> + of sclk_mipi will be used instead.
Maybe this explicit comment won't require as it is not listed in "required"
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Adam Ford <aford173@gmail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Robert Foss <rfoss@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonas Karlman <jonas@kwiboo.se>,
aford@beaconembedded.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
devicetree@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
Date: Sun, 28 May 2023 19:04:01 +0530 [thread overview]
Message-ID: <CAMty3ZB=XfMr7k31yHzZ+YHFxT0ifCbmR4+s5yw+YgTSJE0Jxg@mail.gmail.com> (raw)
In-Reply-To: <20230528132727.3933-1-aford173@gmail.com>
On Sun, May 28, 2023 at 6:57 PM Adam Ford <aford173@gmail.com> wrote:
>
> In the event a device is connected to the samsung-dsim
> controller that doesn't support the burst-clock, the
> driver is able to get the requested pixel clock from the
> attached device or bridge. In these instances, the
> samsung,burst-clock-frequency isn't needed, so remove
> it from the required list.
>
> The pll-clock frequency can be set by the device tree entry
> for samsung,pll-clock-frequency, but in some cases, the
> pll-clock may have the same clock rate as sclk_mipi clock.
> If they are equal, this flag is not needed since the driver
> will use the sclk_mipi rate as a fallback.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> V2: Split from driver series. Re-word updates for burst
> and pll-clock frequency.
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> index 9f61ebdfefa8..06b6c44d4641 100644
> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> @@ -70,7 +70,9 @@ properties:
> samsung,burst-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
> - DSIM high speed burst mode frequency.
> + DSIM high speed burst mode frequency. If absent,
> + the pixel clock from the attached device or bridge
> + will be used instead.
>
> samsung,esc-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -80,7 +82,8 @@ properties:
> samsung,pll-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
> - DSIM oscillator clock frequency.
> + DSIM oscillator clock frequency. If absent, the clock frequency
> + of sclk_mipi will be used instead.
Maybe this explicit comment won't require as it is not listed in "required"
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
next prev parent reply other threads:[~2023-05-28 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 13:27 [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional Adam Ford
2023-05-28 13:27 ` Adam Ford
2023-05-28 13:34 ` Jagan Teki [this message]
2023-05-28 13:34 ` Jagan Teki
2023-05-28 18:14 ` Adam Ford
2023-05-28 18:14 ` Adam Ford
2023-05-28 22:33 ` Fabio Estevam
2023-05-28 22:33 ` Fabio Estevam
2023-05-30 8:06 ` Neil Armstrong
2023-05-30 8:06 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMty3ZB=XfMr7k31yHzZ+YHFxT0ifCbmR4+s5yw+YgTSJE0Jxg@mail.gmail.com' \
--to=jagan@amarulasolutions.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.