* [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
@ 2019-08-01 15:56 Lukasz Majewski
2019-09-03 14:19 ` Lukasz Majewski
2019-09-06 18:06 ` Jagan Teki
0 siblings, 2 replies; 8+ messages in thread
From: Lukasz Majewski @ 2019-08-01 15:56 UTC (permalink / raw)
To: u-boot
This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
The mxs_spi.c driver for i.MX2{38} devices has been converted:
'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPI conversion)")'
to use Device Tree and Device Model, so the DEPRECATED Kconfig
symbol can be now removed.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
drivers/spi/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index f459c0a411..8dd3213d48 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -419,7 +419,6 @@ config MXC_SPI
config MXS_SPI
bool "MXS SPI Driver"
- depends on DEPRECATED
help
Enable the MXS SPI controller driver. This driver can be used
on the i.MX23 and i.MX28 SoCs.
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
2019-08-01 15:56 [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED" Lukasz Majewski
@ 2019-09-03 14:19 ` Lukasz Majewski
2019-09-06 18:06 ` Jagan Teki
1 sibling, 0 replies; 8+ messages in thread
From: Lukasz Majewski @ 2019-09-03 14:19 UTC (permalink / raw)
To: u-boot
Hi Jagan,
> This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
>
> The mxs_spi.c driver for i.MX2{38} devices has been converted:
> 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> SPI driver (DM_SPI conversion)")'
>
> to use Device Tree and Device Model, so the DEPRECATED Kconfig
> symbol can be now removed.
Gentle ping on this patch.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
>
> ---
>
> drivers/spi/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f459c0a411..8dd3213d48 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -419,7 +419,6 @@ config MXC_SPI
>
> config MXS_SPI
> bool "MXS SPI Driver"
> - depends on DEPRECATED
> help
> Enable the MXS SPI controller driver. This driver can be
> used on the i.MX23 and i.MX28 SoCs.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190903/fb735a18/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
2019-08-01 15:56 [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED" Lukasz Majewski
2019-09-03 14:19 ` Lukasz Majewski
@ 2019-09-06 18:06 ` Jagan Teki
2019-09-06 21:32 ` Lukasz Majewski
1 sibling, 1 reply; 8+ messages in thread
From: Jagan Teki @ 2019-09-06 18:06 UTC (permalink / raw)
To: u-boot
On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
>
> This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
This wouldn't be a revert.
The deprecated patch been merged in May, 29 and
>
> The mxs_spi.c driver for i.MX2{38} devices has been converted:
> 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPI conversion)")'
This was merged in June, 19 so please send a separate patch. I was
expected this changes would be part of dm spi conversion on that
driver.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
2019-09-06 18:06 ` Jagan Teki
@ 2019-09-06 21:32 ` Lukasz Majewski
2019-09-06 23:02 ` Tom Rini
0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2019-09-06 21:32 UTC (permalink / raw)
To: u-boot
Hi Jagan,
> On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> >
> > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
>
> This wouldn't be a revert.
>
> The deprecated patch been merged in May, 29 and
>
> >
> > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > SPI driver (DM_SPI conversion)")'
>
> This was merged in June, 19 so please send a separate patch.
Cannot we just revert the patch? Is there any issue or technical
problem with doing that ?
> I was
> expected this changes would be part of dm spi conversion on that
> driver.
Ok.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190906/8c7bc669/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
2019-09-06 21:32 ` Lukasz Majewski
@ 2019-09-06 23:02 ` Tom Rini
2019-09-07 3:36 ` Jagan Teki
0 siblings, 1 reply; 8+ messages in thread
From: Tom Rini @ 2019-09-06 23:02 UTC (permalink / raw)
To: u-boot
On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:
> Hi Jagan,
>
> > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> > >
> > > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
> >
> > This wouldn't be a revert.
> >
> > The deprecated patch been merged in May, 29 and
> >
> > >
> > > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > > SPI driver (DM_SPI conversion)")'
> >
> > This was merged in June, 19 so please send a separate patch.
>
> Cannot we just revert the patch? Is there any issue or technical
> problem with doing that ?
To me it's a fairly odd to say revert. It's "re-enable" of support.
That said, Jagan, can you just reword the commit or something? It needs
to go in either way and the contents don't change. Thanks all!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190906/6de5722d/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
2019-09-06 23:02 ` Tom Rini
@ 2019-09-07 3:36 ` Jagan Teki
2019-09-07 17:03 ` Tom Rini
0 siblings, 1 reply; 8+ messages in thread
From: Jagan Teki @ 2019-09-07 3:36 UTC (permalink / raw)
To: u-boot
On Sat, Sep 7, 2019 at 4:32 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:
> > Hi Jagan,
> >
> > > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> > > >
> > > > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
> > >
> > > This wouldn't be a revert.
> > >
> > > The deprecated patch been merged in May, 29 and
> > >
> > > >
> > > > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > > > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > > > SPI driver (DM_SPI conversion)")'
> > >
> > > This was merged in June, 19 so please send a separate patch.
> >
> > Cannot we just revert the patch? Is there any issue or technical
> > problem with doing that ?
>
> To me it's a fairly odd to say revert. It's "re-enable" of support.
> That said, Jagan, can you just reword the commit or something? It needs
> to go in either way and the contents don't change. Thanks all!
Updated the commit message, and
Applied to u-boot-spi/master
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
2019-09-07 3:36 ` Jagan Teki
@ 2019-09-07 17:03 ` Tom Rini
2019-09-07 19:35 ` Lukasz Majewski
0 siblings, 1 reply; 8+ messages in thread
From: Tom Rini @ 2019-09-07 17:03 UTC (permalink / raw)
To: u-boot
On Sat, Sep 07, 2019 at 09:06:39AM +0530, Jagan Teki wrote:
> On Sat, Sep 7, 2019 at 4:32 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:
> > > Hi Jagan,
> > >
> > > > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> > > > >
> > > > > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
> > > >
> > > > This wouldn't be a revert.
> > > >
> > > > The deprecated patch been merged in May, 29 and
> > > >
> > > > >
> > > > > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > > > > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > > > > SPI driver (DM_SPI conversion)")'
> > > >
> > > > This was merged in June, 19 so please send a separate patch.
> > >
> > > Cannot we just revert the patch? Is there any issue or technical
> > > problem with doing that ?
> >
> > To me it's a fairly odd to say revert. It's "re-enable" of support.
> > That said, Jagan, can you just reword the commit or something? It needs
> > to go in either way and the contents don't change. Thanks all!
>
> Updated the commit message, and
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190907/b8a26ea9/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
2019-09-07 17:03 ` Tom Rini
@ 2019-09-07 19:35 ` Lukasz Majewski
0 siblings, 0 replies; 8+ messages in thread
From: Lukasz Majewski @ 2019-09-07 19:35 UTC (permalink / raw)
To: u-boot
Hi Tom, Jagan,
> On Sat, Sep 07, 2019 at 09:06:39AM +0530, Jagan Teki wrote:
> > On Sat, Sep 7, 2019 at 4:32 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > >
> > > On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:
> > > > Hi Jagan,
> > > >
> > > > > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski
> > > > > <lukma@denx.de> wrote:
> > > > > >
> > > > > > This reverts commit
> > > > > > d5ded320a14b0a2f97cbed072286748895ad18ac.
> > > > >
> > > > > This wouldn't be a revert.
> > > > >
> > > > > The deprecated patch been merged in May, 29 and
> > > > >
> > > > > >
> > > > > > The mxs_spi.c driver for i.MX2{38} devices has been
> > > > > > converted: 'commit d99b018a6e3d ("spi: mxs: Add support
> > > > > > DM/DTS for i.MX28 mxs SPI driver (DM_SPI conversion)")'
> > > > >
> > > > > This was merged in June, 19 so please send a separate patch.
> > > >
> > > > Cannot we just revert the patch? Is there any issue or technical
> > > > problem with doing that ?
> > >
> > > To me it's a fairly odd to say revert. It's "re-enable" of
> > > support. That said, Jagan, can you just reword the commit or
> > > something? It needs to go in either way and the contents don't
> > > change. Thanks all!
> >
> > Updated the commit message, and
>
> Thanks!
>
Jagan, thanks for the reword :-)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190907/6bb6b097/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-09-07 19:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-01 15:56 [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED" Lukasz Majewski
2019-09-03 14:19 ` Lukasz Majewski
2019-09-06 18:06 ` Jagan Teki
2019-09-06 21:32 ` Lukasz Majewski
2019-09-06 23:02 ` Tom Rini
2019-09-07 3:36 ` Jagan Teki
2019-09-07 17:03 ` Tom Rini
2019-09-07 19:35 ` Lukasz Majewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.