From: Jagan Teki <jagan@amarulasolutions.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH 4/7] arm64: dts: rockchip: Fix compatible and model for Radxa CM3i
Date: Tue, 17 Jan 2023 18:22:49 +0530 [thread overview]
Message-ID: <CAMty3ZD_LWBR2+fu41Z5LEBcNw1KXEaY8P92Ypa-4rg2t8BH_A@mail.gmail.com> (raw)
In-Reply-To: <2dcb7b4a-9751-ec7a-f0ea-6de748ca3bf7@linaro.org>
On Tue, Jan 17, 2023 at 4:37 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 17/01/2023 11:55, Jagan Teki wrote:
> > Fix the model name and compatible strings for Radxa CM3i SoM
> > and Carrier board based on Radxa recommendation.
> >
> > Fixes: 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
> > Cc: Chukun Pan <amadeus@jmu.edu.cn>
> > Reported-by: FUKAUMI Naoki <naoki@radxa.com>
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 2 +-
> > arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > index 225dbbe4955d..0c9a918b809a 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > @@ -7,7 +7,7 @@
> >
> > / {
> > model = "Radxa CM3 Industrial Board";
> > - compatible = "radxa,cm3i", "rockchip,rk3568";
> > + compatible = "radxa,radxa-cm3i", "rockchip,rk3568";
>
> Nope, second radxa is redundant.
It is not redundant, Product name and vendor name is same. Vendor name
is Radxa and product name is Radxa CM3i
>
> >
> > aliases {
> > mmc0 = &sdhci;
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > index a4c33310ca42..8ca15b723799 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > @@ -4,8 +4,8 @@
> > #include "rk3568-radxa-cm3i.dtsi"
> >
> > / {
> > - model = "Radxa E25";
> > - compatible = "radxa,e25", "radxa,cm3i", "rockchip,rk3568";
> > + model = "Radxa E25 Carrier Board";
> > + compatible = "radxa,radxa-e25", "radxa,radxa-cm3i", "rockchip,rk3568";
>
> NAK. You just changed it in patch 2. Don't add broken compatibles in one
> patch (cm3i) and fix them next one. It's like adding intentional bugs
> and fixing them immediately...
I did squash this with previous patch but the check patch showing
warning to separate the dt-bindings patch from actual devicetree file
change.
Jagan.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH 4/7] arm64: dts: rockchip: Fix compatible and model for Radxa CM3i
Date: Tue, 17 Jan 2023 18:22:49 +0530 [thread overview]
Message-ID: <CAMty3ZD_LWBR2+fu41Z5LEBcNw1KXEaY8P92Ypa-4rg2t8BH_A@mail.gmail.com> (raw)
In-Reply-To: <2dcb7b4a-9751-ec7a-f0ea-6de748ca3bf7@linaro.org>
On Tue, Jan 17, 2023 at 4:37 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 17/01/2023 11:55, Jagan Teki wrote:
> > Fix the model name and compatible strings for Radxa CM3i SoM
> > and Carrier board based on Radxa recommendation.
> >
> > Fixes: 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
> > Cc: Chukun Pan <amadeus@jmu.edu.cn>
> > Reported-by: FUKAUMI Naoki <naoki@radxa.com>
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 2 +-
> > arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > index 225dbbe4955d..0c9a918b809a 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > @@ -7,7 +7,7 @@
> >
> > / {
> > model = "Radxa CM3 Industrial Board";
> > - compatible = "radxa,cm3i", "rockchip,rk3568";
> > + compatible = "radxa,radxa-cm3i", "rockchip,rk3568";
>
> Nope, second radxa is redundant.
It is not redundant, Product name and vendor name is same. Vendor name
is Radxa and product name is Radxa CM3i
>
> >
> > aliases {
> > mmc0 = &sdhci;
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > index a4c33310ca42..8ca15b723799 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > @@ -4,8 +4,8 @@
> > #include "rk3568-radxa-cm3i.dtsi"
> >
> > / {
> > - model = "Radxa E25";
> > - compatible = "radxa,e25", "radxa,cm3i", "rockchip,rk3568";
> > + model = "Radxa E25 Carrier Board";
> > + compatible = "radxa,radxa-e25", "radxa,radxa-cm3i", "rockchip,rk3568";
>
> NAK. You just changed it in patch 2. Don't add broken compatibles in one
> patch (cm3i) and fix them next one. It's like adding intentional bugs
> and fixing them immediately...
I did squash this with previous patch but the check patch showing
warning to separate the dt-bindings patch from actual devicetree file
change.
Jagan.
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH 4/7] arm64: dts: rockchip: Fix compatible and model for Radxa CM3i
Date: Tue, 17 Jan 2023 18:22:49 +0530 [thread overview]
Message-ID: <CAMty3ZD_LWBR2+fu41Z5LEBcNw1KXEaY8P92Ypa-4rg2t8BH_A@mail.gmail.com> (raw)
In-Reply-To: <2dcb7b4a-9751-ec7a-f0ea-6de748ca3bf7@linaro.org>
On Tue, Jan 17, 2023 at 4:37 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 17/01/2023 11:55, Jagan Teki wrote:
> > Fix the model name and compatible strings for Radxa CM3i SoM
> > and Carrier board based on Radxa recommendation.
> >
> > Fixes: 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
> > Cc: Chukun Pan <amadeus@jmu.edu.cn>
> > Reported-by: FUKAUMI Naoki <naoki@radxa.com>
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 2 +-
> > arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > index 225dbbe4955d..0c9a918b809a 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> > @@ -7,7 +7,7 @@
> >
> > / {
> > model = "Radxa CM3 Industrial Board";
> > - compatible = "radxa,cm3i", "rockchip,rk3568";
> > + compatible = "radxa,radxa-cm3i", "rockchip,rk3568";
>
> Nope, second radxa is redundant.
It is not redundant, Product name and vendor name is same. Vendor name
is Radxa and product name is Radxa CM3i
>
> >
> > aliases {
> > mmc0 = &sdhci;
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > index a4c33310ca42..8ca15b723799 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> > @@ -4,8 +4,8 @@
> > #include "rk3568-radxa-cm3i.dtsi"
> >
> > / {
> > - model = "Radxa E25";
> > - compatible = "radxa,e25", "radxa,cm3i", "rockchip,rk3568";
> > + model = "Radxa E25 Carrier Board";
> > + compatible = "radxa,radxa-e25", "radxa,radxa-cm3i", "rockchip,rk3568";
>
> NAK. You just changed it in patch 2. Don't add broken compatibles in one
> patch (cm3i) and fix them next one. It's like adding intentional bugs
> and fixing them immediately...
I did squash this with previous patch but the check patch showing
warning to separate the dt-bindings patch from actual devicetree file
change.
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-17 12:53 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 10:54 [PATCH 1/7] dt-bindings: arm: rockchip: Add meaningful comments for Radxa CM3 Jagan Teki
2023-01-17 10:54 ` Jagan Teki
2023-01-17 10:54 ` Jagan Teki
2023-01-17 10:54 ` [PATCH 2/7] arm64: dts: rockchip: Add missing CM3i fallback compatible for Radxa E25 Jagan Teki
2023-01-17 10:54 ` Jagan Teki
2023-01-17 10:54 ` Jagan Teki
2023-01-17 10:55 ` [PATCH 3/7] dt-bindings: arm: rockchip: Fix description and compatible for Radxa CM3i Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 11:06 ` Krzysztof Kozlowski
2023-01-17 11:06 ` Krzysztof Kozlowski
2023-01-17 11:06 ` Krzysztof Kozlowski
2023-01-17 12:55 ` Jagan Teki
2023-01-17 12:55 ` Jagan Teki
2023-01-17 12:55 ` Jagan Teki
2023-01-17 20:32 ` Rob Herring
2023-01-17 20:32 ` Rob Herring
2023-01-17 20:32 ` Rob Herring
2023-01-17 10:55 ` [PATCH 4/7] arm64: dts: rockchip: Fix compatible and model " Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 11:07 ` Krzysztof Kozlowski
2023-01-17 11:07 ` Krzysztof Kozlowski
2023-01-17 11:07 ` Krzysztof Kozlowski
2023-01-17 12:52 ` Jagan Teki [this message]
2023-01-17 12:52 ` Jagan Teki
2023-01-17 12:52 ` Jagan Teki
2023-01-17 12:58 ` Krzysztof Kozlowski
2023-01-17 12:58 ` Krzysztof Kozlowski
2023-01-17 12:58 ` Krzysztof Kozlowski
2023-01-18 7:20 ` Jagan Teki
2023-01-18 7:20 ` Jagan Teki
2023-01-18 7:20 ` Jagan Teki
2023-01-17 10:55 ` [PATCH 5/7] arm64: dts: rockchip: Drop unneeded " Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 10:55 ` [PATCH 6/7] arm64: dts: rockchip: Update eMMC, SD aliases for Radxa SoM boards Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 10:55 ` [PATCH 7/7] arm64: dts: rockchip: Update eMMC, SD aliases for Radxa SBC boards Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 10:55 ` Jagan Teki
2023-01-17 11:05 ` [PATCH 1/7] dt-bindings: arm: rockchip: Add meaningful comments for Radxa CM3 Krzysztof Kozlowski
2023-01-17 11:05 ` Krzysztof Kozlowski
2023-01-17 11:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMty3ZD_LWBR2+fu41Z5LEBcNw1KXEaY8P92Ypa-4rg2t8BH_A@mail.gmail.com \
--to=jagan@amarulasolutions.com \
--cc=amadeus@jmu.edu.cn \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.