All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: renesas: rcar-gen3: Add SoC model to comment headers
Date: Tue, 8 Jun 2021 08:45:57 +0200	[thread overview]
Message-ID: <CAMuHMdU455tAZdb3vG6Hk25BUvFqfjdmatJVECt7i+eJGxMH5g@mail.gmail.com> (raw)
In-Reply-To: <YL6JaF8GEiuqnh4M@oden.dyn.berto.se>

Hi Niklas,

On Mon, Jun 7, 2021 at 11:02 PM Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> On 2021-06-07 19:42:38 +0200, Geert Uytterhoeven wrote:
> > Make sure the R-Car Gen3 SoC model present is documented in the comment
> > header of each board DTS.  This makes it easier to identify boards that
> > are available with different SoC or SiP options.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> nit: Would it make sens to break the line length limit for this to make
> it easier for grep to be more useful? In either case,

Good suggestion!

Might make sense for the top compatible value in .dts files, too,
but then we're crossing the new 100 character upper limit...

> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks again!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	 Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: renesas: rcar-gen3: Add SoC model to comment headers
Date: Tue, 8 Jun 2021 08:45:57 +0200	[thread overview]
Message-ID: <CAMuHMdU455tAZdb3vG6Hk25BUvFqfjdmatJVECt7i+eJGxMH5g@mail.gmail.com> (raw)
In-Reply-To: <YL6JaF8GEiuqnh4M@oden.dyn.berto.se>

Hi Niklas,

On Mon, Jun 7, 2021 at 11:02 PM Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> On 2021-06-07 19:42:38 +0200, Geert Uytterhoeven wrote:
> > Make sure the R-Car Gen3 SoC model present is documented in the comment
> > header of each board DTS.  This makes it easier to identify boards that
> > are available with different SoC or SiP options.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> nit: Would it make sens to break the line length limit for this to make
> it easier for grep to be more useful? In either case,

Good suggestion!

Might make sense for the top compatible value in .dts files, too,
but then we're crossing the new 100 character upper limit...

> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks again!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-08  6:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 17:42 [PATCH] arm64: dts: renesas: rcar-gen3: Add SoC model to comment headers Geert Uytterhoeven
2021-06-07 17:42 ` Geert Uytterhoeven
2021-06-07 21:02 ` Niklas Söderlund
2021-06-07 21:02   ` Niklas Söderlund
2021-06-08  6:45   ` Geert Uytterhoeven [this message]
2021-06-08  6:45     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdU455tAZdb3vG6Hk25BUvFqfjdmatJVECt7i+eJGxMH5g@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=niklas.soderlund@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.