* [PATCH] mmc: dw_mmc should depend on COMMON_CLK
@ 2018-06-06 18:43 Corentin Labbe
2018-06-12 17:07 ` Andy Shevchenko
2018-07-02 13:16 ` Ulf Hansson
0 siblings, 2 replies; 5+ messages in thread
From: Corentin Labbe @ 2018-06-06 18:43 UTC (permalink / raw)
To: ulf.hansson; +Cc: linux-kernel, linux-mmc, Corentin Labbe
This patch fix the following build failure on m68k:
ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 0581c199c996..77d6ba090436 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
config MMC_DW
tristate "Synopsys DesignWare Memory Card Interface"
- depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
+ depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
help
This selects support for the Synopsys DesignWare Mobile Storage IP
block, this provides host support for SD and MMC interfaces, in both
--
2.16.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK
2018-06-06 18:43 [PATCH] mmc: dw_mmc should depend on COMMON_CLK Corentin Labbe
@ 2018-06-12 17:07 ` Andy Shevchenko
2018-07-02 13:16 ` Ulf Hansson
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-06-12 17:07 UTC (permalink / raw)
To: Corentin Labbe, Geert Uytterhoeven
Cc: Ulf Hansson, Linux Kernel Mailing List, linux-mmc
+Cc: Geert
On Wed, Jun 6, 2018 at 9:43 PM, Corentin Labbe <clabbe@baylibre.com> wrote:
> This patch fix the following build failure on m68k:
> ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 0581c199c996..77d6ba090436 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
>
> config MMC_DW
> tristate "Synopsys DesignWare Memory Card Interface"
> - depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
> + depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
> help
> This selects support for the Synopsys DesignWare Mobile Storage IP
> block, this provides host support for SD and MMC interfaces, in both
> --
> 2.16.4
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK
2018-06-06 18:43 [PATCH] mmc: dw_mmc should depend on COMMON_CLK Corentin Labbe
2018-06-12 17:07 ` Andy Shevchenko
@ 2018-07-02 13:16 ` Ulf Hansson
2018-07-02 13:32 ` Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2018-07-02 13:16 UTC (permalink / raw)
To: Corentin Labbe; +Cc: Linux Kernel Mailing List, linux-mmc
On 6 June 2018 at 20:43, Corentin Labbe <clabbe@baylibre.com> wrote:
> This patch fix the following build failure on m68k:
> ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 0581c199c996..77d6ba090436 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
>
> config MMC_DW
> tristate "Synopsys DesignWare Memory Card Interface"
> - depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
> + depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
> help
> This selects support for the Synopsys DesignWare Mobile Storage IP
> block, this provides host support for SD and MMC interfaces, in both
> --
> 2.16.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK
2018-07-02 13:16 ` Ulf Hansson
@ 2018-07-02 13:32 ` Geert Uytterhoeven
2018-07-02 14:37 ` Ulf Hansson
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2018-07-02 13:32 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Corentin Labbe, Linux Kernel Mailing List, Linux MMC List
Hi Ulf,
On Mon, Jul 2, 2018 at 3:18 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 6 June 2018 at 20:43, Corentin Labbe <clabbe@baylibre.com> wrote:
> > This patch fix the following build failure on m68k:
> > ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>
> Thanks, applied for next!
Please drop this patch, I posted proper fixes for this general issue in series
"[PATCH 0/3] Legacy clock drivers: Normalize clk API"
(https://lkml.org/lkml/2018/6/11/122).
All fixes above are already in next-20180702.
Thanks!
> > ---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 0581c199c996..77d6ba090436 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
> >
> > config MMC_DW
> > tristate "Synopsys DesignWare Memory Card Interface"
> > - depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
> > + depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
> > help
> > This selects support for the Synopsys DesignWare Mobile Storage IP
> > block, this provides host support for SD and MMC interfaces, in both
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK
2018-07-02 13:32 ` Geert Uytterhoeven
@ 2018-07-02 14:37 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2018-07-02 14:37 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Corentin Labbe, Linux Kernel Mailing List, Linux MMC List
On 2 July 2018 at 15:32, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Ulf,
>
> On Mon, Jul 2, 2018 at 3:18 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> On 6 June 2018 at 20:43, Corentin Labbe <clabbe@baylibre.com> wrote:
>> > This patch fix the following build failure on m68k:
>> > ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
>> >
>> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>>
>> Thanks, applied for next!
>
> Please drop this patch, I posted proper fixes for this general issue in series
> "[PATCH 0/3] Legacy clock drivers: Normalize clk API"
> (https://lkml.org/lkml/2018/6/11/122).
>
> All fixes above are already in next-20180702.
> Thanks!
Thanks for letting me know, patch dropped!
I had the feeling there was a better way. :-)
[...]
Kind regards
Uffe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-02 14:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-06 18:43 [PATCH] mmc: dw_mmc should depend on COMMON_CLK Corentin Labbe
2018-06-12 17:07 ` Andy Shevchenko
2018-07-02 13:16 ` Ulf Hansson
2018-07-02 13:32 ` Geert Uytterhoeven
2018-07-02 14:37 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.