From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Vineet Gupta <vgupta@synopsys.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Jason Cooper <jason@lakedaemon.net>,
Noam Camus <noamc@ezchip.com>,
arcml <linux-snps-arc@lists.infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip: nps: add 64BIT dependency
Date: Fri, 20 May 2016 10:25:11 +0200 [thread overview]
Message-ID: <CAMuHMdU82GxjtCSmdePpfd_qqeb5hA5koAB_iMQ4Fk5JgfOk7A@mail.gmail.com> (raw)
In-Reply-To: <573EC932.5060106@synopsys.com>
Hi Vineet,
On Fri, May 20, 2016 at 10:22 AM, Vineet Gupta <vgupta@synopsys.com> wrote:
> On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
>> On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> The newly added nps irqchip driver causes build warnings on ARM64.
>>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>>
>>> As the driver is only used on ARC, we don't need to see it without
>>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>> drivers/irqchip/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>>> index 83775f148158..37289cf6b449 100644
>>> --- a/drivers/irqchip/Kconfig
>>> +++ b/drivers/irqchip/Kconfig
>>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>>
>>> config EZNPS_GIC
>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>> select IRQ_DOMAIN
>>> help
>>> Support the EZchip NPS400 global interrupt controller
>>
>> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
>> the slight simpler (whitespace-damaged):
>
> I'm afraid you are late to party - this has been sent Linus' way earlier today !
I am (my compilers are) celebrating Linus' current tree...
> But it does look prettier so we can do this after rc1
OK.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] irqchip: nps: add 64BIT dependency
Date: Fri, 20 May 2016 10:25:11 +0200 [thread overview]
Message-ID: <CAMuHMdU82GxjtCSmdePpfd_qqeb5hA5koAB_iMQ4Fk5JgfOk7A@mail.gmail.com> (raw)
In-Reply-To: <573EC932.5060106@synopsys.com>
Hi Vineet,
On Fri, May 20, 2016@10:22 AM, Vineet Gupta <vgupta@synopsys.com> wrote:
> On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
>> On Thu, May 12, 2016@11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> The newly added nps irqchip driver causes build warnings on ARM64.
>>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>>
>>> As the driver is only used on ARC, we don't need to see it without
>>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
>>> ---
>>> drivers/irqchip/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>>> index 83775f148158..37289cf6b449 100644
>>> --- a/drivers/irqchip/Kconfig
>>> +++ b/drivers/irqchip/Kconfig
>>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>>
>>> config EZNPS_GIC
>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>> select IRQ_DOMAIN
>>> help
>>> Support the EZchip NPS400 global interrupt controller
>>
>> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
>> the slight simpler (whitespace-damaged):
>
> I'm afraid you are late to party - this has been sent Linus' way earlier today !
I am (my compilers are) celebrating Linus' current tree...
> But it does look prettier so we can do this after rc1
OK.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2016-05-20 8:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 21:03 [PATCH] irqchip: nps: add 64BIT dependency Arnd Bergmann
2016-05-12 21:03 ` Arnd Bergmann
2016-05-13 8:24 ` Marc Zyngier
2016-05-13 8:24 ` Marc Zyngier
2016-05-13 8:35 ` Vineet Gupta
2016-05-13 8:35 ` Vineet Gupta
2016-05-13 8:39 ` Marc Zyngier
2016-05-13 8:39 ` Marc Zyngier
2016-05-13 9:51 ` Arnd Bergmann
2016-05-13 9:51 ` Arnd Bergmann
2016-05-13 10:25 ` Marc Zyngier
2016-05-13 10:25 ` Marc Zyngier
2016-05-13 10:39 ` Vineet Gupta
2016-05-13 10:39 ` Vineet Gupta
2016-05-17 19:39 ` Thomas Gleixner
2016-05-17 19:39 ` Thomas Gleixner
2016-05-20 7:34 ` Geert Uytterhoeven
2016-05-20 7:34 ` Geert Uytterhoeven
2016-05-20 8:22 ` Vineet Gupta
2016-05-20 8:22 ` Vineet Gupta
2016-05-20 8:25 ` Geert Uytterhoeven [this message]
2016-05-20 8:25 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU82GxjtCSmdePpfd_qqeb5hA5koAB_iMQ4Fk5JgfOk7A@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=noamc@ezchip.com \
--cc=tglx@linutronix.de \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.