* [PATCH 0/3] ARM: dts: r7s72100: add sdhi DT
@ 2016-09-22 21:32 Chris Brandt
2016-09-22 21:32 ` [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree Chris Brandt
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Chris Brandt @ 2016-09-22 21:32 UTC (permalink / raw)
To: Geert Uytterhoeven, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland
Cc: devicetree, linux-renesas-soc, Chris Brandt
SUMMARY:
This series adds sdhi to the r7s72100 (RZ/A1) Device Tree.
DEPENDECIES:
This series is dependent on the tmio/sh_sdhi patches being
applied to add r7s72100 support.
mmc: sh_mobile_sdhi: add ocr_mask option
mmc: tmio-mmc: add support for 32bit data port
mmc: sh_mobile_sdhi: Add r7s72100 support
MERGE CONFLICTS:
There are also patches being reviewed for adding mmc so depending on how
they get applied, there might be a line conflict.
To resolve the merge conflict, simply put the MMC nodes before
the SDHI nodes (just because that seems to be the order in other
Renesas SoCs DTs)
Chris Brandt (3):
ARM: dts: r7s72100: add sdhi clock to device tree
ARM: dts: r7s72100: add sdhi to device tree
ARM: dts: rskrza1: add sdhi1 DT support
arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++
arch/arm/boot/dts/r7s72100.dtsi | 36 ++++++++++++++++++++++++++++++
include/dt-bindings/clock/r7s72100-clock.h | 4 ++++
3 files changed, 44 insertions(+)
--
2.9.2
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree 2016-09-22 21:32 [PATCH 0/3] ARM: dts: r7s72100: add sdhi DT Chris Brandt @ 2016-09-22 21:32 ` Chris Brandt 2016-09-23 6:59 ` Geert Uytterhoeven 2016-09-22 21:32 ` [PATCH 2/3] ARM: dts: r7s72100: add sdhi " Chris Brandt [not found] ` <20160922213211.7988-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2 siblings, 1 reply; 17+ messages in thread From: Chris Brandt @ 2016-09-22 21:32 UTC (permalink / raw) To: Geert Uytterhoeven, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree, linux-renesas-soc, Chris Brandt Signed-off-by: Chris Brandt <chris.brandt@renesas.com> --- arch/arm/boot/dts/r7s72100.dtsi | 8 ++++++++ include/dt-bindings/clock/r7s72100-clock.h | 4 ++++ 2 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index e18d4e6..e97d6d1 100644 --- a/arch/arm/boot/dts/r7s72100.dtsi +++ b/arch/arm/boot/dts/r7s72100.dtsi @@ -149,6 +149,14 @@ >; clock-output-names = "spi0", "spi1", "spi2", "spi3", "spi4"; }; + mstp12_clks: mstp12_clks@fcfe0444 { + #clock-cells = <1>; + compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; + reg = <0xfcfe0444 4>; + clocks = <&p1_clk>, <&p1_clk>; + clock-indices = <R7S72100_CLK_SDHI1 R7S72100_CLK_SDHI0>; + clock-output-names = "sdhi1", "sdhi0"; + }; }; cpus { diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/clock/r7s72100-clock.h index 5eaf0fb..29e01ed 100644 --- a/include/dt-bindings/clock/r7s72100-clock.h +++ b/include/dt-bindings/clock/r7s72100-clock.h @@ -44,4 +44,8 @@ #define R7S72100_CLK_SPI3 4 #define R7S72100_CLK_SPI4 3 +/* MSTP12 */ +#define R7S72100_CLK_SDHI0 3 +#define R7S72100_CLK_SDHI1 2 + #endif /* __DT_BINDINGS_CLOCK_R7S72100_H__ */ -- 2.9.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree 2016-09-22 21:32 ` [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree Chris Brandt @ 2016-09-23 6:59 ` Geert Uytterhoeven [not found] ` <CAMuHMdX_7HbtaLPCeMHy1Knk6pfTazP+RKxzM7vdyzAof1Kh1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 17+ messages in thread From: Geert Uytterhoeven @ 2016-09-23 6:59 UTC (permalink / raw) To: Chris Brandt Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <CAMuHMdX_7HbtaLPCeMHy1Knk6pfTazP+RKxzM7vdyzAof1Kh1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree 2016-09-23 6:59 ` Geert Uytterhoeven @ 2016-09-26 14:52 ` Simon Horman 0 siblings, 0 replies; 17+ messages in thread From: Simon Horman @ 2016-09-26 14:52 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Chris Brandt, Magnus Damm, Rob Herring, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-Renesas On Fri, Sep 23, 2016 at 08:59:11AM +0200, Geert Uytterhoeven wrote: > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote: > > Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> > > Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> Thanks, I have queued up this (and only this) patch. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree @ 2016-09-26 14:52 ` Simon Horman 0 siblings, 0 replies; 17+ messages in thread From: Simon Horman @ 2016-09-26 14:52 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Chris Brandt, Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas On Fri, Sep 23, 2016 at 08:59:11AM +0200, Geert Uytterhoeven wrote: > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I have queued up this (and only this) patch. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/3] ARM: dts: r7s72100: add sdhi to device tree 2016-09-22 21:32 [PATCH 0/3] ARM: dts: r7s72100: add sdhi DT Chris Brandt 2016-09-22 21:32 ` [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree Chris Brandt @ 2016-09-22 21:32 ` Chris Brandt 2016-09-23 7:05 ` Geert Uytterhoeven [not found] ` <20160922213211.7988-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2 siblings, 1 reply; 17+ messages in thread From: Chris Brandt @ 2016-09-22 21:32 UTC (permalink / raw) To: Geert Uytterhoeven, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree, linux-renesas-soc, Chris Brandt Signed-off-by: Chris Brandt <chris.brandt@renesas.com> --- arch/arm/boot/dts/r7s72100.dtsi | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index e97d6d1..8e69399 100644 --- a/arch/arm/boot/dts/r7s72100.dtsi +++ b/arch/arm/boot/dts/r7s72100.dtsi @@ -458,4 +458,32 @@ #size-cells = <0>; status = "disabled"; }; + + sdhi0: sd@e804e000 { + compatible = "renesas,sdhi-r7s72100"; + reg = <0xe804e000 0x100>; + interrupts = <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 271 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; + + clocks = <&mstp12_clks R7S72100_CLK_SDHI0>; + cap-sd-highspeed; + cap-sdio-irq; + bus-width = <4>; + status = "disabled"; + }; + + sdhi1: sd@e804e800 { + compatible = "renesas,sdhi-r7s72100"; + reg = <0xe804e800 0x100>; + interrupts = <GIC_SPI 273 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 274 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 275 IRQ_TYPE_LEVEL_HIGH>; + + clocks = <&mstp12_clks R7S72100_CLK_SDHI1>; + cap-sd-highspeed; + cap-sdio-irq; + bus-width = <4>; + status = "disabled"; + }; }; -- 2.9.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 2/3] ARM: dts: r7s72100: add sdhi to device tree 2016-09-22 21:32 ` [PATCH 2/3] ARM: dts: r7s72100: add sdhi " Chris Brandt @ 2016-09-23 7:05 ` Geert Uytterhoeven 2016-09-23 14:20 ` Chris Brandt 0 siblings, 1 reply; 17+ messages in thread From: Geert Uytterhoeven @ 2016-09-23 7:05 UTC (permalink / raw) To: Chris Brandt Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas Hi Chris, On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> (due to lack of documentation about SDHI, for the interrupt numbers only) > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -458,4 +458,32 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + sdhi0: sd@e804e000 { > + compatible = "renesas,sdhi-r7s72100"; > + reg = <0xe804e000 0x100>; > + interrupts = <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH > + GIC_SPI 271 IRQ_TYPE_LEVEL_HIGH > + GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > + Cannot chcck the required order, but the interrupts are called SDHI0_3, SDHI0_0, and SDHI0_1 in the datasheet. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH 2/3] ARM: dts: r7s72100: add sdhi to device tree 2016-09-23 7:05 ` Geert Uytterhoeven @ 2016-09-23 14:20 ` Chris Brandt 2016-09-23 14:32 ` Geert Uytterhoeven 0 siblings, 1 reply; 17+ messages in thread From: Chris Brandt @ 2016-09-23 14:20 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas Hi Geert, > (due to lack of documentation about SDHI, for the interrupt numbers only) > > > --- a/arch/arm/boot/dts/r7s72100.dtsi > > +++ b/arch/arm/boot/dts/r7s72100.dtsi > > @@ -458,4 +458,32 @@ > > #size-cells = <0>; > > status = "disabled"; > > }; > > + > > + sdhi0: sd@e804e000 { > > + compatible = "renesas,sdhi-r7s72100"; > > + reg = <0xe804e000 0x100>; > > + interrupts = <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH > > + GIC_SPI 271 IRQ_TYPE_LEVEL_HIGH > > + GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > > + > > Cannot chcck the required order, but the interrupts are called SDHI0_3, > SDHI0_0, and SDHI0_1 in the datasheet. From the hardware manual, "Table 7.3 List of Interrupt IDs": SD host Interface, Channel 0: ----------------------------- SDHI0_3 = ID 302 (302 - 32 = 270) SDHI0_0 = ID 303 (303 - 32 = 271) SDHI0_1 = ID 304 (304 - 32 = 272) #NOTE: The new 3.0 version of the hardware manual that will be coming out will now have the SDHI chapter included. So, in reference to that 3.0 manual: "50.3.3 Interrupt Request and DMA Transfer Request" "Table 50.4 Interrupt Request" ----------------------------- Card detect interrupt = SDHI3 Card access interrupt = SDHI0 SDIO access interrupt = SDHI1 Regardless, in sh_mobile_sdhi.c, they all get mapped to the same ISR function anyway: i = 0; while (1) { irq = platform_get_irq(pdev, i); if (irq < 0) break; i++; ret = devm_request_irq(&pdev->dev, irq, tmio_mmc_irq, 0, dev_name(&pdev->dev), host); if (ret) goto eirq; } Chris ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/3] ARM: dts: r7s72100: add sdhi to device tree 2016-09-23 14:20 ` Chris Brandt @ 2016-09-23 14:32 ` Geert Uytterhoeven 0 siblings, 0 replies; 17+ messages in thread From: Geert Uytterhoeven @ 2016-09-23 14:32 UTC (permalink / raw) To: Chris Brandt Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas, Wolfram Sang Hi Chris, On Fri, Sep 23, 2016 at 4:20 PM, Chris Brandt <Chris.Brandt@renesas.com> wrote: >> (due to lack of documentation about SDHI, for the interrupt numbers only) >> >> > --- a/arch/arm/boot/dts/r7s72100.dtsi >> > +++ b/arch/arm/boot/dts/r7s72100.dtsi >> > @@ -458,4 +458,32 @@ >> > #size-cells = <0>; >> > status = "disabled"; >> > }; >> > + >> > + sdhi0: sd@e804e000 { >> > + compatible = "renesas,sdhi-r7s72100"; >> > + reg = <0xe804e000 0x100>; >> > + interrupts = <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH >> > + GIC_SPI 271 IRQ_TYPE_LEVEL_HIGH >> > + GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; >> > + >> >> Cannot chcck the required order, but the interrupts are called SDHI0_3, >> SDHI0_0, and SDHI0_1 in the datasheet. > > From the hardware manual, "Table 7.3 List of Interrupt IDs": > > SD host Interface, Channel 0: > ----------------------------- > SDHI0_3 = ID 302 (302 - 32 = 270) > SDHI0_0 = ID 303 (303 - 32 = 271) > SDHI0_1 = ID 304 (304 - 32 = 272) > > > #NOTE: The new 3.0 version of the hardware manual that will be coming out will now have the SDHI chapter included. > > So, in reference to that 3.0 manual: > > "50.3.3 Interrupt Request and DMA Transfer Request" > "Table 50.4 Interrupt Request" > ----------------------------- > Card detect interrupt = SDHI3 > Card access interrupt = SDHI0 > SDIO access interrupt = SDHI1 Thanks for checking! However, this is another driver that doesn't document anything about the interrupts in the DT bindings :-( > Regardless, in sh_mobile_sdhi.c, they all get mapped to the same ISR function anyway: > > i = 0; > while (1) { > irq = platform_get_irq(pdev, i); > if (irq < 0) > break; > i++; > ret = devm_request_irq(&pdev->dev, irq, tmio_mmc_irq, 0, > dev_name(&pdev->dev), host); > if (ret) > goto eirq; > } Uuh, then it doesn't matter much ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <20160922213211.7988-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]
* [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support 2016-09-22 21:32 [PATCH 0/3] ARM: dts: r7s72100: add sdhi DT Chris Brandt @ 2016-09-22 21:32 ` Chris Brandt 2016-09-22 21:32 ` [PATCH 2/3] ARM: dts: r7s72100: add sdhi " Chris Brandt [not found] ` <20160922213211.7988-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2 siblings, 0 replies; 17+ messages in thread From: Chris Brandt @ 2016-09-22 21:32 UTC (permalink / raw) To: Geert Uytterhoeven, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Chris Brandt Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> --- arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts index e5dea5b..548b51f 100644 --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts @@ -56,6 +56,10 @@ }; }; +&sdhi1 { + status = "okay"; +}; + &scif2 { status = "okay"; }; -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support @ 2016-09-22 21:32 ` Chris Brandt 0 siblings, 0 replies; 17+ messages in thread From: Chris Brandt @ 2016-09-22 21:32 UTC (permalink / raw) To: Geert Uytterhoeven, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree, linux-renesas-soc, Chris Brandt Signed-off-by: Chris Brandt <chris.brandt@renesas.com> --- arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts index e5dea5b..548b51f 100644 --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts @@ -56,6 +56,10 @@ }; }; +&sdhi1 { + status = "okay"; +}; + &scif2 { status = "okay"; }; -- 2.9.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support 2016-09-22 21:32 ` Chris Brandt (?) @ 2016-09-23 7:09 ` Geert Uytterhoeven [not found] ` <CAMuHMdWckFaU__BM=WAOvJ+fVjEvNdLCFy0GNiKwU159aZTdhg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> -1 siblings, 1 reply; 17+ messages in thread From: Geert Uytterhoeven @ 2016-09-23 7:09 UTC (permalink / raw) To: Chris Brandt Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > --- > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts > index e5dea5b..548b51f 100644 > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts > @@ -56,6 +56,10 @@ > }; > }; > > +&sdhi1 { > + status = "okay"; On all other boards, we have the bus-width property in the board-specific .dts instead of in the SoC-specific .dtsi. > +}; > + > &scif2 { > status = "okay"; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <CAMuHMdWckFaU__BM=WAOvJ+fVjEvNdLCFy0GNiKwU159aZTdhg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support 2016-09-23 7:09 ` Geert Uytterhoeven @ 2016-09-23 7:41 ` Simon Horman 0 siblings, 0 replies; 17+ messages in thread From: Simon Horman @ 2016-09-23 7:41 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Chris Brandt, Magnus Damm, Rob Herring, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-Renesas On Fri, Sep 23, 2016 at 09:09:07AM +0200, Geert Uytterhoeven wrote: > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote: > > Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> > > --- > > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > index e5dea5b..548b51f 100644 > > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts > > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > @@ -56,6 +56,10 @@ > > }; > > }; > > > > +&sdhi1 { > > + status = "okay"; > > On all other boards, we have the bus-width property in the board-specific > .dts instead of in the SoC-specific .dtsi. I'd like us to be consistent as much as possible. But I do wonder why it has been added as a board property. > > +}; > > + > > &scif2 { > > status = "okay"; > > }; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support @ 2016-09-23 7:41 ` Simon Horman 0 siblings, 0 replies; 17+ messages in thread From: Simon Horman @ 2016-09-23 7:41 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Chris Brandt, Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas On Fri, Sep 23, 2016 at 09:09:07AM +0200, Geert Uytterhoeven wrote: > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > --- > > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > index e5dea5b..548b51f 100644 > > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts > > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > @@ -56,6 +56,10 @@ > > }; > > }; > > > > +&sdhi1 { > > + status = "okay"; > > On all other boards, we have the bus-width property in the board-specific > .dts instead of in the SoC-specific .dtsi. I'd like us to be consistent as much as possible. But I do wonder why it has been added as a board property. > > +}; > > + > > &scif2 { > > status = "okay"; > > }; ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <20160923074123.GD20129-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* RE: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support 2016-09-23 7:41 ` Simon Horman @ 2016-09-23 14:33 ` Chris Brandt -1 siblings, 0 replies; 17+ messages in thread From: Chris Brandt @ 2016-09-23 14:33 UTC (permalink / raw) To: Simon Horman, Geert Uytterhoeven Cc: Magnus Damm, Rob Herring, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-Renesas > > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt > <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote: > > > Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> > > > --- > > > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > index e5dea5b..548b51f 100644 > > > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > @@ -56,6 +56,10 @@ > > > }; > > > }; > > > > > > +&sdhi1 { > > > + status = "okay"; > > > > On all other boards, we have the bus-width property in the > > board-specific .dts instead of in the SoC-specific .dtsi. I did see that. But, in my opinion, using 4-bit SDHI is way more common that 1-bit SDHI. So I figured I'd make 4-bit the 'default' by putting it in the dtsi, and if for some reason someone needed 1-bit, they could override it in the board .dts. > I'd like us to be consistent as much as possible. > But I do wonder why it has been added as a board property. It doesn't really matter to me. If you want me to move it to the board dts it to keep it consistent, just let me know and I'll change it. Chris -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support @ 2016-09-23 14:33 ` Chris Brandt 0 siblings, 0 replies; 17+ messages in thread From: Chris Brandt @ 2016-09-23 14:33 UTC (permalink / raw) To: Simon Horman, Geert Uytterhoeven Cc: Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas > > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt > <chris.brandt@renesas.com> wrote: > > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > > --- > > > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > index e5dea5b..548b51f 100644 > > > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > @@ -56,6 +56,10 @@ > > > }; > > > }; > > > > > > +&sdhi1 { > > > + status = "okay"; > > > > On all other boards, we have the bus-width property in the > > board-specific .dts instead of in the SoC-specific .dtsi. I did see that. But, in my opinion, using 4-bit SDHI is way more common that 1-bit SDHI. So I figured I'd make 4-bit the 'default' by putting it in the dtsi, and if for some reason someone needed 1-bit, they could override it in the board .dts. > I'd like us to be consistent as much as possible. > But I do wonder why it has been added as a board property. It doesn't really matter to me. If you want me to move it to the board dts it to keep it consistent, just let me know and I'll change it. Chris ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support 2016-09-23 14:33 ` Chris Brandt (?) @ 2016-09-26 14:44 ` Simon Horman -1 siblings, 0 replies; 17+ messages in thread From: Simon Horman @ 2016-09-26 14:44 UTC (permalink / raw) To: Chris Brandt Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Mark Rutland, devicetree, Linux-Renesas On Fri, Sep 23, 2016 at 02:33:10PM +0000, Chris Brandt wrote: > > > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt > > <chris.brandt@renesas.com> wrote: > > > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > > > --- > > > > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > > b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > > index e5dea5b..548b51f 100644 > > > > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts > > > > @@ -56,6 +56,10 @@ > > > > }; > > > > }; > > > > > > > > +&sdhi1 { > > > > + status = "okay"; > > > > > > On all other boards, we have the bus-width property in the > > > board-specific .dts instead of in the SoC-specific .dtsi. > > I did see that. > But, in my opinion, using 4-bit SDHI is way more common that 1-bit SDHI. > So I figured I'd make 4-bit the 'default' by putting it in the dtsi, and if for some reason someone needed 1-bit, they could override it in the board .dts. > > > > I'd like us to be consistent as much as possible. > > But I do wonder why it has been added as a board property. > > It doesn't really matter to me. If you want me to move it to the board dts it to keep it consistent, just let me know and I'll change it. Please do. ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2016-09-26 14:52 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-22 21:32 [PATCH 0/3] ARM: dts: r7s72100: add sdhi DT Chris Brandt
2016-09-22 21:32 ` [PATCH 1/3] ARM: dts: r7s72100: add sdhi clock to device tree Chris Brandt
2016-09-23 6:59 ` Geert Uytterhoeven
[not found] ` <CAMuHMdX_7HbtaLPCeMHy1Knk6pfTazP+RKxzM7vdyzAof1Kh1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-26 14:52 ` Simon Horman
2016-09-26 14:52 ` Simon Horman
2016-09-22 21:32 ` [PATCH 2/3] ARM: dts: r7s72100: add sdhi " Chris Brandt
2016-09-23 7:05 ` Geert Uytterhoeven
2016-09-23 14:20 ` Chris Brandt
2016-09-23 14:32 ` Geert Uytterhoeven
[not found] ` <20160922213211.7988-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-09-22 21:32 ` [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support Chris Brandt
2016-09-22 21:32 ` Chris Brandt
2016-09-23 7:09 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWckFaU__BM=WAOvJ+fVjEvNdLCFy0GNiKwU159aZTdhg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-23 7:41 ` Simon Horman
2016-09-23 7:41 ` Simon Horman
[not found] ` <20160923074123.GD20129-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2016-09-23 14:33 ` Chris Brandt
2016-09-23 14:33 ` Chris Brandt
2016-09-26 14:44 ` Simon Horman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.